* [PATCH v3 0/2] Mediatek ethernet patches for mt8188
@ 2022-09-21 7:07 Jianguo Zhang
2022-09-21 7:07 ` [PATCH v3 1/2] dt-bindings: net: mediatek-dwmac: add support " Jianguo Zhang
2022-09-21 7:07 ` [PATCH v3 2/2] dt-bindings: net: snps,dwmac: add clk_csr property Jianguo Zhang
0 siblings, 2 replies; 9+ messages in thread
From: Jianguo Zhang @ 2022-09-21 7:07 UTC (permalink / raw)
To: David S . Miller, Rob Herring, Krzysztof Kozlowski,
AngeloGioacchino Del Regno
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger,
Biao Huang, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel, linux-mediatek, Jianguo Zhang
Changes in v3:
v3:
1) List the names of SoCs mt8188 and mt8195 in correct order as
AngeloGioacchino Del Regno's comment.
2) Add patch version info as Krzysztof Kozlowski'comment.
v2:
1) Delete patch 'stmmac: dwmac-mediatek: add support for mt8188' as
Krzysztof Kozlowski's comment.
2) Update patch 'dt-bindings: net: mediatek-dwmac: add support for
mt8188' as Krzysztof Kozlowski's comment.
3) Add clk_csr property to fix warning ('clk_csr' was unexpected) when
runnig 'make dtbs_check'.
v1:
1) Add ethernet driver entry for mt8188.
2) Add binding document for ethernet on mt8188.
Jianguo Zhang (2):
dt-bindings: net: mediatek-dwmac: add support for mt8188
dt-bindings: net: snps,dwmac: add clk_csr property
.../devicetree/bindings/net/mediatek-dwmac.yaml | 10 ++++++++--
Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++++
2 files changed, 13 insertions(+), 2 deletions(-)
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3 1/2] dt-bindings: net: mediatek-dwmac: add support for mt8188
2022-09-21 7:07 [PATCH v3 0/2] Mediatek ethernet patches for mt8188 Jianguo Zhang
@ 2022-09-21 7:07 ` Jianguo Zhang
2022-09-21 7:58 ` AngeloGioacchino Del Regno
2022-09-21 8:22 ` Krzysztof Kozlowski
2022-09-21 7:07 ` [PATCH v3 2/2] dt-bindings: net: snps,dwmac: add clk_csr property Jianguo Zhang
1 sibling, 2 replies; 9+ messages in thread
From: Jianguo Zhang @ 2022-09-21 7:07 UTC (permalink / raw)
To: David S . Miller, Rob Herring, Krzysztof Kozlowski,
AngeloGioacchino Del Regno
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger,
Biao Huang, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel, linux-mediatek, Jianguo Zhang
Add binding document for the ethernet on mt8188
Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com>
---
.../devicetree/bindings/net/mediatek-dwmac.yaml | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
index 61b2fb9e141b..0fa2132fa4f4 100644
--- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
@@ -19,6 +19,7 @@ select:
contains:
enum:
- mediatek,mt2712-gmac
+ - mediatek,mt8188-gmac
- mediatek,mt8195-gmac
required:
- compatible
@@ -37,6 +38,11 @@ properties:
- enum:
- mediatek,mt8195-gmac
- const: snps,dwmac-5.10a
+ - items:
+ - enum:
+ - mediatek,mt8188-gmac
+ - const: mediatek,mt8195-gmac
+ - const: snps,dwmac-5.10a
clocks:
minItems: 5
@@ -74,7 +80,7 @@ properties:
or will round down. Range 0~31*170.
For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550,
or will round down. Range 0~31*550.
- For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290,
+ For MT8188/MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290,
or will round down. Range 0~31*290.
mediatek,rx-delay-ps:
@@ -84,7 +90,7 @@ properties:
or will round down. Range 0~31*170.
For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550,
or will round down. Range 0~31*550.
- For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple
+ For MT8188/MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple
of 290, or will round down. Range 0~31*290.
mediatek,rmii-rxc:
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v3 2/2] dt-bindings: net: snps,dwmac: add clk_csr property
2022-09-21 7:07 [PATCH v3 0/2] Mediatek ethernet patches for mt8188 Jianguo Zhang
2022-09-21 7:07 ` [PATCH v3 1/2] dt-bindings: net: mediatek-dwmac: add support " Jianguo Zhang
@ 2022-09-21 7:07 ` Jianguo Zhang
2022-09-21 8:24 ` Krzysztof Kozlowski
1 sibling, 1 reply; 9+ messages in thread
From: Jianguo Zhang @ 2022-09-21 7:07 UTC (permalink / raw)
To: David S . Miller, Rob Herring, Krzysztof Kozlowski,
AngeloGioacchino Del Regno
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger,
Biao Huang, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel, linux-mediatek, Jianguo Zhang
Add clk_csr property for snps,dwmac
Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com>
---
Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index 491597c02edf..8cff30a8125d 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -288,6 +288,11 @@ properties:
is supported. For example, this is used in case of SGMII and
MAC2MAC connection.
+ clk_csr:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ Frequency division factor for MDC clock.
+
mdio:
$ref: mdio.yaml#
unevaluatedProperties: false
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: net: mediatek-dwmac: add support for mt8188
2022-09-21 7:07 ` [PATCH v3 1/2] dt-bindings: net: mediatek-dwmac: add support " Jianguo Zhang
@ 2022-09-21 7:58 ` AngeloGioacchino Del Regno
2022-09-21 8:22 ` Krzysztof Kozlowski
1 sibling, 0 replies; 9+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-09-21 7:58 UTC (permalink / raw)
To: Jianguo Zhang, David S . Miller, Rob Herring, Krzysztof Kozlowski
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger,
Biao Huang, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel, linux-mediatek
Il 21/09/22 09:07, Jianguo Zhang ha scritto:
> Add binding document for the ethernet on mt8188
>
> Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: net: mediatek-dwmac: add support for mt8188
2022-09-21 7:07 ` [PATCH v3 1/2] dt-bindings: net: mediatek-dwmac: add support " Jianguo Zhang
2022-09-21 7:58 ` AngeloGioacchino Del Regno
@ 2022-09-21 8:22 ` Krzysztof Kozlowski
1 sibling, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-21 8:22 UTC (permalink / raw)
To: Jianguo Zhang, David S . Miller, Rob Herring,
Krzysztof Kozlowski, AngeloGioacchino Del Regno
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger,
Biao Huang, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel, linux-mediatek
On 21/09/2022 09:07, Jianguo Zhang wrote:
> Add binding document for the ethernet on mt8188
>
> Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com>
> ---
> .../devicetree/bindings/net/mediatek-dwmac.yaml | 10 ++++++++--
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: snps,dwmac: add clk_csr property
2022-09-21 7:07 ` [PATCH v3 2/2] dt-bindings: net: snps,dwmac: add clk_csr property Jianguo Zhang
@ 2022-09-21 8:24 ` Krzysztof Kozlowski
2022-09-22 2:15 ` Jianguo Zhang
0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-21 8:24 UTC (permalink / raw)
To: Jianguo Zhang, David S . Miller, Rob Herring,
Krzysztof Kozlowski, AngeloGioacchino Del Regno
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger,
Biao Huang, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel, linux-mediatek
On 21/09/2022 09:07, Jianguo Zhang wrote:
> Add clk_csr property for snps,dwmac
>
> Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com>
> ---
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 491597c02edf..8cff30a8125d 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -288,6 +288,11 @@ properties:
> is supported. For example, this is used in case of SGMII and
> MAC2MAC connection.
>
> + clk_csr:
No underscores in node names. Missing vendor prefix.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Frequency division factor for MDC clock.
Can't common clock framework do the job? What is the MDC clock?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: snps,dwmac: add clk_csr property
2022-09-21 8:24 ` Krzysztof Kozlowski
@ 2022-09-22 2:15 ` Jianguo Zhang
2022-09-22 6:38 ` Krzysztof Kozlowski
0 siblings, 1 reply; 9+ messages in thread
From: Jianguo Zhang @ 2022-09-22 2:15 UTC (permalink / raw)
To: Krzysztof Kozlowski, David S . Miller, Rob Herring,
Krzysztof Kozlowski, AngeloGioacchino Del Regno
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger,
Biao Huang, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel, linux-mediatek
Dear Krzysztof,
Thanks for your comment.
On Wed, 2022-09-21 at 10:24 +0200, Krzysztof Kozlowski wrote:
> On 21/09/2022 09:07, Jianguo Zhang wrote:
> > Add clk_csr property for snps,dwmac
> >
> > Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > index 491597c02edf..8cff30a8125d 100644
> > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > @@ -288,6 +288,11 @@ properties:
> > is supported. For example, this is used in case of SGMII and
> > MAC2MAC connection.
> >
> > + clk_csr:
>
> No underscores in node names. Missing vendor prefix.
>
We will remane the property name 'clk_csr' as 'snps,clk-csr' and
another driver patch is needed to align the name used in driver with
the new name.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description:
> > + Frequency division factor for MDC clock.
>
> Can't common clock framework do the job? What is the MDC clock?
>
MDC clock is used for ethernet MAC accessing PHY register by MDIO bus.
There is frequency divider designed in ethernet internal HW to ensure
that ethernet can get correct frequency of MDC colck and the vlaue of
frequency divider can be got from DTS.
> Best regards,
> Krzysztof
BRS
Jianguo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: snps,dwmac: add clk_csr property
2022-09-22 2:15 ` Jianguo Zhang
@ 2022-09-22 6:38 ` Krzysztof Kozlowski
2022-09-22 7:36 ` Jianguo Zhang
0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-22 6:38 UTC (permalink / raw)
To: Jianguo Zhang, David S . Miller, Rob Herring,
Krzysztof Kozlowski, AngeloGioacchino Del Regno
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger,
Biao Huang, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel, linux-mediatek
On 22/09/2022 04:15, Jianguo Zhang wrote:
> Dear Krzysztof,
>
> Thanks for your comment.
>
> On Wed, 2022-09-21 at 10:24 +0200, Krzysztof Kozlowski wrote:
>> On 21/09/2022 09:07, Jianguo Zhang wrote:
>>> Add clk_csr property for snps,dwmac
>>>
>>> Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com>
>>> ---
>>> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>>> b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>>> index 491597c02edf..8cff30a8125d 100644
>>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>>> @@ -288,6 +288,11 @@ properties:
>>> is supported. For example, this is used in case of SGMII and
>>> MAC2MAC connection.
>>>
>>> + clk_csr:
>>
>> No underscores in node names. Missing vendor prefix.
>>
> We will remane the property name 'clk_csr' as 'snps,clk-csr' and
> another driver patch is needed to align the name used in driver with
> the new name.
You did not say anything that you document existing property. Commit msg
*must* explain why you are doing stuff in commit body.
We should not be asking for this and for reason of clk_csr.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: snps,dwmac: add clk_csr property
2022-09-22 6:38 ` Krzysztof Kozlowski
@ 2022-09-22 7:36 ` Jianguo Zhang
0 siblings, 0 replies; 9+ messages in thread
From: Jianguo Zhang @ 2022-09-22 7:36 UTC (permalink / raw)
To: Krzysztof Kozlowski, David S . Miller, Rob Herring,
Krzysztof Kozlowski, AngeloGioacchino Del Regno
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger,
Biao Huang, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel, linux-mediatek
Dear Krzysztof,
On Thu, 2022-09-22 at 08:38 +0200, Krzysztof Kozlowski wrote:
> On 22/09/2022 04:15, Jianguo Zhang wrote:
> > Dear Krzysztof,
> >
> > Thanks for your comment.
> >
> > On Wed, 2022-09-21 at 10:24 +0200, Krzysztof Kozlowski wrote:
> > > On 21/09/2022 09:07, Jianguo Zhang wrote:
> > > > Add clk_csr property for snps,dwmac
> > > >
> > > > Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com>
> > > > ---
> > > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5
> > > > +++++
> > > > 1 file changed, 5 insertions(+)
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > > > b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > > > index 491597c02edf..8cff30a8125d 100644
> > > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > > > @@ -288,6 +288,11 @@ properties:
> > > > is supported. For example, this is used in case of SGMII
> > > > and
> > > > MAC2MAC connection.
> > > >
> > > > + clk_csr:
> > >
> > > No underscores in node names. Missing vendor prefix.
> > >
> >
> > We will remane the property name 'clk_csr' as 'snps,clk-csr' and
> > another driver patch is needed to align the name used in driver
> > with
> > the new name.
>
> You did not say anything that you document existing property. Commit
> msg
> *must* explain why you are doing stuff in commit body.
>
> We should not be asking for this and for reason of clk_csr.
We will explain the background that why we document 'clk_csr' property
in binding file in commit message in next version patches.
>
> Best regards,
> Krzysztof
>
BRS
Jianguo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-09-22 7:38 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-21 7:07 [PATCH v3 0/2] Mediatek ethernet patches for mt8188 Jianguo Zhang
2022-09-21 7:07 ` [PATCH v3 1/2] dt-bindings: net: mediatek-dwmac: add support " Jianguo Zhang
2022-09-21 7:58 ` AngeloGioacchino Del Regno
2022-09-21 8:22 ` Krzysztof Kozlowski
2022-09-21 7:07 ` [PATCH v3 2/2] dt-bindings: net: snps,dwmac: add clk_csr property Jianguo Zhang
2022-09-21 8:24 ` Krzysztof Kozlowski
2022-09-22 2:15 ` Jianguo Zhang
2022-09-22 6:38 ` Krzysztof Kozlowski
2022-09-22 7:36 ` Jianguo Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).