[PATCH 0/2] dt-bindings: PCI: ti,j721e-pci-*: resolve unexpected property warnings

[PATCH 0/2] dt-bindings: PCI: ti,j721e-pci-*: resolve unexpected property warnings

[Matt Ranostay]

Resolve unexpected property warnings related to interrupts in both J721E PCI EP and host
yaml files.

Matt Ranostay (2):
  dt-bindings: PCI: ti,j721e-pci-host: add interrupt controller
    definition
  dt-bindings: PCI: ti,j721e-pci-*: Add missing interrupt properties

 .../bindings/pci/ti,j721e-pci-ep.yaml         |  7 +++++++
 .../bindings/pci/ti,j721e-pci-host.yaml       | 20 +++++++++++++++++++
 2 files changed, 27 insertions(+)

-- 
2.38.0.rc0.52.gdda7228a83


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 1/2] dt-bindings: PCI: ti,j721e-pci-host: add interrupt controller definition

[Matt Ranostay]

Add missing 'interrupt-controller' property and related subnodes to resolve
the following warning:

arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: pcie@2910000: Unevaluated properties are not allowed ('interrupt-conroller' was unexpected)
        From schema: Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml

Signed-off-by: Matt Ranostay <mranostay@ti.com>
---
 .../devicetree/bindings/pci/ti,j721e-pci-host.yaml  | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
index 2115d5a3f0e1..0f5914a22c14 100644
--- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
@@ -76,6 +76,19 @@ properties:
 
   msi-map: true
 
+  interrupt-controller:
+    type: object
+    additionalProperties: false
+
+    properties:
+      interrupt-controller: true
+
+      '#interrupt-cells':
+        const: 1
+
+      interrupts:
+        maxItems: 1
+
 required:
   - compatible
   - reg
-- 
2.38.0.rc0.52.gdda7228a83


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/2] dt-bindings: PCI: ti,j721e-pci-*: Add missing interrupt properties

[Matt Ranostay]

Both interrupts, and interrupt names weren't defined in both EP and host
yaml. Also define the only possible interrupt-name as link_state, and
maxItems of interrupts to one.

This patch resolves the following warning:

arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: pcie-ep@2910000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected)
        From schema Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml

Signed-off-by: Matt Ranostay <mranostay@ti.com>
---
 Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml | 7 +++++++
 .../devicetree/bindings/pci/ti,j721e-pci-host.yaml         | 7 +++++++
 2 files changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml
index aed437dac363..10e6eabdff53 100644
--- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml
@@ -58,6 +58,13 @@ properties:
   dma-coherent:
     description: Indicates that the PCIe IP block can ensure the coherency
 
+  interrupts:
+    maxItems: 1
+
+  interrupt-names:
+    items:
+      - const: link_state
+
 required:
   - compatible
   - reg
diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
index 0f5914a22c14..d9df7cd922f1 100644
--- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
@@ -76,6 +76,13 @@ properties:
 
   msi-map: true
 
+  interrupts:
+    maxItems: 1
+
+  interrupt-names:
+    items:
+      - const: link_state
+
   interrupt-controller:
     type: object
     additionalProperties: false
-- 
2.38.0.rc0.52.gdda7228a83


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] dt-bindings: PCI: ti,j721e-pci-host: add interrupt controller definition

[Krzysztof Kozlowski]

On Thu, 22 Sep 2022 13:44:33 -0700, Matt Ranostay wrote:
> Add missing 'interrupt-controller' property and related subnodes to resolve
> the following warning:

You did not Cc respective maintainers on your patch. Use
scripts/get_maintainers.pl.


> 
> arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: pcie@2910000: Unevaluated properties are not allowed ('interrupt-conroller' was unexpected)
>         From schema: Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> 
> Signed-off-by: Matt Ranostay <mranostay@ti.com>
> ---
>  .../devicetree/bindings/pci/ti,j721e-pci-host.yaml  | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/1681334


pcie@2900000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected)
	arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb
	arch/arm64/boot/dts/ti/k3-j721e-sk.dtb

pcie@2910000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected)
	arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dtb
	arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb
	arch/arm64/boot/dts/ti/k3-j721e-sk.dtb

pcie@2920000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected)
	arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb
	arch/arm64/boot/dts/ti/k3-j721e-sk.dtb

pcie@2930000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected)
	arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb
	arch/arm64/boot/dts/ti/k3-j721e-sk.dtb

pcie@f102000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected)
	arch/arm64/boot/dts/ti/k3-am642-evm.dtb
	arch/arm64/boot/dts/ti/k3-am642-sk.dtb

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] dt-bindings: PCI: ti,j721e-pci-*: Add missing interrupt properties

[Krzysztof Kozlowski]

On 22/09/2022 22:44, Matt Ranostay wrote:
> Both interrupts, and interrupt names weren't defined in both EP and host
> yaml. Also define the only possible interrupt-name as link_state, and
> maxItems of interrupts to one.
> 
> This patch resolves the following warning:
> 
> arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: pcie-ep@2910000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected)
>         From schema Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml

Use scripts/get_maintainers.pl to CC all maintainers and relevant
mailing lists.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] dt-bindings: PCI: ti,j721e-pci-host: add interrupt controller definition

[Matt Ranostay]

On Fri, Sep 23, 2022 at 11:31:11AM +0200, Krzysztof Kozlowski wrote:
> On Thu, 22 Sep 2022 13:44:33 -0700, Matt Ranostay wrote:
> > Add missing 'interrupt-controller' property and related subnodes to resolve
> > the following warning:
> 
> You did not Cc respective maintainers on your patch. Use
> scripts/get_maintainers.pl.
>

Yeah noticed I forgot to Cc Rob Herring :-/

> 
> > 
> > arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: pcie@2910000: Unevaluated properties are not allowed ('interrupt-conroller' was unexpected)
> >         From schema: Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> > 
> > Signed-off-by: Matt Ranostay <mranostay@ti.com>
> > ---
> >  .../devicetree/bindings/pci/ti,j721e-pci-host.yaml  | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> 
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
> 
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
> 
> Full log is available here: https://patchwork.ozlabs.org/patch/1681334
> 
> 
> pcie@2900000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected)
> 	arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb
> 	arch/arm64/boot/dts/ti/k3-j721e-sk.dtb
> 
> pcie@2910000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected)
> 	arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dtb
> 	arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb
> 	arch/arm64/boot/dts/ti/k3-j721e-sk.dtb
> 
> pcie@2920000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected)
> 	arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb
> 	arch/arm64/boot/dts/ti/k3-j721e-sk.dtb
> 
> pcie@2930000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected)
> 	arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb
> 	arch/arm64/boot/dts/ti/k3-j721e-sk.dtb
> 
> pcie@f102000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected)
> 	arch/arm64/boot/dts/ti/k3-am642-evm.dtb
> 	arch/arm64/boot/dts/ti/k3-am642-sk.dtb

This get resolved in the second patchset in this series.

- Matt

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] dt-bindings: PCI: ti,j721e-pci-host: add interrupt controller definition

[Krzysztof Kozlowski]

On 24/09/2022 22:46, Matt Ranostay wrote:
> On Fri, Sep 23, 2022 at 11:31:11AM +0200, Krzysztof Kozlowski wrote:
>> On Thu, 22 Sep 2022 13:44:33 -0700, Matt Ranostay wrote:
>>> Add missing 'interrupt-controller' property and related subnodes to resolve
>>> the following warning:
>>
>> You did not Cc respective maintainers on your patch. Use
>> scripts/get_maintainers.pl.
>>
> 
> Yeah noticed I forgot to Cc Rob Herring :-/

You did not Cc anyone... No one from PCI maintainers, no one from DT
bindings.


Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel