From: Kees Cook <keescook@chromium.org>
To: William Zhang <william.zhang@broadcom.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Russell King <linux@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
"Steven Rostedt (Google)" <rostedt@goodmis.org>,
Nick Hawkins <nick.hawkins@hpe.com>,
John Crispin <john@phrozen.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Nicolas Schier <n.schier@avm.de>,
Nick Desaulniers <ndesaulniers@google.com>,
open list <linux-kernel@vger.kernel.org>,
bcm-kernel-feedback-list@broadcom.com, anand.gore@broadcom.com
Subject: Re: [PATCH] ARM: ubsan: select ARCH_HAS_UBSAN_SANITIZE_ALL
Date: Thu, 29 Sep 2022 01:10:37 -0700 [thread overview]
Message-ID: <202209290110.024DC2FE@keescook> (raw)
In-Reply-To: <986bea84-7cc3-9c40-733c-0c766f7a9ebc@broadcom.com>
On Wed, Sep 28, 2022 at 05:33:14PM -0700, William Zhang wrote:
>
>
> On 09/28/2022 04:06 PM, Florian Fainelli wrote:
> > On 9/28/22 11:01, Kees Cook wrote:
> > > On Wed, Sep 28, 2022 at 10:47:39AM -0700, Florian Fainelli wrote:
> > > > From: Seung-Woo Kim <sw0312.kim@samsung.com>
> > > >
> > > > To enable UBSAN on ARM, this patch enables ARCH_HAS_UBSAN_SANITIZE_ALL
> > > > from arm confiuration. Basic kernel bootup test is passed on arm with
> > > > CONFIG_UBSAN_SANITIZE_ALL enabled.
> > > >
> > > > Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> > > > [florian: rebased against v6.0-rc7]
> > > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > >
> > > Ah-ha, thanks for testing this. What devices did you check this on? I
> > > know boot-up on arm32 can be very device-specific.
> >
> > This was tested on an ARCH_BRCMSTB system which is using an ARMv8 CPU
> > booted in AArch32 mode, so virtually equivalent to armv7l. A raspberry
> > Pi 4B is also happily booting with it.
> >
> > >
> > > Which UBSAN configs did you try?
> >
> > All CONFIG_UBSAN_* work with the exception of CONFIG_UBSAN_ALIGNMENT on
> > my ARCH_BRCMSTB system, however it works fine on the Raspberry Pi 4B.
> > Florian
>
> I also tested on a BCM63138 board (ARM A9) under ARCH_BCMBCA using the
> multi_v7_defconfig with all the UBSAN configs enabled except UBSAN_ALIGNMENT
> and board boots up fine. Turning on UBSAN_ALIGNMENT results in flood of
> false positive misaligned-access warnings. This is fine as ARM supports
> unaligned access.
>
> It did catch an out-of-band bug in mach-sunxi smp code. I will submit a
> separate patch to fix that bug.
Yay! :) Move coverage is great. :)
>
> Tested-by: William Zhang <william.zhang@broadcom.com>
Thanks!
--
Kees Cook
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-29 8:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 17:47 [PATCH] ARM: ubsan: select ARCH_HAS_UBSAN_SANITIZE_ALL Florian Fainelli
2022-09-28 18:01 ` Kees Cook
2022-09-28 23:06 ` Florian Fainelli
2022-09-29 0:33 ` William Zhang
2022-09-29 8:10 ` Kees Cook [this message]
2022-09-30 21:34 ` Florian Fainelli
2022-10-04 8:51 ` Linus Walleij
2022-10-12 19:46 ` Florian Fainelli
[not found] <CGME20180313045357epcms1p34fb1e2ad09a8288017058c414c21ce26@epcms1p3>
2018-03-13 4:53 ` [PATCH] arm: " Jinbum Park
2018-03-13 5:13 ` Jaehoon Chung
2018-03-13 5:18 ` Jaehoon Chung
[not found] <CGME20171024055601epcas2p34a22b2b1fb3f1f71ed875125d87a47c4@epcas2p3.samsung.com>
2017-10-24 5:55 ` Seung-Woo Kim
-- strict thread matches above, loose matches on Subject: below --
2016-09-22 4:49 Seung-Woo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209290110.024DC2FE@keescook \
--to=keescook@chromium.org \
--cc=anand.gore@broadcom.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=john@phrozen.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=masahiroy@kernel.org \
--cc=n.schier@avm.de \
--cc=ndesaulniers@google.com \
--cc=nick.hawkins@hpe.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rostedt@goodmis.org \
--cc=sw0312.kim@samsung.com \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).