* [PATCH 1/8] arm64: dts: mt7896a: Fix unit_address_vs_reg warning for oscillator
2022-10-13 15:22 [PATCH 0/8] ARM64 MediaTek devicetree fixes - Part 1 AngeloGioacchino Del Regno
@ 2022-10-13 15:22 ` AngeloGioacchino Del Regno
2022-10-13 15:22 ` [PATCH 2/8] arm64: dts: mt6779: Fix devicetree build warnings AngeloGioacchino Del Regno
` (7 subsequent siblings)
8 siblings, 0 replies; 14+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-13 15:22 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, sam.shih, hanks.chen, weiyi.lu,
zhiyong.tao, andrew-sh.cheng, viresh.kumar, chunfeng.yun,
fparent, mars.cheng, linux-arm-kernel, linux-mediatek,
devicetree, linux-kernel, AngeloGioacchino Del Regno
Rename the oscillator fixed-clock to oscillator-40m and remove
the unit address to fix warnings.
arch/arm64/boot/dts/mediatek/mt7986a.dtsi:17.23-22.4: Warning
(unit_address_vs_reg): /oscillator@0: node has a unit name,
but no reg or ranges property
Fixes: 1f9986b258c2 ("arm64: dts: mediatek: add clock support for mt7986a")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
index 72e0d9722e07..599eb50c8a5b 100644
--- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
@@ -14,7 +14,7 @@ / {
#address-cells = <2>;
#size-cells = <2>;
- clk40m: oscillator@0 {
+ clk40m: oscillator-40m {
compatible = "fixed-clock";
clock-frequency = <40000000>;
#clock-cells = <0>;
--
2.37.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 2/8] arm64: dts: mt6779: Fix devicetree build warnings
2022-10-13 15:22 [PATCH 0/8] ARM64 MediaTek devicetree fixes - Part 1 AngeloGioacchino Del Regno
2022-10-13 15:22 ` [PATCH 1/8] arm64: dts: mt7896a: Fix unit_address_vs_reg warning for oscillator AngeloGioacchino Del Regno
@ 2022-10-13 15:22 ` AngeloGioacchino Del Regno
2022-10-13 15:22 ` [PATCH 3/8] arm64: dts: mt2712e: Fix unit_address_vs_reg warning for oscillators AngeloGioacchino Del Regno
` (6 subsequent siblings)
8 siblings, 0 replies; 14+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-13 15:22 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, sam.shih, hanks.chen, weiyi.lu,
zhiyong.tao, andrew-sh.cheng, viresh.kumar, chunfeng.yun,
fparent, mars.cheng, linux-arm-kernel, linux-mediatek,
devicetree, linux-kernel, AngeloGioacchino Del Regno
Rename fixed-clock oscillators to oscillator-26m and oscillator-32k
and remove the unit address to fix the unit_address_vs_reg warning;
fix the unit address for interrupt and intpol controllers by
removing a leading zero in their unit address.
This commit fixes the following warnings:
(unit_address_vs_reg): /oscillator@0: node has a unit name, but
no reg or ranges property
(unit_address_vs_reg): /oscillator@1: node has a unit name, but
no reg or ranges property
(simple_bus_reg): /soc/interrupt-controller@0c000000: simple-bus
unit address format error, expected "c000000"
(simple_bus_reg): /soc/intpol-controller@0c53a650: simple-bus
unit address format error, expected "c53a650"
Fixes: 4c7a6260775d ("arm64: dts: add dts nodes for MT6779")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt6779.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt6779.dtsi b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
index 9bdf5145966c..dde9ce137b4f 100644
--- a/arch/arm64/boot/dts/mediatek/mt6779.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
@@ -88,14 +88,14 @@ pmu {
interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW 0>;
};
- clk26m: oscillator@0 {
+ clk26m: oscillator-26m {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <26000000>;
clock-output-names = "clk26m";
};
- clk32k: oscillator@1 {
+ clk32k: oscillator-32k {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <32768>;
@@ -117,7 +117,7 @@ soc {
compatible = "simple-bus";
ranges;
- gic: interrupt-controller@0c000000 {
+ gic: interrupt-controller@c000000 {
compatible = "arm,gic-v3";
#interrupt-cells = <4>;
interrupt-parent = <&gic>;
@@ -138,7 +138,7 @@ ppi_cluster1: interrupt-partition-1 {
};
- sysirq: intpol-controller@0c53a650 {
+ sysirq: intpol-controller@c53a650 {
compatible = "mediatek,mt6779-sysirq",
"mediatek,mt6577-sysirq";
interrupt-controller;
--
2.37.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 3/8] arm64: dts: mt2712e: Fix unit_address_vs_reg warning for oscillators
2022-10-13 15:22 [PATCH 0/8] ARM64 MediaTek devicetree fixes - Part 1 AngeloGioacchino Del Regno
2022-10-13 15:22 ` [PATCH 1/8] arm64: dts: mt7896a: Fix unit_address_vs_reg warning for oscillator AngeloGioacchino Del Regno
2022-10-13 15:22 ` [PATCH 2/8] arm64: dts: mt6779: Fix devicetree build warnings AngeloGioacchino Del Regno
@ 2022-10-13 15:22 ` AngeloGioacchino Del Regno
2022-10-13 15:22 ` [PATCH 4/8] arm64: dts: mt2712e: Fix unit address for pinctrl node AngeloGioacchino Del Regno
` (5 subsequent siblings)
8 siblings, 0 replies; 14+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-13 15:22 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, sam.shih, hanks.chen, weiyi.lu,
zhiyong.tao, andrew-sh.cheng, viresh.kumar, chunfeng.yun,
fparent, mars.cheng, linux-arm-kernel, linux-mediatek,
devicetree, linux-kernel, AngeloGioacchino Del Regno
Rename the fixed-clock oscillators to remove the unit address.
This solves unit_address_vs_reg warnings.
Fixes: 5d4839709c8e ("arm64: dts: mt2712: Add clock controller device nodes")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
index e6d7453e56e0..ff6b26cdda81 100644
--- a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
@@ -160,70 +160,70 @@ sys_clk: dummyclk {
#clock-cells = <0>;
};
- clk26m: oscillator@0 {
+ clk26m: oscillator-26m {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <26000000>;
clock-output-names = "clk26m";
};
- clk32k: oscillator@1 {
+ clk32k: oscillator-32k {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <32768>;
clock-output-names = "clk32k";
};
- clkfpc: oscillator@2 {
+ clkfpc: oscillator-50m {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <50000000>;
clock-output-names = "clkfpc";
};
- clkaud_ext_i_0: oscillator@3 {
+ clkaud_ext_i_0: oscillator-aud0 {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <6500000>;
clock-output-names = "clkaud_ext_i_0";
};
- clkaud_ext_i_1: oscillator@4 {
+ clkaud_ext_i_1: oscillator-aud1 {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <196608000>;
clock-output-names = "clkaud_ext_i_1";
};
- clkaud_ext_i_2: oscillator@5 {
+ clkaud_ext_i_2: oscillator-aud2 {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <180633600>;
clock-output-names = "clkaud_ext_i_2";
};
- clki2si0_mck_i: oscillator@6 {
+ clki2si0_mck_i: oscillator-i2s0 {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <30000000>;
clock-output-names = "clki2si0_mck_i";
};
- clki2si1_mck_i: oscillator@7 {
+ clki2si1_mck_i: oscillator-i2s1 {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <30000000>;
clock-output-names = "clki2si1_mck_i";
};
- clki2si2_mck_i: oscillator@8 {
+ clki2si2_mck_i: oscillator-i2s2 {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <30000000>;
clock-output-names = "clki2si2_mck_i";
};
- clktdmin_mclk_i: oscillator@9 {
+ clktdmin_mclk_i: oscillator-mclk {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <30000000>;
--
2.37.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 4/8] arm64: dts: mt2712e: Fix unit address for pinctrl node
2022-10-13 15:22 [PATCH 0/8] ARM64 MediaTek devicetree fixes - Part 1 AngeloGioacchino Del Regno
` (2 preceding siblings ...)
2022-10-13 15:22 ` [PATCH 3/8] arm64: dts: mt2712e: Fix unit_address_vs_reg warning for oscillators AngeloGioacchino Del Regno
@ 2022-10-13 15:22 ` AngeloGioacchino Del Regno
2022-10-13 15:22 ` [PATCH 5/8] arm64: dts: mt2712-evb: Fix vproc fixed regulators unit names AngeloGioacchino Del Regno
` (4 subsequent siblings)
8 siblings, 0 replies; 14+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-13 15:22 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, sam.shih, hanks.chen, weiyi.lu,
zhiyong.tao, andrew-sh.cheng, viresh.kumar, chunfeng.yun,
fparent, mars.cheng, linux-arm-kernel, linux-mediatek,
devicetree, linux-kernel, AngeloGioacchino Del Regno
The unit address for the pinctrl node is (0x)1000b000 and not
(0x)10005000, which is the syscfg_pctl_a address instead.
This fixes the following warning:
arch/arm64/boot/dts/mediatek/mt2712e.dtsi:264.40-267.4: Warning
(unique_unit_address): /syscfg_pctl_a@10005000: duplicate
unit-address (also used in node /pinctrl@10005000)
Fixes: f0c64340b748 ("arm64: dts: mt2712: add pintcrl device node.")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
index ff6b26cdda81..1ac0b2cf3d40 100644
--- a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
@@ -266,7 +266,7 @@ syscfg_pctl_a: syscfg_pctl_a@10005000 {
reg = <0 0x10005000 0 0x1000>;
};
- pio: pinctrl@10005000 {
+ pio: pinctrl@1000b000 {
compatible = "mediatek,mt2712-pinctrl";
reg = <0 0x1000b000 0 0x1000>;
mediatek,pctl-regmap = <&syscfg_pctl_a>;
--
2.37.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 5/8] arm64: dts: mt2712-evb: Fix vproc fixed regulators unit names
2022-10-13 15:22 [PATCH 0/8] ARM64 MediaTek devicetree fixes - Part 1 AngeloGioacchino Del Regno
` (3 preceding siblings ...)
2022-10-13 15:22 ` [PATCH 4/8] arm64: dts: mt2712e: Fix unit address for pinctrl node AngeloGioacchino Del Regno
@ 2022-10-13 15:22 ` AngeloGioacchino Del Regno
2022-10-13 15:22 ` [PATCH 6/8] arm64: dts: mt2712-evb: Fix usb vbus " AngeloGioacchino Del Regno
` (3 subsequent siblings)
8 siblings, 0 replies; 14+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-13 15:22 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, sam.shih, hanks.chen, weiyi.lu,
zhiyong.tao, andrew-sh.cheng, viresh.kumar, chunfeng.yun,
fparent, mars.cheng, linux-arm-kernel, linux-mediatek,
devicetree, linux-kernel, AngeloGioacchino Del Regno
Update the names to regulator-vproc-buck{0,1} to fix unit_addres_vs_reg
warnings for those.
Fixes: f75dd8bdd344 ("arm64: dts: mediatek: add mt2712 cpufreq related device nodes")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
index 9b1af9c80130..638908773706 100644
--- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
@@ -26,14 +26,14 @@ chosen {
stdout-path = "serial0:921600n8";
};
- cpus_fixed_vproc0: fixedregulator@0 {
+ cpus_fixed_vproc0: regulator-vproc-buck0 {
compatible = "regulator-fixed";
regulator-name = "vproc_buck0";
regulator-min-microvolt = <1000000>;
regulator-max-microvolt = <1000000>;
};
- cpus_fixed_vproc1: fixedregulator@1 {
+ cpus_fixed_vproc1: regulator-vproc-buck1 {
compatible = "regulator-fixed";
regulator-name = "vproc_buck1";
regulator-min-microvolt = <1000000>;
--
2.37.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 6/8] arm64: dts: mt2712-evb: Fix usb vbus regulators unit names
2022-10-13 15:22 [PATCH 0/8] ARM64 MediaTek devicetree fixes - Part 1 AngeloGioacchino Del Regno
` (4 preceding siblings ...)
2022-10-13 15:22 ` [PATCH 5/8] arm64: dts: mt2712-evb: Fix vproc fixed regulators unit names AngeloGioacchino Del Regno
@ 2022-10-13 15:22 ` AngeloGioacchino Del Regno
2022-10-14 2:43 ` Chunfeng Yun
2022-10-13 15:22 ` [PATCH 7/8] arm64: dts: mediatek: pumpkin-common: Fix devicetree warnings AngeloGioacchino Del Regno
` (2 subsequent siblings)
8 siblings, 1 reply; 14+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-13 15:22 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, sam.shih, hanks.chen, weiyi.lu,
zhiyong.tao, andrew-sh.cheng, viresh.kumar, chunfeng.yun,
fparent, mars.cheng, linux-arm-kernel, linux-mediatek,
devicetree, linux-kernel, AngeloGioacchino Del Regno
Update the names to regulator-usb-p{0-3}-vbus to fix unit_address_vs_reg
warnings for those.
Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for MT2712")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
index 638908773706..d31a194124c9 100644
--- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
@@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 {
id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>;
};
- usb_p0_vbus: regulator@2 {
+ usb_p0_vbus: regulator-usb-p0-vbus {
compatible = "regulator-fixed";
regulator-name = "p0_vbus";
regulator-min-microvolt = <5000000>;
@@ -59,7 +59,7 @@ usb_p0_vbus: regulator@2 {
enable-active-high;
};
- usb_p1_vbus: regulator@3 {
+ usb_p1_vbus: regulator-usb-p1-vbus {
compatible = "regulator-fixed";
regulator-name = "p1_vbus";
regulator-min-microvolt = <5000000>;
@@ -68,7 +68,7 @@ usb_p1_vbus: regulator@3 {
enable-active-high;
};
- usb_p2_vbus: regulator@4 {
+ usb_p2_vbus: regulator-usb-p2-vbus {
compatible = "regulator-fixed";
regulator-name = "p2_vbus";
regulator-min-microvolt = <5000000>;
@@ -77,7 +77,7 @@ usb_p2_vbus: regulator@4 {
enable-active-high;
};
- usb_p3_vbus: regulator@5 {
+ usb_p3_vbus: regulator-usb-p3-vbus {
compatible = "regulator-fixed";
regulator-name = "p3_vbus";
regulator-min-microvolt = <5000000>;
--
2.37.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 6/8] arm64: dts: mt2712-evb: Fix usb vbus regulators unit names
2022-10-13 15:22 ` [PATCH 6/8] arm64: dts: mt2712-evb: Fix usb vbus " AngeloGioacchino Del Regno
@ 2022-10-14 2:43 ` Chunfeng Yun
2022-10-14 7:35 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 14+ messages in thread
From: Chunfeng Yun @ 2022-10-14 2:43 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, sam.shih, hanks.chen, weiyi.lu,
zhiyong.tao, andrew-sh.cheng, viresh.kumar, fparent, mars.cheng,
linux-arm-kernel, linux-mediatek, devicetree, linux-kernel
On Thu, 2022-10-13 at 17:22 +0200, AngeloGioacchino Del Regno wrote:
> Update the names to regulator-usb-p{0-3}-vbus to fix
> unit_address_vs_reg
> warnings for those.
>
> Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for MT2712")
> Signed-off-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> index 638908773706..d31a194124c9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 {
> id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>;
> };
>
> - usb_p0_vbus: regulator@2 {
> + usb_p0_vbus: regulator-usb-p0-vbus {
Can we modify dt-binding of fixed regulator instead of changing the
node name,
since all nodes using fixed regulator may need be changed.
> compatible = "regulator-fixed";
> regulator-name = "p0_vbus";
> regulator-min-microvolt = <5000000>;
> @@ -59,7 +59,7 @@ usb_p0_vbus: regulator@2 {
> enable-active-high;
> };
>
> - usb_p1_vbus: regulator@3 {
> + usb_p1_vbus: regulator-usb-p1-vbus {
> compatible = "regulator-fixed";
> regulator-name = "p1_vbus";
> regulator-min-microvolt = <5000000>;
> @@ -68,7 +68,7 @@ usb_p1_vbus: regulator@3 {
> enable-active-high;
> };
>
> - usb_p2_vbus: regulator@4 {
> + usb_p2_vbus: regulator-usb-p2-vbus {
> compatible = "regulator-fixed";
> regulator-name = "p2_vbus";
> regulator-min-microvolt = <5000000>;
> @@ -77,7 +77,7 @@ usb_p2_vbus: regulator@4 {
> enable-active-high;
> };
>
> - usb_p3_vbus: regulator@5 {
> + usb_p3_vbus: regulator-usb-p3-vbus {
> compatible = "regulator-fixed";
> regulator-name = "p3_vbus";
> regulator-min-microvolt = <5000000>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 6/8] arm64: dts: mt2712-evb: Fix usb vbus regulators unit names
2022-10-14 2:43 ` Chunfeng Yun
@ 2022-10-14 7:35 ` AngeloGioacchino Del Regno
2022-10-21 6:25 ` Chunfeng Yun
0 siblings, 1 reply; 14+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-14 7:35 UTC (permalink / raw)
To: Chunfeng Yun, matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, sam.shih, hanks.chen, weiyi.lu,
zhiyong.tao, andrew-sh.cheng, viresh.kumar, fparent, mars.cheng,
linux-arm-kernel, linux-mediatek, devicetree, linux-kernel
Il 14/10/22 04:43, Chunfeng Yun ha scritto:
> On Thu, 2022-10-13 at 17:22 +0200, AngeloGioacchino Del Regno wrote:
>> Update the names to regulator-usb-p{0-3}-vbus to fix
>> unit_address_vs_reg
>> warnings for those.
>>
>> Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for MT2712")
>> Signed-off-by: AngeloGioacchino Del Regno <
>> angelogioacchino.delregno@collabora.com>
>> ---
>> arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
>> b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
>> index 638908773706..d31a194124c9 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
>> @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 {
>> id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>;
>> };
>>
>> - usb_p0_vbus: regulator@2 {
>> + usb_p0_vbus: regulator-usb-p0-vbus {
> Can we modify dt-binding of fixed regulator instead of changing the
> node name,
> since all nodes using fixed regulator may need be changed.
>
These regulators have no MMIO, nor need any index, so it would be simply
wrong to change the binding and leave them as they are here in the devicetree.
Regards,
Angelo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 6/8] arm64: dts: mt2712-evb: Fix usb vbus regulators unit names
2022-10-14 7:35 ` AngeloGioacchino Del Regno
@ 2022-10-21 6:25 ` Chunfeng Yun
2022-10-21 8:13 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 14+ messages in thread
From: Chunfeng Yun @ 2022-10-21 6:25 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, sam.shih, hanks.chen, weiyi.lu,
zhiyong.tao, andrew-sh.cheng, viresh.kumar, fparent, mars.cheng,
linux-arm-kernel, linux-mediatek, devicetree, linux-kernel
On Fri, 2022-10-14 at 09:35 +0200, AngeloGioacchino Del Regno wrote:
> Il 14/10/22 04:43, Chunfeng Yun ha scritto:
> > On Thu, 2022-10-13 at 17:22 +0200, AngeloGioacchino Del Regno
> > wrote:
> > > Update the names to regulator-usb-p{0-3}-vbus to fix
> > > unit_address_vs_reg
> > > warnings for those.
> > >
> > > Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for
> > > MT2712")
> > > Signed-off-by: AngeloGioacchino Del Regno <
> > > angelogioacchino.delregno@collabora.com>
> > > ---
> > > arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++----
> > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> > > b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> > > index 638908773706..d31a194124c9 100644
> > > --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> > > +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> > > @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 {
> > > id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>;
> > > };
> > >
> > > - usb_p0_vbus: regulator@2 {
> > > + usb_p0_vbus: regulator-usb-p0-vbus {
> >
> > Can we modify dt-binding of fixed regulator instead of changing the
> > node name,
> > since all nodes using fixed regulator may need be changed.
> >
>
> These regulators have no MMIO, nor need any index, so it would be
> simply
> wrong to change the binding and leave them as they are here in the
> devicetree.
You are right, then many files need be modified?
Thanks
>
> Regards,
> Angelo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 6/8] arm64: dts: mt2712-evb: Fix usb vbus regulators unit names
2022-10-21 6:25 ` Chunfeng Yun
@ 2022-10-21 8:13 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 14+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-21 8:13 UTC (permalink / raw)
To: Chunfeng Yun, matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, sam.shih, hanks.chen, weiyi.lu,
zhiyong.tao, andrew-sh.cheng, viresh.kumar, fparent, mars.cheng,
linux-arm-kernel, linux-mediatek, devicetree, linux-kernel
Il 21/10/22 08:25, Chunfeng Yun ha scritto:
> On Fri, 2022-10-14 at 09:35 +0200, AngeloGioacchino Del Regno wrote:
>> Il 14/10/22 04:43, Chunfeng Yun ha scritto:
>>> On Thu, 2022-10-13 at 17:22 +0200, AngeloGioacchino Del Regno
>>> wrote:
>>>> Update the names to regulator-usb-p{0-3}-vbus to fix
>>>> unit_address_vs_reg
>>>> warnings for those.
>>>>
>>>> Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for
>>>> MT2712")
>>>> Signed-off-by: AngeloGioacchino Del Regno <
>>>> angelogioacchino.delregno@collabora.com>
>>>> ---
>>>> arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++----
>>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
>>>> b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
>>>> index 638908773706..d31a194124c9 100644
>>>> --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
>>>> +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
>>>> @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 {
>>>> id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>;
>>>> };
>>>>
>>>> - usb_p0_vbus: regulator@2 {
>>>> + usb_p0_vbus: regulator-usb-p0-vbus {
>>>
>>> Can we modify dt-binding of fixed regulator instead of changing the
>>> node name,
>>> since all nodes using fixed regulator may need be changed.
>>>
>>
>> These regulators have no MMIO, nor need any index, so it would be
>> simply
>> wrong to change the binding and leave them as they are here in the
>> devicetree.
> You are right, then many files need be modified?
>
Yes Chunfeng, many files need to be modified due to mistakes made in the past.
No big deal though: as long as we're all aware of what needs to happen, it's fine!
Cheers,
Angelo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 7/8] arm64: dts: mediatek: pumpkin-common: Fix devicetree warnings
2022-10-13 15:22 [PATCH 0/8] ARM64 MediaTek devicetree fixes - Part 1 AngeloGioacchino Del Regno
` (5 preceding siblings ...)
2022-10-13 15:22 ` [PATCH 6/8] arm64: dts: mt2712-evb: Fix usb vbus " AngeloGioacchino Del Regno
@ 2022-10-13 15:22 ` AngeloGioacchino Del Regno
2022-10-13 15:22 ` [PATCH 8/8] arm64: dts: mediatek: mt6797: Fix 26M oscillator unit name AngeloGioacchino Del Regno
2022-11-21 12:03 ` [PATCH 0/8] ARM64 MediaTek devicetree fixes - Part 1 Matthias Brugger
8 siblings, 0 replies; 14+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-13 15:22 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, sam.shih, hanks.chen, weiyi.lu,
zhiyong.tao, andrew-sh.cheng, viresh.kumar, chunfeng.yun,
fparent, mars.cheng, linux-arm-kernel, linux-mediatek,
devicetree, linux-kernel, AngeloGioacchino Del Regno
Fix the pinctrl submodes and optee node to remove unneeded unit address,
fixing all unit_address_vs_reg warnings.
Fixes: 9983822c8cf9 ("arm64: dts: mediatek: add pumpkin board dts")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
index 8ee1529683a3..ec8dfb3d1c6d 100644
--- a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
+++ b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
@@ -17,7 +17,7 @@ chosen {
};
firmware {
- optee: optee@4fd00000 {
+ optee: optee {
compatible = "linaro,optee-tz";
method = "smc";
};
@@ -209,7 +209,7 @@ pins_cmd_dat {
};
};
- i2c0_pins_a: i2c0@0 {
+ i2c0_pins_a: i2c0 {
pins1 {
pinmux = <MT8516_PIN_58_SDA0__FUNC_SDA0_0>,
<MT8516_PIN_59_SCL0__FUNC_SCL0_0>;
@@ -217,7 +217,7 @@ pins1 {
};
};
- i2c2_pins_a: i2c2@0 {
+ i2c2_pins_a: i2c2 {
pins1 {
pinmux = <MT8516_PIN_60_SDA2__FUNC_SDA2_0>,
<MT8516_PIN_61_SCL2__FUNC_SCL2_0>;
--
2.37.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 8/8] arm64: dts: mediatek: mt6797: Fix 26M oscillator unit name
2022-10-13 15:22 [PATCH 0/8] ARM64 MediaTek devicetree fixes - Part 1 AngeloGioacchino Del Regno
` (6 preceding siblings ...)
2022-10-13 15:22 ` [PATCH 7/8] arm64: dts: mediatek: pumpkin-common: Fix devicetree warnings AngeloGioacchino Del Regno
@ 2022-10-13 15:22 ` AngeloGioacchino Del Regno
2022-11-21 12:03 ` [PATCH 0/8] ARM64 MediaTek devicetree fixes - Part 1 Matthias Brugger
8 siblings, 0 replies; 14+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-13 15:22 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, sam.shih, hanks.chen, weiyi.lu,
zhiyong.tao, andrew-sh.cheng, viresh.kumar, chunfeng.yun,
fparent, mars.cheng, linux-arm-kernel, linux-mediatek,
devicetree, linux-kernel, AngeloGioacchino Del Regno
Update its unit name to oscillator-26m and remove the unneeded unit
address to fix a unit_address_vs_reg warning.
Fixes: 464c510f60c6 ("arm64: dts: mediatek: add mt6797 support")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt6797.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt6797.dtsi b/arch/arm64/boot/dts/mediatek/mt6797.dtsi
index 15616231022a..c3677d77e0a4 100644
--- a/arch/arm64/boot/dts/mediatek/mt6797.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt6797.dtsi
@@ -95,7 +95,7 @@ cpu9: cpu@201 {
};
};
- clk26m: oscillator@0 {
+ clk26m: oscillator-26m {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <26000000>;
--
2.37.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 0/8] ARM64 MediaTek devicetree fixes - Part 1
2022-10-13 15:22 [PATCH 0/8] ARM64 MediaTek devicetree fixes - Part 1 AngeloGioacchino Del Regno
` (7 preceding siblings ...)
2022-10-13 15:22 ` [PATCH 8/8] arm64: dts: mediatek: mt6797: Fix 26M oscillator unit name AngeloGioacchino Del Regno
@ 2022-11-21 12:03 ` Matthias Brugger
8 siblings, 0 replies; 14+ messages in thread
From: Matthias Brugger @ 2022-11-21 12:03 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: robh+dt, krzysztof.kozlowski+dt, sam.shih, hanks.chen, weiyi.lu,
zhiyong.tao, andrew-sh.cheng, viresh.kumar, chunfeng.yun,
fparent, mars.cheng, linux-arm-kernel, linux-mediatek,
devicetree, linux-kernel
On 13/10/2022 17:22, AngeloGioacchino Del Regno wrote:
> This series fixes devicetree warnings for some MediaTek DTs.
>
> Since there's a lot to be done and since not all fixes are trivial,
> I decided to do this in more than one step, as to ease work for
> reviewers, maintainers and for .. me.
> This being part 1 means that there's more to come... a bit later :-)
>
> AngeloGioacchino Del Regno (8):
> arm64: dts: mt7896a: Fix unit_address_vs_reg warning for oscillator
> arm64: dts: mt6779: Fix devicetree build warnings
> arm64: dts: mt2712e: Fix unit_address_vs_reg warning for oscillators
> arm64: dts: mt2712e: Fix unit address for pinctrl node
> arm64: dts: mt2712-evb: Fix vproc fixed regulators unit names
> arm64: dts: mt2712-evb: Fix usb vbus regulators unit names
> arm64: dts: mediatek: pumpkin-common: Fix devicetree warnings
> arm64: dts: mediatek: mt6797: Fix 26M oscillator unit name
>
Whole series applied, thanks!
> arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 12 +++++-----
> arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 22 +++++++++----------
> arch/arm64/boot/dts/mediatek/mt6779.dtsi | 8 +++----
> arch/arm64/boot/dts/mediatek/mt6797.dtsi | 2 +-
> arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 2 +-
> .../boot/dts/mediatek/pumpkin-common.dtsi | 6 ++---
> 6 files changed, 26 insertions(+), 26 deletions(-)
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread