* [PATCH -next 1/2] clk: qcom: apcs-msm8916: Use dev_err_probe() helper
@ 2022-09-13 3:17 Yang Yingliang
2022-09-13 3:17 ` [PATCH -next 2/2] clk: qcom: clk-spmi-pmic-div: " Yang Yingliang
2022-10-17 21:11 ` [PATCH -next 1/2] clk: qcom: apcs-msm8916: " Stephen Boyd
0 siblings, 2 replies; 4+ messages in thread
From: Yang Yingliang @ 2022-09-13 3:17 UTC (permalink / raw)
To: linux-kernel, linux-clk, linux-arm-kernel; +Cc: agross, andersson, sboyd
dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/clk/qcom/apcs-msm8916.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/clk/qcom/apcs-msm8916.c b/drivers/clk/qcom/apcs-msm8916.c
index 89e0730810ac..233885236409 100644
--- a/drivers/clk/qcom/apcs-msm8916.c
+++ b/drivers/clk/qcom/apcs-msm8916.c
@@ -83,12 +83,9 @@ static int qcom_apcs_msm8916_clk_probe(struct platform_device *pdev)
a53cc->parent_map = gpll0_a53cc_map;
a53cc->pclk = devm_clk_get(parent, NULL);
- if (IS_ERR(a53cc->pclk)) {
- ret = PTR_ERR(a53cc->pclk);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "failed to get clk: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(a53cc->pclk))
+ return dev_err_probe(dev, PTR_ERR(a53cc->pclk),
+ "failed to get clk\n");
a53cc->clk_nb.notifier_call = a53cc_notifier_cb;
ret = clk_notifier_register(a53cc->pclk, &a53cc->clk_nb);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next 2/2] clk: qcom: clk-spmi-pmic-div: Use dev_err_probe() helper
2022-09-13 3:17 [PATCH -next 1/2] clk: qcom: apcs-msm8916: Use dev_err_probe() helper Yang Yingliang
@ 2022-09-13 3:17 ` Yang Yingliang
2022-10-17 21:11 ` Stephen Boyd
2022-10-17 21:11 ` [PATCH -next 1/2] clk: qcom: apcs-msm8916: " Stephen Boyd
1 sibling, 1 reply; 4+ messages in thread
From: Yang Yingliang @ 2022-09-13 3:17 UTC (permalink / raw)
To: linux-kernel, linux-clk, linux-arm-kernel; +Cc: agross, andersson, sboyd
dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/clk/qcom/clk-spmi-pmic-div.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/clk/qcom/clk-spmi-pmic-div.c b/drivers/clk/qcom/clk-spmi-pmic-div.c
index f2cf55cee2fd..10b8d19d0662 100644
--- a/drivers/clk/qcom/clk-spmi-pmic-div.c
+++ b/drivers/clk/qcom/clk-spmi-pmic-div.c
@@ -237,12 +237,9 @@ static int spmi_pmic_clkdiv_probe(struct platform_device *pdev)
cc->nclks = nclks;
cxo = clk_get(dev, "xo");
- if (IS_ERR(cxo)) {
- ret = PTR_ERR(cxo);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "failed to get xo clock\n");
- return ret;
- }
+ if (IS_ERR(cxo))
+ return dev_err_probe(dev, PTR_ERR(cxo),
+ "failed to get xo clock\n");
cxo_hz = clk_get_rate(cxo);
clk_put(cxo);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next 1/2] clk: qcom: apcs-msm8916: Use dev_err_probe() helper
2022-09-13 3:17 [PATCH -next 1/2] clk: qcom: apcs-msm8916: Use dev_err_probe() helper Yang Yingliang
2022-09-13 3:17 ` [PATCH -next 2/2] clk: qcom: clk-spmi-pmic-div: " Yang Yingliang
@ 2022-10-17 21:11 ` Stephen Boyd
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2022-10-17 21:11 UTC (permalink / raw)
To: Yang Yingliang, linux-arm-kernel, linux-clk, linux-kernel
Cc: agross, andersson
Quoting Yang Yingliang (2022-09-12 20:17:55)
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next 2/2] clk: qcom: clk-spmi-pmic-div: Use dev_err_probe() helper
2022-09-13 3:17 ` [PATCH -next 2/2] clk: qcom: clk-spmi-pmic-div: " Yang Yingliang
@ 2022-10-17 21:11 ` Stephen Boyd
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2022-10-17 21:11 UTC (permalink / raw)
To: Yang Yingliang, linux-arm-kernel, linux-clk, linux-kernel
Cc: agross, andersson
Quoting Yang Yingliang (2022-09-12 20:17:56)
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-17 21:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-13 3:17 [PATCH -next 1/2] clk: qcom: apcs-msm8916: Use dev_err_probe() helper Yang Yingliang
2022-09-13 3:17 ` [PATCH -next 2/2] clk: qcom: clk-spmi-pmic-div: " Yang Yingliang
2022-10-17 21:11 ` Stephen Boyd
2022-10-17 21:11 ` [PATCH -next 1/2] clk: qcom: apcs-msm8916: " Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).