* [PATCH] amba: Drop redundant assignments of the system PM callbacks
@ 2022-10-24 12:16 Ulf Hansson
2022-10-31 20:34 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Ulf Hansson @ 2022-10-24 12:16 UTC (permalink / raw)
To: Russell King, linux-arm-kernel
Cc: Saravana Kannan, Krzysztof Kozlowski, Linus Walleij,
linux-kernel, Ulf Hansson
If the system PM callbacks haven't been assigned, the PM core falls back to
invoke the corresponding the pm_generic_* helpers for the device. Let's
rely on this behaviour and drop the redundant assignments.
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
drivers/amba/bus.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
index 110a535648d2..ff7454a38058 100644
--- a/drivers/amba/bus.c
+++ b/drivers/amba/bus.c
@@ -421,12 +421,6 @@ static int amba_pm_runtime_resume(struct device *dev)
#endif /* CONFIG_PM */
static const struct dev_pm_ops amba_pm = {
- .suspend = pm_generic_suspend,
- .resume = pm_generic_resume,
- .freeze = pm_generic_freeze,
- .thaw = pm_generic_thaw,
- .poweroff = pm_generic_poweroff,
- .restore = pm_generic_restore,
SET_RUNTIME_PM_OPS(
amba_pm_runtime_suspend,
amba_pm_runtime_resume,
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] amba: Drop redundant assignments of the system PM callbacks
2022-10-24 12:16 [PATCH] amba: Drop redundant assignments of the system PM callbacks Ulf Hansson
@ 2022-10-31 20:34 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2022-10-31 20:34 UTC (permalink / raw)
To: Ulf Hansson
Cc: Russell King, linux-arm-kernel, Saravana Kannan,
Krzysztof Kozlowski, linux-kernel
On Mon, Oct 24, 2022 at 2:16 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> If the system PM callbacks haven't been assigned, the PM core falls back to
> invoke the corresponding the pm_generic_* helpers for the device. Let's
> rely on this behaviour and drop the redundant assignments.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
I think the AMBA patches normally go in through Russell's
patch tracker.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-31 20:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-24 12:16 [PATCH] amba: Drop redundant assignments of the system PM callbacks Ulf Hansson
2022-10-31 20:34 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).