* [PATCH] clk: Remove a useless include
@ 2022-11-12 21:43 Christophe JAILLET
2022-11-13 8:48 ` Heiko Stübner
2022-11-23 1:52 ` Stephen Boyd
0 siblings, 2 replies; 5+ messages in thread
From: Christophe JAILLET @ 2022-11-12 21:43 UTC (permalink / raw)
To: Luca Ceresoli, Michael Turquette, Stephen Boyd, Neil Armstrong,
Jerome Brunet, Kevin Hilman, Martin Blumenstingl, Heiko Stuebner
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-clk,
linux-amlogic, linux-arm-kernel, linux-rockchip
<linux/rational.h> is not needed for these drivers. Remove the
corresponding #include.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/clk/clk-versaclock5.c | 1 -
drivers/clk/meson/clk-pll.c | 1 -
drivers/clk/rockchip/clk.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c
index 88689415aff9..e9737969170e 100644
--- a/drivers/clk/clk-versaclock5.c
+++ b/drivers/clk/clk-versaclock5.c
@@ -20,7 +20,6 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_platform.h>
-#include <linux/rational.h>
#include <linux/regmap.h>
#include <linux/slab.h>
diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c
index 9e55617bc3b4..4b96e1590224 100644
--- a/drivers/clk/meson/clk-pll.c
+++ b/drivers/clk/meson/clk-pll.c
@@ -32,7 +32,6 @@
#include <linux/io.h>
#include <linux/math64.h>
#include <linux/module.h>
-#include <linux/rational.h>
#include "clk-regmap.h"
#include "clk-pll.h"
diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
index e63d4f20b479..398c427b8e81 100644
--- a/drivers/clk/rockchip/clk.c
+++ b/drivers/clk/rockchip/clk.c
@@ -21,7 +21,6 @@
#include <linux/mfd/syscon.h>
#include <linux/regmap.h>
#include <linux/reboot.h>
-#include <linux/rational.h>
#include "../clk-fractional-divider.h"
#include "clk.h"
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: Remove a useless include
2022-11-12 21:43 [PATCH] clk: Remove a useless include Christophe JAILLET
@ 2022-11-13 8:48 ` Heiko Stübner
2022-11-13 19:29 ` Jerome Brunet
2022-11-23 1:52 ` Stephen Boyd
1 sibling, 1 reply; 5+ messages in thread
From: Heiko Stübner @ 2022-11-13 8:48 UTC (permalink / raw)
To: Luca Ceresoli, Michael Turquette, Stephen Boyd, Neil Armstrong,
Jerome Brunet, Kevin Hilman, Martin Blumenstingl,
Christophe JAILLET
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-clk,
linux-amlogic, linux-arm-kernel, linux-rockchip
Am Samstag, 12. November 2022, 22:43:03 CET schrieb Christophe JAILLET:
> <linux/rational.h> is not needed for these drivers. Remove the
> corresponding #include.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/clk/clk-versaclock5.c | 1 -
> drivers/clk/meson/clk-pll.c | 1 -
> drivers/clk/rockchip/clk.c | 1 -
Clock-trees for soc families normally have different sub-maintainers,
so depending on how we want to merge this, you might need to split
this into 3 patches.
But at least for the Rockchip part, I'm also fine with the patch going
in as a whole, so (for the Rockchip part):
Acked-by: Heiko Stuebner <heiko@sntech.de>
Heiko
> 3 files changed, 3 deletions(-)
>
[...]
> diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
> index e63d4f20b479..398c427b8e81 100644
> --- a/drivers/clk/rockchip/clk.c
> +++ b/drivers/clk/rockchip/clk.c
> @@ -21,7 +21,6 @@
> #include <linux/mfd/syscon.h>
> #include <linux/regmap.h>
> #include <linux/reboot.h>
> -#include <linux/rational.h>
>
> #include "../clk-fractional-divider.h"
> #include "clk.h"
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: Remove a useless include
2022-11-13 8:48 ` Heiko Stübner
@ 2022-11-13 19:29 ` Jerome Brunet
2022-11-14 8:18 ` Luca Ceresoli
0 siblings, 1 reply; 5+ messages in thread
From: Jerome Brunet @ 2022-11-13 19:29 UTC (permalink / raw)
To: Heiko Stübner, Luca Ceresoli, Michael Turquette,
Stephen Boyd, Neil Armstrong, Kevin Hilman, Martin Blumenstingl,
Christophe JAILLET
Cc: linux-kernel, kernel-janitors, linux-clk, linux-amlogic,
linux-arm-kernel, linux-rockchip
On Sun 13 Nov 2022 at 09:48, Heiko Stübner <heiko@sntech.de> wrote:
> Am Samstag, 12. November 2022, 22:43:03 CET schrieb Christophe JAILLET:
>> <linux/rational.h> is not needed for these drivers. Remove the
>> corresponding #include.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>> drivers/clk/clk-versaclock5.c | 1 -
>> drivers/clk/meson/clk-pll.c | 1 -
>> drivers/clk/rockchip/clk.c | 1 -
>
> Clock-trees for soc families normally have different sub-maintainers,
> so depending on how we want to merge this, you might need to split
> this into 3 patches.
>
> But at least for the Rockchip part, I'm also fine with the patch going
> in as a whole, so (for the Rockchip part):
>
> Acked-by: Heiko Stuebner <heiko@sntech.de>
>
>
> Heiko
Same for the Amlogic part
Acked-by: Jerome Brunet <jbrunet@baylibre.com>
>
>> 3 files changed, 3 deletions(-)
>>
>
> [...]
>
>> diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
>> index e63d4f20b479..398c427b8e81 100644
>> --- a/drivers/clk/rockchip/clk.c
>> +++ b/drivers/clk/rockchip/clk.c
>> @@ -21,7 +21,6 @@
>> #include <linux/mfd/syscon.h>
>> #include <linux/regmap.h>
>> #include <linux/reboot.h>
>> -#include <linux/rational.h>
>>
>> #include "../clk-fractional-divider.h"
>> #include "clk.h"
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: Remove a useless include
2022-11-13 19:29 ` Jerome Brunet
@ 2022-11-14 8:18 ` Luca Ceresoli
0 siblings, 0 replies; 5+ messages in thread
From: Luca Ceresoli @ 2022-11-14 8:18 UTC (permalink / raw)
To: Jerome Brunet
Cc: Heiko Stübner, Michael Turquette, Stephen Boyd,
Neil Armstrong, Kevin Hilman, Martin Blumenstingl,
Christophe JAILLET, linux-kernel, kernel-janitors, linux-clk,
linux-amlogic, linux-arm-kernel, linux-rockchip
Hello Jerome,
On Sun, 13 Nov 2022 20:29:43 +0100
Jerome Brunet <jbrunet@baylibre.com> wrote:
> On Sun 13 Nov 2022 at 09:48, Heiko Stübner <heiko@sntech.de> wrote:
>
> > Am Samstag, 12. November 2022, 22:43:03 CET schrieb Christophe JAILLET:
> >> <linux/rational.h> is not needed for these drivers. Remove the
> >> corresponding #include.
> >>
> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> >> ---
> >> drivers/clk/clk-versaclock5.c | 1 -
> >> drivers/clk/meson/clk-pll.c | 1 -
> >> drivers/clk/rockchip/clk.c | 1 -
> >
> > Clock-trees for soc families normally have different sub-maintainers,
> > so depending on how we want to merge this, you might need to split
> > this into 3 patches.
> >
> > But at least for the Rockchip part, I'm also fine with the patch going
> > in as a whole, so (for the Rockchip part):
> >
> > Acked-by: Heiko Stuebner <heiko@sntech.de>
> >
> >
> > Heiko
>
> Same for the Amlogic part
>
> Acked-by: Jerome Brunet <jbrunet@baylibre.com>
And the same for Versaclock:
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: Remove a useless include
2022-11-12 21:43 [PATCH] clk: Remove a useless include Christophe JAILLET
2022-11-13 8:48 ` Heiko Stübner
@ 2022-11-23 1:52 ` Stephen Boyd
1 sibling, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2022-11-23 1:52 UTC (permalink / raw)
To: Christophe JAILLET, Heiko Stuebner, Jerome Brunet, Kevin Hilman,
Luca Ceresoli, Martin Blumenstingl, Michael Turquette,
Neil Armstrong
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-clk,
linux-amlogic, linux-arm-kernel, linux-rockchip
Quoting Christophe JAILLET (2022-11-12 13:43:03)
> <linux/rational.h> is not needed for these drivers. Remove the
> corresponding #include.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
Applied to clk-next
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-11-23 1:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-12 21:43 [PATCH] clk: Remove a useless include Christophe JAILLET
2022-11-13 8:48 ` Heiko Stübner
2022-11-13 19:29 ` Jerome Brunet
2022-11-14 8:18 ` Luca Ceresoli
2022-11-23 1:52 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).