linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: at91: sama7g5ek: align power rails for sdmmc0/1
@ 2022-11-24 15:46 Eugen Hristev
  2022-11-25 11:35 ` Claudiu.Beznea
  0 siblings, 1 reply; 2+ messages in thread
From: Eugen Hristev @ 2022-11-24 15:46 UTC (permalink / raw)
  To: robh+dt, claudiu.beznea
  Cc: devicetree, linux-arm-kernel, linux-kernel, Eugen Hristev

On this board SDMMC0 has a 1.8 signaled eMMC device powered at
3.3 V .
Hence, correctly describe the connected rails from the PMIC.

SDMMC1 is connected to a voltage switch that can change from
3.3V to 1.8V by a hardware controlled pin.
However SDMMC1 at the moment works only 3.3V mode (default speed,
no UHS-I modes), thus connect the signaling to the 3.3V rail.

Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
 arch/arm/boot/dts/at91-sama7g5ek.dts | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/at91-sama7g5ek.dts b/arch/arm/boot/dts/at91-sama7g5ek.dts
index 3b25c67795dd..aa5cc0e98bba 100644
--- a/arch/arm/boot/dts/at91-sama7g5ek.dts
+++ b/arch/arm/boot/dts/at91-sama7g5ek.dts
@@ -764,8 +764,9 @@ &rtt {
 &sdmmc0 {
 	bus-width = <8>;
 	non-removable;
-	no-1-8-v;
 	sdhci-caps-mask = <0x0 0x00200000>;
+	vmmc-supply = <&vdd_3v3>;
+	vqmmc-supply = <&vldo1>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_sdmmc0_default>;
 	status = "okay";
@@ -775,6 +776,8 @@ &sdmmc1 {
 	bus-width = <4>;
 	no-1-8-v;
 	sdhci-caps-mask = <0x0 0x00200000>;
+	vmmc-supply = <&vdd_3v3>;
+	vqmmc-supply = <&vdd_3v3>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_sdmmc1_default>;
 	status = "okay";
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: at91: sama7g5ek: align power rails for sdmmc0/1
  2022-11-24 15:46 [PATCH] ARM: dts: at91: sama7g5ek: align power rails for sdmmc0/1 Eugen Hristev
@ 2022-11-25 11:35 ` Claudiu.Beznea
  0 siblings, 0 replies; 2+ messages in thread
From: Claudiu.Beznea @ 2022-11-25 11:35 UTC (permalink / raw)
  To: Eugen.Hristev, robh+dt; +Cc: devicetree, linux-arm-kernel, linux-kernel

On 24.11.2022 17:46, Eugen Hristev wrote:
> On this board SDMMC0 has a 1.8 signaled eMMC device powered at
> 3.3 V .
> Hence, correctly describe the connected rails from the PMIC.
> 
> SDMMC1 is connected to a voltage switch that can change from
> 3.3V to 1.8V by a hardware controlled pin.
> However SDMMC1 at the moment works only 3.3V mode (default speed,
> no UHS-I modes), thus connect the signaling to the 3.3V rail.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>

Applied to at91-dt (after reshaped a bit the commit message), thanks!

> ---
>  arch/arm/boot/dts/at91-sama7g5ek.dts | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama7g5ek.dts b/arch/arm/boot/dts/at91-sama7g5ek.dts
> index 3b25c67795dd..aa5cc0e98bba 100644
> --- a/arch/arm/boot/dts/at91-sama7g5ek.dts
> +++ b/arch/arm/boot/dts/at91-sama7g5ek.dts
> @@ -764,8 +764,9 @@ &rtt {
>  &sdmmc0 {
>  	bus-width = <8>;
>  	non-removable;
> -	no-1-8-v;
>  	sdhci-caps-mask = <0x0 0x00200000>;
> +	vmmc-supply = <&vdd_3v3>;
> +	vqmmc-supply = <&vldo1>;
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_sdmmc0_default>;
>  	status = "okay";
> @@ -775,6 +776,8 @@ &sdmmc1 {
>  	bus-width = <4>;
>  	no-1-8-v;
>  	sdhci-caps-mask = <0x0 0x00200000>;
> +	vmmc-supply = <&vdd_3v3>;
> +	vqmmc-supply = <&vdd_3v3>;
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_sdmmc1_default>;
>  	status = "okay";

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-25 11:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-24 15:46 [PATCH] ARM: dts: at91: sama7g5ek: align power rails for sdmmc0/1 Eugen Hristev
2022-11-25 11:35 ` Claudiu.Beznea

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).