* [PATCH] usb: gadget: aspeed_udc: Add checks for dma_alloc_coherent()
@ 2022-11-25 9:28 Yuan Can
0 siblings, 0 replies; only message in thread
From: Yuan Can @ 2022-11-25 9:28 UTC (permalink / raw)
To: neal_liu, gregkh, joel, andrew, linux-aspeed, linux-usb,
linux-arm-kernel
Cc: yuancan
As the dma_alloc_coherent() may return NULL, the return value needs to be
checked to avoid NULL poineter dereference.
Fixes: 055276c13205 ("usb: gadget: add Aspeed ast2600 udc driver")
Signed-off-by: Yuan Can <yuancan@huawei.com>
---
drivers/usb/gadget/udc/aspeed_udc.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c
index 01968e2167f9..7dc2457c7460 100644
--- a/drivers/usb/gadget/udc/aspeed_udc.c
+++ b/drivers/usb/gadget/udc/aspeed_udc.c
@@ -1516,6 +1516,10 @@ static int ast_udc_probe(struct platform_device *pdev)
AST_UDC_EP_DMA_SIZE *
AST_UDC_NUM_ENDPOINTS,
&udc->ep0_buf_dma, GFP_KERNEL);
+ if (!udc->ep0_buf) {
+ rc = -ENOMEM;
+ goto err;
+ }
udc->gadget.speed = USB_SPEED_UNKNOWN;
udc->gadget.max_speed = USB_SPEED_HIGH;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-11-25 9:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-25 9:28 [PATCH] usb: gadget: aspeed_udc: Add checks for dma_alloc_coherent() Yuan Can
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).