* [PATCH] dmaengine: imx-sdma: Set DMA channel to be private
@ 2023-02-07 4:57 Kai-Heng Feng
2023-02-10 8:55 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Kai-Heng Feng @ 2023-02-07 4:57 UTC (permalink / raw)
To: vkoul, shawnguo, s.hauer
Cc: Kai-Heng Feng, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, dmaengine, linux-arm-kernel, linux-kernel
If async-tx is loaded before device drivers that requires imx-sdma, the
dmaengine_get() routine from async-tx grabs all non-private channels,
so devices that require DMA fail to work.
So mark imx-sdma with DMA_PRIVATE to avoid such situation.
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
drivers/dma/imx-sdma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index b926abe4fa43a..b86cdab5c2683 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -2234,6 +2234,7 @@ static int sdma_probe(struct platform_device *pdev)
dma_cap_set(DMA_SLAVE, sdma->dma_device.cap_mask);
dma_cap_set(DMA_CYCLIC, sdma->dma_device.cap_mask);
dma_cap_set(DMA_MEMCPY, sdma->dma_device.cap_mask);
+ dma_cap_set(DMA_PRIVATE, sdma->dma_device.cap_mask);
INIT_LIST_HEAD(&sdma->dma_device.channels);
/* Initialize channel parameters */
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: imx-sdma: Set DMA channel to be private
2023-02-07 4:57 [PATCH] dmaengine: imx-sdma: Set DMA channel to be private Kai-Heng Feng
@ 2023-02-10 8:55 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2023-02-10 8:55 UTC (permalink / raw)
To: Kai-Heng Feng
Cc: shawnguo, s.hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, dmaengine, linux-arm-kernel, linux-kernel
On 07-02-23, 12:57, Kai-Heng Feng wrote:
> If async-tx is loaded before device drivers that requires imx-sdma, the
> dmaengine_get() routine from async-tx grabs all non-private channels,
> so devices that require DMA fail to work.
>
> So mark imx-sdma with DMA_PRIVATE to avoid such situation.
Applied, thanks
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-10 8:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-07 4:57 [PATCH] dmaengine: imx-sdma: Set DMA channel to be private Kai-Heng Feng
2023-02-10 8:55 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).