* [PATCH] KVM: arm64: Fix non-kerneldoc comments
@ 2023-02-07 9:43 Marc Zyngier
2023-02-08 17:30 ` Oliver Upton
0 siblings, 1 reply; 2+ messages in thread
From: Marc Zyngier @ 2023-02-07 9:43 UTC (permalink / raw)
To: kvmarm, linux-arm-kernel, kvm
Cc: James Morse, Suzuki K Poulose, Oliver Upton, Zenghui Yu
The robots amongts us have started spitting out irritating emails about
random errors such as:
<quote>
arch/arm64/kvm/arm.c:2207: warning: expecting prototype for Initialize Hyp().
Prototype was for kvm_arm_init() instead
</quote>
which makes little sense until you finally grok what they are on about:
comments that look like a kerneldoc, but that aren't.
Let's address this before I get even more irritated... ;-)
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/63e139e1.J5AHO6vmxaALh7xv%25lkp@intel.com
---
arch/arm64/kvm/arm.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
index 9c5573bc4614..6b59d89811be 100644
--- a/arch/arm64/kvm/arm.c
+++ b/arch/arm64/kvm/arm.c
@@ -1909,9 +1909,7 @@ static int kvm_hyp_init_protection(u32 hyp_va_bits)
return 0;
}
-/**
- * Inits Hyp-mode on all online CPUs
- */
+/* Inits Hyp-mode on all online CPUs */
static int init_hyp_mode(void)
{
u32 hyp_va_bits;
@@ -2187,9 +2185,7 @@ void kvm_arch_irq_bypass_start(struct irq_bypass_consumer *cons)
kvm_arm_resume_guest(irqfd->kvm);
}
-/**
- * Initialize Hyp-mode and memory mappings on all CPUs.
- */
+/* Initialize Hyp-mode and memory mappings on all CPUs */
int kvm_arch_init(void *opaque)
{
int err;
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: arm64: Fix non-kerneldoc comments
2023-02-07 9:43 [PATCH] KVM: arm64: Fix non-kerneldoc comments Marc Zyngier
@ 2023-02-08 17:30 ` Oliver Upton
0 siblings, 0 replies; 2+ messages in thread
From: Oliver Upton @ 2023-02-08 17:30 UTC (permalink / raw)
To: linux-arm-kernel, Marc Zyngier, kvm, kvmarm
Cc: Oliver Upton, Suzuki K Poulose, James Morse, Zenghui Yu
On Tue, 7 Feb 2023 09:43:21 +0000, Marc Zyngier wrote:
> The robots amongts us have started spitting out irritating emails about
> random errors such as:
>
> <quote>
> arch/arm64/kvm/arm.c:2207: warning: expecting prototype for Initialize Hyp().
> Prototype was for kvm_arm_init() instead
> </quote>
>
> [...]
Applied to kvmarm/next, thanks!
[1/1] KVM: arm64: Fix non-kerneldoc comments
https://git.kernel.org/kvmarm/kvmarm/c/67d953d4d7be
--
Best,
Oliver
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-08 17:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-07 9:43 [PATCH] KVM: arm64: Fix non-kerneldoc comments Marc Zyngier
2023-02-08 17:30 ` Oliver Upton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).