* [PATCH] dt-bindings: pinctrl: Drop 'phandle' properties
@ 2023-08-19 1:09 Rob Herring
2023-08-19 8:01 ` Krzysztof Kozlowski
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Rob Herring @ 2023-08-19 1:09 UTC (permalink / raw)
To: Linus Walleij, Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Jonathan Hunter, Geert Uytterhoeven, Kunihiko Hayashi,
Masami Hiramatsu, Magnus Damm, Paul Cercueil, Jacopo Mondi,
Lad Prabhakar, Fabrizio Castro, Masahiro Yamada
Cc: linux-gpio, devicetree, linux-kernel, linux-tegra,
linux-renesas-soc, linux-arm-kernel
'phandle' properties are implicitly supported on all nodes, so it
shouldn't be listed in schemas.
dtschema had a bug where 'phandle' and other implicit properties weren't
being added under 'additionalProperties' schemas. That was fixed in
v2023.07 release.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/pinctrl/ingenic,pinctrl.yaml | 4 ----
.../devicetree/bindings/pinctrl/nvidia,tegra114-pinmux.yaml | 2 --
.../devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.yaml | 2 --
.../devicetree/bindings/pinctrl/nvidia,tegra194-pinmux.yaml | 2 --
.../devicetree/bindings/pinctrl/nvidia,tegra20-pinmux.yaml | 2 --
.../devicetree/bindings/pinctrl/nvidia,tegra210-pinmux.yaml | 2 --
.../devicetree/bindings/pinctrl/nvidia,tegra30-pinmux.yaml | 2 --
Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml | 4 ----
.../devicetree/bindings/pinctrl/renesas,rza1-ports.yaml | 4 ----
.../devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml | 4 ----
.../devicetree/bindings/pinctrl/renesas,rzn1-pinctrl.yaml | 4 ----
.../devicetree/bindings/pinctrl/renesas,rzv2m-pinctrl.yaml | 4 ----
.../bindings/pinctrl/socionext,uniphier-pinctrl.yaml | 2 --
13 files changed, 38 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml
index 35723966b70a..890961826c6f 100644
--- a/Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml
@@ -135,7 +135,6 @@ additionalProperties:
- $ref: pinmux-node.yaml#
properties:
- phandle: true
function: true
groups: true
pins: true
@@ -147,8 +146,6 @@ additionalProperties:
additionalProperties: false
- type: object
- properties:
- phandle: true
additionalProperties:
type: object
allOf:
@@ -156,7 +153,6 @@ additionalProperties:
- $ref: pinmux-node.yaml#
properties:
- phandle: true
function: true
groups: true
pins: true
diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra114-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra114-pinmux.yaml
index 065dedb3573a..1690c0ef553a 100644
--- a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra114-pinmux.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra114-pinmux.yaml
@@ -22,8 +22,6 @@ properties:
patternProperties:
"^pinmux(-[a-z0-9-_]+)?$":
type: object
- properties:
- phandle: true
# pin groups
additionalProperties:
diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.yaml
index f924652bef0d..9b7368bd3862 100644
--- a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.yaml
@@ -32,8 +32,6 @@ properties:
patternProperties:
"^pinmux(-[a-z0-9-_]+)?$":
type: object
- properties:
- phandle: true
# pin groups
additionalProperties:
diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra194-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra194-pinmux.yaml
index 60a4bdf01bf2..87b6f4f42f25 100644
--- a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra194-pinmux.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra194-pinmux.yaml
@@ -23,8 +23,6 @@ properties:
patternProperties:
"^pinmux(-[a-z0-9-_]+)?$":
type: object
- properties:
- phandle: true
# pin groups
additionalProperties:
diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra20-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra20-pinmux.yaml
index 432ea40209a8..63cd743a30e0 100644
--- a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra20-pinmux.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra20-pinmux.yaml
@@ -24,8 +24,6 @@ properties:
patternProperties:
"^pinmux(-[a-z0-9-_]+)?$":
type: object
- properties:
- phandle: true
# pin groups
additionalProperties:
diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra210-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra210-pinmux.yaml
index 28ae2e6d0cbc..e99387a6da5e 100644
--- a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra210-pinmux.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra210-pinmux.yaml
@@ -22,8 +22,6 @@ properties:
patternProperties:
"^pinmux(-[a-z0-9-_]+)?$":
type: object
- properties:
- phandle: true
# pin groups
additionalProperties:
diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra30-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra30-pinmux.yaml
index c0eda7848767..36c8f3301a8f 100644
--- a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra30-pinmux.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra30-pinmux.yaml
@@ -22,8 +22,6 @@ properties:
patternProperties:
"^pinmux(-[a-z0-9-_]+)?$":
type: object
- properties:
- phandle: true
# pin groups
additionalProperties:
diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
index 0fc3c0f52c19..181cd1676c0a 100644
--- a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
@@ -107,7 +107,6 @@ additionalProperties:
Client device subnodes use below standard properties.
properties:
- phandle: true
function: true
groups: true
pins: true
@@ -127,9 +126,6 @@ additionalProperties:
additionalProperties: false
- type: object
- properties:
- phandle: true
-
additionalProperties:
$ref: "#/additionalProperties/anyOf/0"
diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rza1-ports.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rza1-ports.yaml
index 83800fcf0ce4..2bd7d47d0fdb 100644
--- a/Documentation/devicetree/bindings/pinctrl/renesas,rza1-ports.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/renesas,rza1-ports.yaml
@@ -108,7 +108,6 @@ additionalProperties:
Integers values in "pinmux" argument list are assembled as:
((PORT * 16 + PIN) | MUX_FUNC << 16)
- phandle: true
input-enable: true
output-enable: true
@@ -118,9 +117,6 @@ additionalProperties:
additionalProperties: false
- type: object
- properties:
- phandle: true
-
additionalProperties:
$ref: "#/additionalProperties/anyOf/0"
diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
index 9ce1a07fc015..145c5442f268 100644
--- a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
@@ -83,7 +83,6 @@ additionalProperties:
Client device subnodes use below standard properties.
properties:
- phandle: true
pinmux:
description:
Values are constructed from GPIO port number, pin number, and
@@ -106,9 +105,6 @@ additionalProperties:
line-name: true
- type: object
- properties:
- phandle: true
-
additionalProperties:
$ref: "#/additionalProperties/anyOf/0"
diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzn1-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rzn1-pinctrl.yaml
index 19d4d2facfb4..816688580e33 100644
--- a/Documentation/devicetree/bindings/pinctrl/renesas,rzn1-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzn1-pinctrl.yaml
@@ -74,7 +74,6 @@ additionalProperties:
offset by 10. Additional identifiers are provided to specify the
MDIO source peripheral.
- phandle: true
bias-disable: true
bias-pull-up:
description: Pull up the pin with 50 kOhm
@@ -91,9 +90,6 @@ additionalProperties:
$ref: "#/additionalProperties/anyOf/0"
- type: object
- properties:
- phandle: true
-
additionalProperties:
$ref: "#/additionalProperties/anyOf/0"
diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzv2m-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rzv2m-pinctrl.yaml
index c87161f2954f..cb81a17bd0b1 100644
--- a/Documentation/devicetree/bindings/pinctrl/renesas,rzv2m-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzv2m-pinctrl.yaml
@@ -63,7 +63,6 @@ additionalProperties:
Client device subnodes use below standard properties.
properties:
- phandle: true
pinmux:
description:
Values are constructed from GPIO port number, pin number, and
@@ -87,9 +86,6 @@ additionalProperties:
line-name: true
- type: object
- properties:
- phandle: true
-
additionalProperties:
$ref: "#/additionalProperties/anyOf/0"
diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
index a6f34df82e90..880da721a927 100644
--- a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
@@ -32,7 +32,6 @@ additionalProperties:
- $ref: pinmux-node.yaml#
properties:
- phandle: true
function: true
groups: true
pins: true
@@ -49,7 +48,6 @@ additionalProperties:
- $ref: pinmux-node.yaml#
properties:
- phandle: true
function: true
groups: true
pins: true
--
2.40.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Drop 'phandle' properties
2023-08-19 1:09 [PATCH] dt-bindings: pinctrl: Drop 'phandle' properties Rob Herring
@ 2023-08-19 8:01 ` Krzysztof Kozlowski
2023-08-21 10:30 ` Linus Walleij
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-08-19 8:01 UTC (permalink / raw)
To: Rob Herring, Linus Walleij, Krzysztof Kozlowski, Conor Dooley,
Thierry Reding, Jonathan Hunter, Geert Uytterhoeven,
Kunihiko Hayashi, Masami Hiramatsu, Magnus Damm, Paul Cercueil,
Jacopo Mondi, Lad Prabhakar, Fabrizio Castro, Masahiro Yamada
Cc: linux-gpio, devicetree, linux-kernel, linux-tegra,
linux-renesas-soc, linux-arm-kernel
On 19/08/2023 03:09, Rob Herring wrote:
> 'phandle' properties are implicitly supported on all nodes, so it
> shouldn't be listed in schemas.
>
> dtschema had a bug where 'phandle' and other implicit properties weren't
> being added under 'additionalProperties' schemas. That was fixed in
> v2023.07 release.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Drop 'phandle' properties
2023-08-19 1:09 [PATCH] dt-bindings: pinctrl: Drop 'phandle' properties Rob Herring
2023-08-19 8:01 ` Krzysztof Kozlowski
@ 2023-08-21 10:30 ` Linus Walleij
2023-08-21 11:53 ` Geert Uytterhoeven
2023-08-22 7:28 ` Thierry Reding
3 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2023-08-21 10:30 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Jonathan Hunter, Geert Uytterhoeven, Kunihiko Hayashi,
Masami Hiramatsu, Magnus Damm, Paul Cercueil, Jacopo Mondi,
Lad Prabhakar, Fabrizio Castro, Masahiro Yamada, linux-gpio,
devicetree, linux-kernel, linux-tegra, linux-renesas-soc,
linux-arm-kernel
On Sat, Aug 19, 2023 at 3:09 AM Rob Herring <robh@kernel.org> wrote:
> 'phandle' properties are implicitly supported on all nodes, so it
> shouldn't be listed in schemas.
>
> dtschema had a bug where 'phandle' and other implicit properties weren't
> being added under 'additionalProperties' schemas. That was fixed in
> v2023.07 release.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Patch applied, thanks for fixing this!
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Drop 'phandle' properties
2023-08-19 1:09 [PATCH] dt-bindings: pinctrl: Drop 'phandle' properties Rob Herring
2023-08-19 8:01 ` Krzysztof Kozlowski
2023-08-21 10:30 ` Linus Walleij
@ 2023-08-21 11:53 ` Geert Uytterhoeven
2023-08-22 7:28 ` Thierry Reding
3 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2023-08-21 11:53 UTC (permalink / raw)
To: Rob Herring
Cc: Linus Walleij, Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Jonathan Hunter, Geert Uytterhoeven, Kunihiko Hayashi,
Masami Hiramatsu, Magnus Damm, Paul Cercueil, Jacopo Mondi,
Lad Prabhakar, Fabrizio Castro, Masahiro Yamada, linux-gpio,
devicetree, linux-kernel, linux-tegra, linux-renesas-soc,
linux-arm-kernel
On Sat, Aug 19, 2023 at 3:09 AM Rob Herring <robh@kernel.org> wrote:
> 'phandle' properties are implicitly supported on all nodes, so it
> shouldn't be listed in schemas.
>
> dtschema had a bug where 'phandle' and other implicit properties weren't
> being added under 'additionalProperties' schemas. That was fixed in
> v2023.07 release.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml | 4 ----
> .../devicetree/bindings/pinctrl/renesas,rza1-ports.yaml | 4 ----
> .../devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml | 4 ----
> .../devicetree/bindings/pinctrl/renesas,rzn1-pinctrl.yaml | 4 ----
> .../devicetree/bindings/pinctrl/renesas,rzv2m-pinctrl.yaml | 4 ----
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Drop 'phandle' properties
2023-08-19 1:09 [PATCH] dt-bindings: pinctrl: Drop 'phandle' properties Rob Herring
` (2 preceding siblings ...)
2023-08-21 11:53 ` Geert Uytterhoeven
@ 2023-08-22 7:28 ` Thierry Reding
3 siblings, 0 replies; 5+ messages in thread
From: Thierry Reding @ 2023-08-22 7:28 UTC (permalink / raw)
To: Rob Herring
Cc: Linus Walleij, Krzysztof Kozlowski, Conor Dooley,
Jonathan Hunter, Geert Uytterhoeven, Kunihiko Hayashi,
Masami Hiramatsu, Magnus Damm, Paul Cercueil, Jacopo Mondi,
Lad Prabhakar, Fabrizio Castro, Masahiro Yamada, linux-gpio,
devicetree, linux-kernel, linux-tegra, linux-renesas-soc,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1496 bytes --]
On Fri, Aug 18, 2023 at 08:09:44PM -0500, Rob Herring wrote:
> 'phandle' properties are implicitly supported on all nodes, so it
> shouldn't be listed in schemas.
>
> dtschema had a bug where 'phandle' and other implicit properties weren't
> being added under 'additionalProperties' schemas. That was fixed in
> v2023.07 release.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/pinctrl/ingenic,pinctrl.yaml | 4 ----
> .../devicetree/bindings/pinctrl/nvidia,tegra114-pinmux.yaml | 2 --
> .../devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.yaml | 2 --
> .../devicetree/bindings/pinctrl/nvidia,tegra194-pinmux.yaml | 2 --
> .../devicetree/bindings/pinctrl/nvidia,tegra20-pinmux.yaml | 2 --
> .../devicetree/bindings/pinctrl/nvidia,tegra210-pinmux.yaml | 2 --
> .../devicetree/bindings/pinctrl/nvidia,tegra30-pinmux.yaml | 2 --
> Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml | 4 ----
> .../devicetree/bindings/pinctrl/renesas,rza1-ports.yaml | 4 ----
> .../devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml | 4 ----
> .../devicetree/bindings/pinctrl/renesas,rzn1-pinctrl.yaml | 4 ----
> .../devicetree/bindings/pinctrl/renesas,rzv2m-pinctrl.yaml | 4 ----
> .../bindings/pinctrl/socionext,uniphier-pinctrl.yaml | 2 --
> 13 files changed, 38 deletions(-)
I see it's already applied, but for the record:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-22 7:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-19 1:09 [PATCH] dt-bindings: pinctrl: Drop 'phandle' properties Rob Herring
2023-08-19 8:01 ` Krzysztof Kozlowski
2023-08-21 10:30 ` Linus Walleij
2023-08-21 11:53 ` Geert Uytterhoeven
2023-08-22 7:28 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).