* [PATCH] ARM: dts: Fix User button on stm32mp135f-dk
@ 2023-01-11 10:07 Amelie Delaunay
2023-01-11 10:38 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Amelie Delaunay @ 2023-01-11 10:07 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Maxime Coquelin,
Alexandre Torgue, Fabien Dessenne
Cc: Amelie Delaunay, devicetree, linux-stm32, linux-arm-kernel, linux-kernel
This patch fixes the following dtbs_check warning on stm32mp135f-dk:
arch/arm/boot/dts/stm32mp135f-dk.dtb: gpio-keys: 'user-pa13' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/input/gpio-keys.yaml
It renames user-pa13 node into button-user so that it matches gpio-keys
bindings.
Fixes: 57012d79fefd ("ARM: dts: stm32: add UserPA13 button on stm32mp135f-dk")
Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
---
arch/arm/boot/dts/stm32mp135f-dk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/stm32mp135f-dk.dts b/arch/arm/boot/dts/stm32mp135f-dk.dts
index 9ff5a3eaf55b..931877d6ddb9 100644
--- a/arch/arm/boot/dts/stm32mp135f-dk.dts
+++ b/arch/arm/boot/dts/stm32mp135f-dk.dts
@@ -40,7 +40,7 @@ optee@dd000000 {
gpio-keys {
compatible = "gpio-keys";
- user-pa13 {
+ button-user {
label = "User-PA13";
linux,code = <BTN_1>;
gpios = <&gpioa 13 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: Fix User button on stm32mp135f-dk
2023-01-11 10:07 [PATCH] ARM: dts: Fix User button on stm32mp135f-dk Amelie Delaunay
@ 2023-01-11 10:38 ` Krzysztof Kozlowski
2023-01-16 11:59 ` Amelie Delaunay
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-11 10:38 UTC (permalink / raw)
To: Amelie Delaunay, Rob Herring, Krzysztof Kozlowski,
Maxime Coquelin, Alexandre Torgue, Fabien Dessenne
Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel
On 11/01/2023 11:07, Amelie Delaunay wrote:
> This patch fixes the following dtbs_check warning on stm32mp135f-dk:
> arch/arm/boot/dts/stm32mp135f-dk.dtb: gpio-keys: 'user-pa13' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
> From schema: Documentation/devicetree/bindings/input/gpio-keys.yaml
>
> It renames user-pa13 node into button-user so that it matches gpio-keys
> bindings.
>
> Fixes: 57012d79fefd ("ARM: dts: stm32: add UserPA13 button on stm32mp135f-dk")
>
No blank lines between the tags, but I would drop the Fixes anyway. This
is not a bug, but convention and coding style.
> Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
> ---
> arch/arm/boot/dts/stm32mp135f-dk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp135f-dk.dts b/arch/arm/boot/dts/stm32mp135f-dk.dts
> index 9ff5a3eaf55b..931877d6ddb9 100644
> --- a/arch/arm/boot/dts/stm32mp135f-dk.dts
> +++ b/arch/arm/boot/dts/stm32mp135f-dk.dts
> @@ -40,7 +40,7 @@ optee@dd000000 {
> gpio-keys {
> compatible = "gpio-keys";
>
> - user-pa13 {
> + button-user {
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: Fix User button on stm32mp135f-dk
2023-01-11 10:38 ` Krzysztof Kozlowski
@ 2023-01-16 11:59 ` Amelie Delaunay
0 siblings, 0 replies; 3+ messages in thread
From: Amelie Delaunay @ 2023-01-16 11:59 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Maxime Coquelin, Alexandre Torgue, Fabien Dessenne
Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel
On 1/11/23 11:38, Krzysztof Kozlowski wrote:
> On 11/01/2023 11:07, Amelie Delaunay wrote:
>> This patch fixes the following dtbs_check warning on stm32mp135f-dk:
>> arch/arm/boot/dts/stm32mp135f-dk.dtb: gpio-keys: 'user-pa13' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
>> From schema: Documentation/devicetree/bindings/input/gpio-keys.yaml
>>
>> It renames user-pa13 node into button-user so that it matches gpio-keys
>> bindings.
>>
>> Fixes: 57012d79fefd ("ARM: dts: stm32: add UserPA13 button on stm32mp135f-dk")
>>
>
> No blank lines between the tags, but I would drop the Fixes anyway. This
> is not a bug, but convention and coding style.
>
Blank line + Fixes tag dropped in v2. Thanks
>> Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
>> ---
>> arch/arm/boot/dts/stm32mp135f-dk.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/stm32mp135f-dk.dts b/arch/arm/boot/dts/stm32mp135f-dk.dts
>> index 9ff5a3eaf55b..931877d6ddb9 100644
>> --- a/arch/arm/boot/dts/stm32mp135f-dk.dts
>> +++ b/arch/arm/boot/dts/stm32mp135f-dk.dts
>> @@ -40,7 +40,7 @@ optee@dd000000 {
>> gpio-keys {
>> compatible = "gpio-keys";
>>
>> - user-pa13 {
>> + button-user {
>
> Best regards,
> Krzysztof
>
Regards,
Amelie
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-16 12:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-11 10:07 [PATCH] ARM: dts: Fix User button on stm32mp135f-dk Amelie Delaunay
2023-01-11 10:38 ` Krzysztof Kozlowski
2023-01-16 11:59 ` Amelie Delaunay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).