linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: arm: bcm: bcm4908: fix yaml validation
@ 2020-11-25 11:01 Rafał Miłecki
  2020-11-25 17:20 ` Florian Fainelli
  0 siblings, 1 reply; 2+ messages in thread
From: Rafał Miłecki @ 2020-11-25 11:01 UTC (permalink / raw)
  To: Florian Fainelli
  Cc: devicetree, Catalin Marinas, Rob Herring,
	bcm-kernel-feedback-list, Rafał Miłecki, Will Deacon,
	linux-arm-kernel

From: Rafał Miłecki <rafal@milecki.pl>

Root node can obviously have various subnodes so "additionalProperties"
should be set to true.

This fixes:
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dt.yaml: /: '#address-cells', '#size-cells', 'aliases', 'axi@81000000', 'chosen', 'clocks', 'cpus', 'gpio-keys-polled', 'interrupt-parent', 'memory@0', 'model', 'pmu', 'soc', 'timer', 'ubus@ff800000' do not match any of the regexes: 'pinctrl-[0-9]+'
        From schema: Documentation/devicetree/bindings/arm/bcm/brcm,bcm4908.yaml

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
Sorry Florian for that. I've just learnt dtbs_check.
---
 Documentation/devicetree/bindings/arm/bcm/brcm,bcm4908.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4908.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4908.yaml
index dfe1c1c6bb8c..5fec063d9a13 100644
--- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4908.yaml
+++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4908.yaml
@@ -33,6 +33,6 @@ properties:
           - const: brcm,bcm49408
           - const: brcm,bcm4908
 
-additionalProperties: false
+additionalProperties: true
 
 ...
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: arm: bcm: bcm4908: fix yaml validation
  2020-11-25 11:01 [PATCH] dt-bindings: arm: bcm: bcm4908: fix yaml validation Rafał Miłecki
@ 2020-11-25 17:20 ` Florian Fainelli
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2020-11-25 17:20 UTC (permalink / raw)
  To: Rafał Miłecki, Florian Fainelli
  Cc: devicetree, Catalin Marinas, Rob Herring,
	bcm-kernel-feedback-list, Rafał Miłecki, Will Deacon,
	linux-arm-kernel



On 11/25/2020 3:01 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Root node can obviously have various subnodes so "additionalProperties"
> should be set to true.
> 
> This fixes:
> arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dt.yaml: /: '#address-cells', '#size-cells', 'aliases', 'axi@81000000', 'chosen', 'clocks', 'cpus', 'gpio-keys-polled', 'interrupt-parent', 'memory@0', 'model', 'pmu', 'soc', 'timer', 'ubus@ff800000' do not match any of the regexes: 'pinctrl-[0-9]+'
>         From schema: Documentation/devicetree/bindings/arm/bcm/brcm,bcm4908.yaml
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Applied and fixed up into "dt-bindings: arm: bcm: document BCM4908
bindings", thanks for the quick turn around!
-- 
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-25 17:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-25 11:01 [PATCH] dt-bindings: arm: bcm: bcm4908: fix yaml validation Rafał Miłecki
2020-11-25 17:20 ` Florian Fainelli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).