From: "Heiko Stübner" <heiko@sntech.de>
To: Doug Anderson <dianders@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Matthias Kaehlcke <mka@chromium.org>,
Yakir Yang <ykk@rock-chips.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 04/10] ARM: dts: rockchip: add startup delay to rk3288-veyron panel-regulators
Date: Thu, 20 Jun 2019 14:28:14 +0200 [thread overview]
Message-ID: <2226970.BAPq4liE1j@diego> (raw)
In-Reply-To: <CAD=FV=U23+5pcze=6zDTx0dAYF8HTmbR8s8zem93VhgYgaZeGQ@mail.gmail.com>
Hi Doug,
Am Donnerstag, 20. Juni 2019, 03:27:55 CEST schrieb Doug Anderson:
> On Wed, Fri, 18 Mar 2016 Heiko Stuebner <heiko@sntech.de> wrote:
> >
> > The panels need a bit of time to actually turn on. If this isn't
> > observed, this results in problems when trying talk to the panels
> > and thus produces detection errors. 100ms seem to be a safe value
> > for the time being.
> >
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> > arch/arm/boot/dts/rk3288-veyron-jaq.dts | 1 +
> > arch/arm/boot/dts/rk3288-veyron-jerry.dts | 1 +
> > arch/arm/boot/dts/rk3288-veyron-minnie.dts | 1 +
> > arch/arm/boot/dts/rk3288-veyron-speedy.dts | 1 +
> > 4 files changed, 4 insertions(+)
>
> I know it was 3 years ago, but any idea how to reproduce the problems
> you were seeing without this patch? I believe the downstream kernel
> never had any delay like this and I'm not aware of any issues.
>
> I wonder if the need for this extra 100 ms delay is no longer there
> now that we have:
>
> 3157694d8c7f pwm-backlight: Add support for PWM delays proprieties.
> 5fb5caee92ba pwm-backlight: Enable/disable the PWM before/after LCD
> enable toggle.
> 6d5922dd0d60 ARM: dts: rockchip: set PWM delay backlight settings for Veyron
I just did a non-scientific test on my jerry+minnie and yes, simply
reverting that patch does not seem to affect display bringup and I still
get a prompt.
So I guess we could just revert that patch in light of the changes.
[patches welcome ;-) ]
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-20 12:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 1:39 [PATCH 00/10] ARM: dts: rockchip: enable edp functionality Heiko Stuebner
2016-03-18 1:39 ` [PATCH 01/10] ARM: dts: rockchip: add rk3288 edp-phy node Heiko Stuebner
2016-03-18 1:39 ` [PATCH 02/10] ARM: dts: rockchip: add rk3288 displayport controller node Heiko Stuebner
2016-03-18 1:39 ` [PATCH 03/10] ARM: dts: rockchip: move edp-hpd pin definition into common location Heiko Stuebner
2016-03-18 1:40 ` [PATCH 04/10] ARM: dts: rockchip: add startup delay to rk3288-veyron panel-regulators Heiko Stuebner
2019-06-20 1:27 ` Doug Anderson
2019-06-20 12:28 ` Heiko Stübner [this message]
2016-03-18 1:40 ` [PATCH 05/10] ARM: dts: rockchip: add core rk3288-veyron backlight and panel nodes Heiko Stuebner
2016-03-18 1:40 ` [PATCH 06/10] ARM: dts: rockchip: add rk3288-veyron-jaq backlight and panel overrides Heiko Stuebner
2016-03-18 1:40 ` [PATCH 07/10] ARM: dts: rockchip: add rk3288-veyron-minnie backlight and panel settings Heiko Stuebner
2016-03-18 1:40 ` [PATCH 08/10] ARM: dts: rockchip: override edp hpd handling on veyron-pinky and speedy Heiko Stuebner
2016-03-18 1:40 ` [PATCH 09/10] ARM: dts: rockchip: simple panel and backlight supplies on veyron boards Heiko Stuebner
2016-03-18 1:40 ` [PATCH 10/10] ARM: dts: rockchip: enable the eDP on rk3288 veyron devices Heiko Stuebner
2016-03-18 2:08 ` [PATCH 00/10] ARM: dts: rockchip: enable edp functionality Yakir Yang
2016-03-18 22:40 ` Doug Anderson
2016-04-06 23:28 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2226970.BAPq4liE1j@diego \
--to=heiko@sntech.de \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mka@chromium.org \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).