* [PATCH] ARM: dts: rockchip: Remove bogus 'i2s_clk_out' from rk3288-veyron-mickey
@ 2019-05-03 23:48 Douglas Anderson
2019-05-03 23:58 ` Matthias Kaehlcke
2019-05-07 12:01 ` Heiko Stuebner
0 siblings, 2 replies; 3+ messages in thread
From: Douglas Anderson @ 2019-05-03 23:48 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Mark Rutland, devicetree, amstan, briannorris, Douglas Anderson,
Rob Herring, linux-kernel, linux-rockchip, mka, linux-arm-kernel
The rk3288-veyron-mickey device tree overrides the default "i2s" clock
settings to add the clock for "i2s_clk_out".
That clock is only present in the bindings downstream Chrome OS 3.14
tree. Upstream the i2s port bindings doesn't specify that as a
possible clock.
Let's remove it.
NOTE: for other rk3288-veyron devices this clock is consumed by
'maxim,max98090'. Presumably if this clock is needed for mickey it'll
need to be consumed by something similar.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm/boot/dts/rk3288-veyron-mickey.dts | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/boot/dts/rk3288-veyron-mickey.dts b/arch/arm/boot/dts/rk3288-veyron-mickey.dts
index e852594417b5..f9c4ece3c0d3 100644
--- a/arch/arm/boot/dts/rk3288-veyron-mickey.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-mickey.dts
@@ -142,8 +142,6 @@
&i2s {
status = "okay";
- clock-names = "i2s_hclk", "i2s_clk", "i2s_clk_out";
- clocks = <&cru HCLK_I2S0>, <&cru SCLK_I2S0>, <&cru SCLK_I2S0_OUT>;
};
&rk808 {
--
2.21.0.1020.gf2820cf01a-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: Remove bogus 'i2s_clk_out' from rk3288-veyron-mickey
2019-05-03 23:48 [PATCH] ARM: dts: rockchip: Remove bogus 'i2s_clk_out' from rk3288-veyron-mickey Douglas Anderson
@ 2019-05-03 23:58 ` Matthias Kaehlcke
2019-05-07 12:01 ` Heiko Stuebner
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Kaehlcke @ 2019-05-03 23:58 UTC (permalink / raw)
To: Douglas Anderson
Cc: Mark Rutland, devicetree, Heiko Stuebner, briannorris,
linux-kernel, linux-rockchip, Rob Herring, linux-arm-kernel,
amstan
On Fri, May 03, 2019 at 04:48:14PM -0700, Douglas Anderson wrote:
> The rk3288-veyron-mickey device tree overrides the default "i2s" clock
> settings to add the clock for "i2s_clk_out".
>
> That clock is only present in the bindings downstream Chrome OS 3.14
> tree. Upstream the i2s port bindings doesn't specify that as a
> possible clock.
>
> Let's remove it.
>
> NOTE: for other rk3288-veyron devices this clock is consumed by
> 'maxim,max98090'. Presumably if this clock is needed for mickey it'll
> need to be consumed by something similar.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> arch/arm/boot/dts/rk3288-veyron-mickey.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron-mickey.dts b/arch/arm/boot/dts/rk3288-veyron-mickey.dts
> index e852594417b5..f9c4ece3c0d3 100644
> --- a/arch/arm/boot/dts/rk3288-veyron-mickey.dts
> +++ b/arch/arm/boot/dts/rk3288-veyron-mickey.dts
> @@ -142,8 +142,6 @@
>
> &i2s {
> status = "okay";
> - clock-names = "i2s_hclk", "i2s_clk", "i2s_clk_out";
> - clocks = <&cru HCLK_I2S0>, <&cru SCLK_I2S0>, <&cru SCLK_I2S0_OUT>;
> };
>
> &rk808 {
effectively, 'i2s_clk_out' is not use in the upstream kernel.
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: Remove bogus 'i2s_clk_out' from rk3288-veyron-mickey
2019-05-03 23:48 [PATCH] ARM: dts: rockchip: Remove bogus 'i2s_clk_out' from rk3288-veyron-mickey Douglas Anderson
2019-05-03 23:58 ` Matthias Kaehlcke
@ 2019-05-07 12:01 ` Heiko Stuebner
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2019-05-07 12:01 UTC (permalink / raw)
To: Douglas Anderson
Cc: Mark Rutland, devicetree, amstan, briannorris, linux-kernel,
Rob Herring, linux-rockchip, mka, linux-arm-kernel
Am Samstag, 4. Mai 2019, 01:48:14 CEST schrieb Douglas Anderson:
> The rk3288-veyron-mickey device tree overrides the default "i2s" clock
> settings to add the clock for "i2s_clk_out".
>
> That clock is only present in the bindings downstream Chrome OS 3.14
> tree. Upstream the i2s port bindings doesn't specify that as a
> possible clock.
>
> Let's remove it.
>
> NOTE: for other rk3288-veyron devices this clock is consumed by
> 'maxim,max98090'. Presumably if this clock is needed for mickey it'll
> need to be consumed by something similar.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
applied for 5.3 with Matthias' rb.
Thanks
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-07 12:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-03 23:48 [PATCH] ARM: dts: rockchip: Remove bogus 'i2s_clk_out' from rk3288-veyron-mickey Douglas Anderson
2019-05-03 23:58 ` Matthias Kaehlcke
2019-05-07 12:01 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).