* [PATCH] hwrng: iproc-rng200 - Use devm_platform_ioremap_resource() in iproc_rng200_probe()
@ 2019-09-18 7:19 Markus Elfring
2019-09-18 16:37 ` Ray Jui
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Markus Elfring @ 2019-09-18 7:19 UTC (permalink / raw)
To: linux-crypto, linux-arm-kernel, bcm-kernel-feedback-list,
Arnd Bergmann, Florian Fainelli, Greg Kroah-Hartman, Herbert Xu,
Matt Mackall, Ray Jui, Scott Branden
Cc: Bartosz Golaszewski, kernel-janitors, LKML, Himanshu Jha
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 18 Sep 2019 09:09:22 +0200
Simplify this function implementation by using a known wrapper function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/char/hw_random/iproc-rng200.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/char/hw_random/iproc-rng200.c b/drivers/char/hw_random/iproc-rng200.c
index 92be1c0ab99f..899ff25f4f28 100644
--- a/drivers/char/hw_random/iproc-rng200.c
+++ b/drivers/char/hw_random/iproc-rng200.c
@@ -181,7 +181,6 @@ static void iproc_rng200_cleanup(struct hwrng *rng)
static int iproc_rng200_probe(struct platform_device *pdev)
{
struct iproc_rng200_dev *priv;
- struct resource *res;
struct device *dev = &pdev->dev;
int ret;
@@ -190,13 +189,7 @@ static int iproc_rng200_probe(struct platform_device *pdev)
return -ENOMEM;
/* Map peripheral */
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res) {
- dev_err(dev, "failed to get rng resources\n");
- return -EINVAL;
- }
-
- priv->base = devm_ioremap_resource(dev, res);
+ priv->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(priv->base)) {
dev_err(dev, "failed to remap rng regs\n");
return PTR_ERR(priv->base);
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] hwrng: iproc-rng200 - Use devm_platform_ioremap_resource() in iproc_rng200_probe()
2019-09-18 7:19 [PATCH] hwrng: iproc-rng200 - Use devm_platform_ioremap_resource() in iproc_rng200_probe() Markus Elfring
@ 2019-09-18 16:37 ` Ray Jui
2019-09-18 17:13 ` Florian Fainelli
2019-10-04 15:42 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Ray Jui @ 2019-09-18 16:37 UTC (permalink / raw)
To: Markus Elfring, linux-crypto, linux-arm-kernel,
bcm-kernel-feedback-list, Arnd Bergmann, Florian Fainelli,
Greg Kroah-Hartman, Herbert Xu, Matt Mackall, Ray Jui,
Scott Branden
Cc: Bartosz Golaszewski, kernel-janitors, LKML, Himanshu Jha
On 9/18/19 12:19 AM, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 18 Sep 2019 09:09:22 +0200
>
> Simplify this function implementation by using a known wrapper function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/char/hw_random/iproc-rng200.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/char/hw_random/iproc-rng200.c b/drivers/char/hw_random/iproc-rng200.c
> index 92be1c0ab99f..899ff25f4f28 100644
> --- a/drivers/char/hw_random/iproc-rng200.c
> +++ b/drivers/char/hw_random/iproc-rng200.c
> @@ -181,7 +181,6 @@ static void iproc_rng200_cleanup(struct hwrng *rng)
> static int iproc_rng200_probe(struct platform_device *pdev)
> {
> struct iproc_rng200_dev *priv;
> - struct resource *res;
> struct device *dev = &pdev->dev;
> int ret;
>
> @@ -190,13 +189,7 @@ static int iproc_rng200_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> /* Map peripheral */
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(dev, "failed to get rng resources\n");
> - return -EINVAL;
> - }
> -
> - priv->base = devm_ioremap_resource(dev, res);
> + priv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->base)) {
> dev_err(dev, "failed to remap rng regs\n");
> return PTR_ERR(priv->base);
> --
> 2.23.0
>
Change looks good to me, thanks!
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] hwrng: iproc-rng200 - Use devm_platform_ioremap_resource() in iproc_rng200_probe()
2019-09-18 7:19 [PATCH] hwrng: iproc-rng200 - Use devm_platform_ioremap_resource() in iproc_rng200_probe() Markus Elfring
2019-09-18 16:37 ` Ray Jui
@ 2019-09-18 17:13 ` Florian Fainelli
2019-10-04 15:42 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2019-09-18 17:13 UTC (permalink / raw)
To: Markus Elfring, linux-crypto, linux-arm-kernel,
bcm-kernel-feedback-list, Arnd Bergmann, Greg Kroah-Hartman,
Herbert Xu, Matt Mackall, Ray Jui, Scott Branden
Cc: Bartosz Golaszewski, kernel-janitors, LKML, Himanshu Jha
On 9/18/19 12:19 AM, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 18 Sep 2019 09:09:22 +0200
>
> Simplify this function implementation by using a known wrapper function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hwrng: iproc-rng200 - Use devm_platform_ioremap_resource() in iproc_rng200_probe()
2019-09-18 7:19 [PATCH] hwrng: iproc-rng200 - Use devm_platform_ioremap_resource() in iproc_rng200_probe() Markus Elfring
2019-09-18 16:37 ` Ray Jui
2019-09-18 17:13 ` Florian Fainelli
@ 2019-10-04 15:42 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2019-10-04 15:42 UTC (permalink / raw)
To: Markus Elfring
Cc: Florian Fainelli, Scott Branden, Arnd Bergmann,
Greg Kroah-Hartman, kernel-janitors, LKML, Ray Jui,
Bartosz Golaszewski, bcm-kernel-feedback-list, linux-crypto,
Matt Mackall, linux-arm-kernel, Himanshu Jha
On Wed, Sep 18, 2019 at 09:19:18AM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 18 Sep 2019 09:09:22 +0200
>
> Simplify this function implementation by using a known wrapper function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/char/hw_random/iproc-rng200.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-04 15:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-18 7:19 [PATCH] hwrng: iproc-rng200 - Use devm_platform_ioremap_resource() in iproc_rng200_probe() Markus Elfring
2019-09-18 16:37 ` Ray Jui
2019-09-18 17:13 ` Florian Fainelli
2019-10-04 15:42 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).