* [PATCH 03/12] drm/exynos: Don't set allow_fb_modifiers explicitly [not found] <20210413094904.3736372-1-daniel.vetter@ffwll.ch> @ 2021-04-13 9:48 ` Daniel Vetter 2021-04-20 6:31 ` Inki Dae 2021-04-13 9:48 ` [PATCH 05/12] drm/imx: " Daniel Vetter 2021-04-13 9:49 ` [PATCH 09/12] drm/stm: " Daniel Vetter 2 siblings, 1 reply; 11+ messages in thread From: Daniel Vetter @ 2021-04-13 9:48 UTC (permalink / raw) To: DRI Development Cc: Intel Graphics Development, Daniel Vetter, Daniel Vetter, Inki Dae, Joonyoung Shim, Seung-Woo Kim, Kyungmin Park, Krzysztof Kozlowski, linux-arm-kernel, linux-samsung-soc Since commit 890880ddfdbe256083170866e49c87618b706ac7 Author: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Date: Fri Jan 4 09:56:10 2019 +0100 drm: Auto-set allow_fb_modifiers when given modifiers at plane init this is done automatically as part of plane init, if drivers set the modifier list correctly. Which is the case here. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Inki Dae <inki.dae@samsung.com> Cc: Joonyoung Shim <jy0922.shim@samsung.com> Cc: Seung-Woo Kim <sw0312.kim@samsung.com> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org --- drivers/gpu/drm/exynos/exynos_drm_fb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c index 64370b634cca..79fa3649185c 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c @@ -177,7 +177,5 @@ void exynos_drm_mode_config_init(struct drm_device *dev) dev->mode_config.funcs = &exynos_drm_mode_config_funcs; dev->mode_config.helper_private = &exynos_drm_mode_config_helpers; - dev->mode_config.allow_fb_modifiers = true; - dev->mode_config.normalize_zpos = true; } -- 2.31.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 03/12] drm/exynos: Don't set allow_fb_modifiers explicitly 2021-04-13 9:48 ` [PATCH 03/12] drm/exynos: Don't set allow_fb_modifiers explicitly Daniel Vetter @ 2021-04-20 6:31 ` Inki Dae 2021-04-20 8:41 ` Daniel Vetter 0 siblings, 1 reply; 11+ messages in thread From: Inki Dae @ 2021-04-20 6:31 UTC (permalink / raw) To: Daniel Vetter, DRI Development Cc: Intel Graphics Development, Daniel Vetter, Joonyoung Shim, Seung-Woo Kim, Kyungmin Park, Krzysztof Kozlowski, linux-arm-kernel, linux-samsung-soc 21. 4. 13. 오후 6:48에 Daniel Vetter 이(가) 쓴 글: > Since > > commit 890880ddfdbe256083170866e49c87618b706ac7 > Author: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > Date: Fri Jan 4 09:56:10 2019 +0100 > > drm: Auto-set allow_fb_modifiers when given modifiers at plane init > > this is done automatically as part of plane init, if drivers set the > modifier list correctly. Which is the case here. > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Acked-by: Inki Dae <inki.dae@samsung.com> Thanks, Inki Dae > Cc: Inki Dae <inki.dae@samsung.com> > Cc: Joonyoung Shim <jy0922.shim@samsung.com> > Cc: Seung-Woo Kim <sw0312.kim@samsung.com> > Cc: Kyungmin Park <kyungmin.park@samsung.com> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > --- > drivers/gpu/drm/exynos/exynos_drm_fb.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c > index 64370b634cca..79fa3649185c 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c > @@ -177,7 +177,5 @@ void exynos_drm_mode_config_init(struct drm_device *dev) > dev->mode_config.funcs = &exynos_drm_mode_config_funcs; > dev->mode_config.helper_private = &exynos_drm_mode_config_helpers; > > - dev->mode_config.allow_fb_modifiers = true; > - > dev->mode_config.normalize_zpos = true; > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 03/12] drm/exynos: Don't set allow_fb_modifiers explicitly 2021-04-20 6:31 ` Inki Dae @ 2021-04-20 8:41 ` Daniel Vetter 0 siblings, 0 replies; 11+ messages in thread From: Daniel Vetter @ 2021-04-20 8:41 UTC (permalink / raw) To: Inki Dae Cc: Daniel Vetter, DRI Development, Intel Graphics Development, Daniel Vetter, Joonyoung Shim, Seung-Woo Kim, Kyungmin Park, Krzysztof Kozlowski, linux-arm-kernel, linux-samsung-soc On Tue, Apr 20, 2021 at 03:31:27PM +0900, Inki Dae wrote: > > > 21. 4. 13. 오후 6:48에 Daniel Vetter 이(가) 쓴 글: > > Since > > > > commit 890880ddfdbe256083170866e49c87618b706ac7 > > Author: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > > Date: Fri Jan 4 09:56:10 2019 +0100 > > > > drm: Auto-set allow_fb_modifiers when given modifiers at plane init > > > > this is done automatically as part of plane init, if drivers set the > > modifier list correctly. Which is the case here. > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > Acked-by: Inki Dae <inki.dae@samsung.com> Thanks for taking a look, pushed to drm-misc-next. -Daniel > > Thanks, > Inki Dae > > > Cc: Inki Dae <inki.dae@samsung.com> > > Cc: Joonyoung Shim <jy0922.shim@samsung.com> > > Cc: Seung-Woo Kim <sw0312.kim@samsung.com> > > Cc: Kyungmin Park <kyungmin.park@samsung.com> > > Cc: Krzysztof Kozlowski <krzk@kernel.org> > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-samsung-soc@vger.kernel.org > > --- > > drivers/gpu/drm/exynos/exynos_drm_fb.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c > > index 64370b634cca..79fa3649185c 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c > > +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c > > @@ -177,7 +177,5 @@ void exynos_drm_mode_config_init(struct drm_device *dev) > > dev->mode_config.funcs = &exynos_drm_mode_config_funcs; > > dev->mode_config.helper_private = &exynos_drm_mode_config_helpers; > > > > - dev->mode_config.allow_fb_modifiers = true; > > - > > dev->mode_config.normalize_zpos = true; > > } > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly [not found] <20210413094904.3736372-1-daniel.vetter@ffwll.ch> 2021-04-13 9:48 ` [PATCH 03/12] drm/exynos: Don't set allow_fb_modifiers explicitly Daniel Vetter @ 2021-04-13 9:48 ` Daniel Vetter 2021-04-13 11:47 ` Lucas Stach 2021-04-13 9:49 ` [PATCH 09/12] drm/stm: " Daniel Vetter 2 siblings, 1 reply; 11+ messages in thread From: Daniel Vetter @ 2021-04-13 9:48 UTC (permalink / raw) To: DRI Development Cc: Intel Graphics Development, Daniel Vetter, Daniel Vetter, Philipp Zabel, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, linux-arm-kernel Since commit 890880ddfdbe256083170866e49c87618b706ac7 Author: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Date: Fri Jan 4 09:56:10 2019 +0100 drm: Auto-set allow_fb_modifiers when given modifiers at plane init this is done automatically as part of plane init, if drivers set the modifier list correctly. Which is the case here. This one actually set it twice on top of what drm_plane_init does, so double-redundant! Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> Cc: Fabio Estevam <festevam@gmail.com> Cc: NXP Linux Team <linux-imx@nxp.com> Cc: linux-arm-kernel@lists.infradead.org --- drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 - drivers/gpu/drm/imx/imx-drm-core.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c index b549ce5e7607..37ae68a7fba5 100644 --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c @@ -52,7 +52,6 @@ static void dcss_kms_mode_config_init(struct dcss_kms_dev *kms) config->min_height = 1; config->max_width = 4096; config->max_height = 4096; - config->allow_fb_modifiers = true; config->normalize_zpos = true; config->funcs = &dcss_drm_mode_config_funcs; diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c index 2ded8e4f32d0..8be4edaec958 100644 --- a/drivers/gpu/drm/imx/imx-drm-core.c +++ b/drivers/gpu/drm/imx/imx-drm-core.c @@ -209,7 +209,6 @@ static int imx_drm_bind(struct device *dev) drm->mode_config.max_height = 4096; drm->mode_config.funcs = &imx_drm_mode_config_funcs; drm->mode_config.helper_private = &imx_drm_mode_config_helpers; - drm->mode_config.allow_fb_modifiers = true; drm->mode_config.normalize_zpos = true; ret = drmm_mode_config_init(drm); -- 2.31.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly 2021-04-13 9:48 ` [PATCH 05/12] drm/imx: " Daniel Vetter @ 2021-04-13 11:47 ` Lucas Stach 2021-04-13 14:04 ` Daniel Vetter 2021-04-15 11:35 ` Daniel Vetter 0 siblings, 2 replies; 11+ messages in thread From: Lucas Stach @ 2021-04-13 11:47 UTC (permalink / raw) To: Daniel Vetter, DRI Development Cc: Pengutronix Kernel Team, Intel Graphics Development, NXP Linux Team, Daniel Vetter, Shawn Guo, Sascha Hauer, linux-arm-kernel Am Dienstag, dem 13.04.2021 um 11:48 +0200 schrieb Daniel Vetter: > Since > > commit 890880ddfdbe256083170866e49c87618b706ac7 > Author: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > Date: Fri Jan 4 09:56:10 2019 +0100 > > drm: Auto-set allow_fb_modifiers when given modifiers at plane init > > this is done automatically as part of plane init, if drivers set the > modifier list correctly. Which is the case here. > > This one actually set it twice on top of what drm_plane_init does, so > double-redundant! That's not true. imx-dcss and imx-drm are two totally separate drivers. Maybe we should move imx-drm into its own ipuv3 directory one day to make this more clear. Change is still correct, though. Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: NXP Linux Team <linux-imx@nxp.com> > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 - > drivers/gpu/drm/imx/imx-drm-core.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c > index b549ce5e7607..37ae68a7fba5 100644 > --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c > +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c > @@ -52,7 +52,6 @@ static void dcss_kms_mode_config_init(struct dcss_kms_dev *kms) > config->min_height = 1; > config->max_width = 4096; > config->max_height = 4096; > - config->allow_fb_modifiers = true; > config->normalize_zpos = true; > > > > > config->funcs = &dcss_drm_mode_config_funcs; > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c > index 2ded8e4f32d0..8be4edaec958 100644 > --- a/drivers/gpu/drm/imx/imx-drm-core.c > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > @@ -209,7 +209,6 @@ static int imx_drm_bind(struct device *dev) > drm->mode_config.max_height = 4096; > drm->mode_config.funcs = &imx_drm_mode_config_funcs; > drm->mode_config.helper_private = &imx_drm_mode_config_helpers; > - drm->mode_config.allow_fb_modifiers = true; > drm->mode_config.normalize_zpos = true; > > > > > ret = drmm_mode_config_init(drm); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly 2021-04-13 11:47 ` Lucas Stach @ 2021-04-13 14:04 ` Daniel Vetter 2021-04-13 14:14 ` Lucas Stach 2021-04-15 11:35 ` Daniel Vetter 1 sibling, 1 reply; 11+ messages in thread From: Daniel Vetter @ 2021-04-13 14:04 UTC (permalink / raw) To: Lucas Stach Cc: Daniel Vetter, DRI Development, Pengutronix Kernel Team, Intel Graphics Development, NXP Linux Team, Daniel Vetter, Shawn Guo, Sascha Hauer, linux-arm-kernel On Tue, Apr 13, 2021 at 01:47:28PM +0200, Lucas Stach wrote: > Am Dienstag, dem 13.04.2021 um 11:48 +0200 schrieb Daniel Vetter: > > Since > > > > commit 890880ddfdbe256083170866e49c87618b706ac7 > > Author: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > > Date: Fri Jan 4 09:56:10 2019 +0100 > > > > drm: Auto-set allow_fb_modifiers when given modifiers at plane init > > > > this is done automatically as part of plane init, if drivers set the > > modifier list correctly. Which is the case here. > > > > This one actually set it twice on top of what drm_plane_init does, so > > double-redundant! > > That's not true. imx-dcss and imx-drm are two totally separate drivers. > Maybe we should move imx-drm into its own ipuv3 directory one day to > make this more clear. Change is still correct, though. Hm I greeped for drm_universal_plane_init and didn't find anythinf for the imx main driver ... where are planes set up for that? Need to review that they have the modifiers listed in all cases. -Daniel > > Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > > Cc: Shawn Guo <shawnguo@kernel.org> > > Cc: Sascha Hauer <s.hauer@pengutronix.de> > > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > > Cc: Fabio Estevam <festevam@gmail.com> > > Cc: NXP Linux Team <linux-imx@nxp.com> > > Cc: linux-arm-kernel@lists.infradead.org > > --- > > drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 - > > drivers/gpu/drm/imx/imx-drm-core.c | 1 - > > 2 files changed, 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c > > index b549ce5e7607..37ae68a7fba5 100644 > > --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c > > +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c > > @@ -52,7 +52,6 @@ static void dcss_kms_mode_config_init(struct dcss_kms_dev *kms) > > config->min_height = 1; > > config->max_width = 4096; > > config->max_height = 4096; > > - config->allow_fb_modifiers = true; > > config->normalize_zpos = true; > > > > > > > > > > config->funcs = &dcss_drm_mode_config_funcs; > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c > > index 2ded8e4f32d0..8be4edaec958 100644 > > --- a/drivers/gpu/drm/imx/imx-drm-core.c > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > > @@ -209,7 +209,6 @@ static int imx_drm_bind(struct device *dev) > > drm->mode_config.max_height = 4096; > > drm->mode_config.funcs = &imx_drm_mode_config_funcs; > > drm->mode_config.helper_private = &imx_drm_mode_config_helpers; > > - drm->mode_config.allow_fb_modifiers = true; > > drm->mode_config.normalize_zpos = true; > > > > > > > > > > ret = drmm_mode_config_init(drm); > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly 2021-04-13 14:04 ` Daniel Vetter @ 2021-04-13 14:14 ` Lucas Stach 2021-04-14 2:24 ` Liu Ying 0 siblings, 1 reply; 11+ messages in thread From: Lucas Stach @ 2021-04-13 14:14 UTC (permalink / raw) To: Daniel Vetter Cc: Daniel Vetter, DRI Development, Pengutronix Kernel Team, Intel Graphics Development, NXP Linux Team, Daniel Vetter, Shawn Guo, Sascha Hauer, linux-arm-kernel Am Dienstag, dem 13.04.2021 um 16:04 +0200 schrieb Daniel Vetter: > On Tue, Apr 13, 2021 at 01:47:28PM +0200, Lucas Stach wrote: > > Am Dienstag, dem 13.04.2021 um 11:48 +0200 schrieb Daniel Vetter: > > > Since > > > > > > commit 890880ddfdbe256083170866e49c87618b706ac7 > > > Author: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > > > Date: Fri Jan 4 09:56:10 2019 +0100 > > > > > > drm: Auto-set allow_fb_modifiers when given modifiers at plane init > > > > > > this is done automatically as part of plane init, if drivers set the > > > modifier list correctly. Which is the case here. > > > > > > This one actually set it twice on top of what drm_plane_init does, so > > > double-redundant! > > > > That's not true. imx-dcss and imx-drm are two totally separate drivers. > > Maybe we should move imx-drm into its own ipuv3 directory one day to > > make this more clear. Change is still correct, though. > > Hm I greeped for drm_universal_plane_init and didn't find anythinf for the > imx main driver ... where are planes set up for that? Need to review that > they have the modifiers listed in all cases. That's in drivers/gpu/drm/imx/ipuv3-plane.c and modifiers are always set on plane init. Regards, Lucas > > > > > Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > > > Cc: Shawn Guo <shawnguo@kernel.org> > > > Cc: Sascha Hauer <s.hauer@pengutronix.de> > > > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > > > Cc: Fabio Estevam <festevam@gmail.com> > > > Cc: NXP Linux Team <linux-imx@nxp.com> > > > Cc: linux-arm-kernel@lists.infradead.org > > > --- > > > drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 - > > > drivers/gpu/drm/imx/imx-drm-core.c | 1 - > > > 2 files changed, 2 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c > > > index b549ce5e7607..37ae68a7fba5 100644 > > > --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c > > > +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c > > > @@ -52,7 +52,6 @@ static void dcss_kms_mode_config_init(struct dcss_kms_dev *kms) > > > config->min_height = 1; > > > config->max_width = 4096; > > > config->max_height = 4096; > > > - config->allow_fb_modifiers = true; > > > config->normalize_zpos = true; > > > > > > > > > > > > > > > config->funcs = &dcss_drm_mode_config_funcs; > > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c > > > index 2ded8e4f32d0..8be4edaec958 100644 > > > --- a/drivers/gpu/drm/imx/imx-drm-core.c > > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > > > @@ -209,7 +209,6 @@ static int imx_drm_bind(struct device *dev) > > > drm->mode_config.max_height = 4096; > > > drm->mode_config.funcs = &imx_drm_mode_config_funcs; > > > drm->mode_config.helper_private = &imx_drm_mode_config_helpers; > > > - drm->mode_config.allow_fb_modifiers = true; > > > drm->mode_config.normalize_zpos = true; > > > > > > > > > > > > > > > ret = drmm_mode_config_init(drm); > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly 2021-04-13 14:14 ` Lucas Stach @ 2021-04-14 2:24 ` Liu Ying 2021-04-14 9:10 ` Daniel Vetter 0 siblings, 1 reply; 11+ messages in thread From: Liu Ying @ 2021-04-14 2:24 UTC (permalink / raw) To: Lucas Stach, Daniel Vetter Cc: Daniel Vetter, DRI Development, Pengutronix Kernel Team, Intel Graphics Development, NXP Linux Team, Daniel Vetter, Shawn Guo, Sascha Hauer, linux-arm-kernel Hi Daniel, On Tue, 2021-04-13 at 16:14 +0200, Lucas Stach wrote: > Am Dienstag, dem 13.04.2021 um 16:04 +0200 schrieb Daniel Vetter: > > On Tue, Apr 13, 2021 at 01:47:28PM +0200, Lucas Stach wrote: > > > Am Dienstag, dem 13.04.2021 um 11:48 +0200 schrieb Daniel Vetter: > > > > Since > > > > > > > > commit 890880ddfdbe256083170866e49c87618b706ac7 > > > > Author: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > > > > Date: Fri Jan 4 09:56:10 2019 +0100 > > > > > > > > drm: Auto-set allow_fb_modifiers when given modifiers at plane init > > > > > > > > this is done automatically as part of plane init, if drivers set the > > > > modifier list correctly. Which is the case here. > > > > > > > > This one actually set it twice on top of what drm_plane_init does, so > > > > double-redundant! > > > > > > That's not true. imx-dcss and imx-drm are two totally separate drivers. > > > Maybe we should move imx-drm into its own ipuv3 directory one day to > > > make this more clear. Change is still correct, though. > > > > Hm I greeped for drm_universal_plane_init and didn't find anythinf for the > > imx main driver ... where are planes set up for that? Need to review that > > they have the modifiers listed in all cases. > > That's in drivers/gpu/drm/imx/ipuv3-plane.c and modifiers are always > set on plane init. > > Regards, > Lucas > > > > Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > > > > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > > > > Cc: Shawn Guo <shawnguo@kernel.org> > > > > Cc: Sascha Hauer <s.hauer@pengutronix.de> > > > > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > > > > Cc: Fabio Estevam <festevam@gmail.com> > > > > Cc: NXP Linux Team <linux-imx@nxp.com> > > > > Cc: linux-arm-kernel@lists.infradead.org > > > > --- > > > > drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 - > > > > drivers/gpu/drm/imx/imx-drm-core.c | 1 - Nit: Since this patch touches two totally separate drivers(imx-dcss and imx-drm), it would be good to split it into two patches. Thanks, Liu Ying > > > > 2 files changed, 2 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c > > > > index b549ce5e7607..37ae68a7fba5 100644 > > > > --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c > > > > +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c > > > > @@ -52,7 +52,6 @@ static void dcss_kms_mode_config_init(struct dcss_kms_dev *kms) > > > > config->min_height = 1; > > > > config->max_width = 4096; > > > > config->max_height = 4096; > > > > - config->allow_fb_modifiers = true; > > > > config->normalize_zpos = true; > > > > > > > > > > > > > > > > > > > > config->funcs = &dcss_drm_mode_config_funcs; > > > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c > > > > index 2ded8e4f32d0..8be4edaec958 100644 > > > > --- a/drivers/gpu/drm/imx/imx-drm-core.c > > > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > > > > @@ -209,7 +209,6 @@ static int imx_drm_bind(struct device *dev) > > > > drm->mode_config.max_height = 4096; > > > > drm->mode_config.funcs = &imx_drm_mode_config_funcs; > > > > drm->mode_config.helper_private = &imx_drm_mode_config_helpers; > > > > - drm->mode_config.allow_fb_modifiers = true; > > > > drm->mode_config.normalize_zpos = true; > > > > > > > > > > > > > > > > > > > > ret = drmm_mode_config_init(drm); > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly 2021-04-14 2:24 ` Liu Ying @ 2021-04-14 9:10 ` Daniel Vetter 0 siblings, 0 replies; 11+ messages in thread From: Daniel Vetter @ 2021-04-14 9:10 UTC (permalink / raw) To: Liu Ying Cc: Lucas Stach, Daniel Vetter, Daniel Vetter, DRI Development, Pengutronix Kernel Team, Intel Graphics Development, NXP Linux Team, Daniel Vetter, Shawn Guo, Sascha Hauer, linux-arm-kernel On Wed, Apr 14, 2021 at 10:24:22AM +0800, Liu Ying wrote: > Hi Daniel, > > On Tue, 2021-04-13 at 16:14 +0200, Lucas Stach wrote: > > Am Dienstag, dem 13.04.2021 um 16:04 +0200 schrieb Daniel Vetter: > > > On Tue, Apr 13, 2021 at 01:47:28PM +0200, Lucas Stach wrote: > > > > Am Dienstag, dem 13.04.2021 um 11:48 +0200 schrieb Daniel Vetter: > > > > > Since > > > > > > > > > > commit 890880ddfdbe256083170866e49c87618b706ac7 > > > > > Author: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > > > > > Date: Fri Jan 4 09:56:10 2019 +0100 > > > > > > > > > > drm: Auto-set allow_fb_modifiers when given modifiers at plane init > > > > > > > > > > this is done automatically as part of plane init, if drivers set the > > > > > modifier list correctly. Which is the case here. > > > > > > > > > > This one actually set it twice on top of what drm_plane_init does, so > > > > > double-redundant! > > > > > > > > That's not true. imx-dcss and imx-drm are two totally separate drivers. > > > > Maybe we should move imx-drm into its own ipuv3 directory one day to > > > > make this more clear. Change is still correct, though. > > > > > > Hm I greeped for drm_universal_plane_init and didn't find anythinf for the > > > imx main driver ... where are planes set up for that? Need to review that > > > they have the modifiers listed in all cases. > > > > That's in drivers/gpu/drm/imx/ipuv3-plane.c and modifiers are always > > set on plane init. Oh I didn't grep for the new drmm_universal_plane_alloc. Thanks for pointing this out. > > > > Regards, > > Lucas > > > > > > Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > > > > > > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > > > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > > > > > Cc: Shawn Guo <shawnguo@kernel.org> > > > > > Cc: Sascha Hauer <s.hauer@pengutronix.de> > > > > > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > > > > > Cc: Fabio Estevam <festevam@gmail.com> > > > > > Cc: NXP Linux Team <linux-imx@nxp.com> > > > > > Cc: linux-arm-kernel@lists.infradead.org > > > > > --- > > > > > drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 - > > > > > drivers/gpu/drm/imx/imx-drm-core.c | 1 - > > Nit: Since this patch touches two totally separate drivers(imx-dcss and > imx-drm), it would be good to split it into two patches. I think if you expect that, then you need to move the imx-drm driver into a subdirectory like dcss. And like e.g. drm/msm works too. As-is this is just kinda confusing for people not involved in imx. -Daniel > > Thanks, > Liu Ying > > > > > > 2 files changed, 2 deletions(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c > > > > > index b549ce5e7607..37ae68a7fba5 100644 > > > > > --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c > > > > > +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c > > > > > @@ -52,7 +52,6 @@ static void dcss_kms_mode_config_init(struct dcss_kms_dev *kms) > > > > > config->min_height = 1; > > > > > config->max_width = 4096; > > > > > config->max_height = 4096; > > > > > - config->allow_fb_modifiers = true; > > > > > config->normalize_zpos = true; > > > > > > > > > > > > > > > > > > > > > > > > > config->funcs = &dcss_drm_mode_config_funcs; > > > > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c > > > > > index 2ded8e4f32d0..8be4edaec958 100644 > > > > > --- a/drivers/gpu/drm/imx/imx-drm-core.c > > > > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > > > > > @@ -209,7 +209,6 @@ static int imx_drm_bind(struct device *dev) > > > > > drm->mode_config.max_height = 4096; > > > > > drm->mode_config.funcs = &imx_drm_mode_config_funcs; > > > > > drm->mode_config.helper_private = &imx_drm_mode_config_helpers; > > > > > - drm->mode_config.allow_fb_modifiers = true; > > > > > drm->mode_config.normalize_zpos = true; > > > > > > > > > > > > > > > > > > > > > > > > > ret = drmm_mode_config_init(drm); > > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly 2021-04-13 11:47 ` Lucas Stach 2021-04-13 14:04 ` Daniel Vetter @ 2021-04-15 11:35 ` Daniel Vetter 1 sibling, 0 replies; 11+ messages in thread From: Daniel Vetter @ 2021-04-15 11:35 UTC (permalink / raw) To: Lucas Stach Cc: Daniel Vetter, DRI Development, Pengutronix Kernel Team, Intel Graphics Development, NXP Linux Team, Daniel Vetter, Shawn Guo, Sascha Hauer, linux-arm-kernel On Tue, Apr 13, 2021 at 01:47:28PM +0200, Lucas Stach wrote: > Am Dienstag, dem 13.04.2021 um 11:48 +0200 schrieb Daniel Vetter: > > Since > > > > commit 890880ddfdbe256083170866e49c87618b706ac7 > > Author: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > > Date: Fri Jan 4 09:56:10 2019 +0100 > > > > drm: Auto-set allow_fb_modifiers when given modifiers at plane init > > > > this is done automatically as part of plane init, if drivers set the > > modifier list correctly. Which is the case here. > > > > This one actually set it twice on top of what drm_plane_init does, so > > double-redundant! > > That's not true. imx-dcss and imx-drm are two totally separate drivers. > Maybe we should move imx-drm into its own ipuv3 directory one day to > make this more clear. Change is still correct, though. I've fixed the commit message to reflect reality and merged to drm-misc-next. Thanks for taking a look. -Daniel > > Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > > Cc: Shawn Guo <shawnguo@kernel.org> > > Cc: Sascha Hauer <s.hauer@pengutronix.de> > > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > > Cc: Fabio Estevam <festevam@gmail.com> > > Cc: NXP Linux Team <linux-imx@nxp.com> > > Cc: linux-arm-kernel@lists.infradead.org > > --- > > drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 - > > drivers/gpu/drm/imx/imx-drm-core.c | 1 - > > 2 files changed, 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c > > index b549ce5e7607..37ae68a7fba5 100644 > > --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c > > +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c > > @@ -52,7 +52,6 @@ static void dcss_kms_mode_config_init(struct dcss_kms_dev *kms) > > config->min_height = 1; > > config->max_width = 4096; > > config->max_height = 4096; > > - config->allow_fb_modifiers = true; > > config->normalize_zpos = true; > > > > > > > > > > config->funcs = &dcss_drm_mode_config_funcs; > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c > > index 2ded8e4f32d0..8be4edaec958 100644 > > --- a/drivers/gpu/drm/imx/imx-drm-core.c > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > > @@ -209,7 +209,6 @@ static int imx_drm_bind(struct device *dev) > > drm->mode_config.max_height = 4096; > > drm->mode_config.funcs = &imx_drm_mode_config_funcs; > > drm->mode_config.helper_private = &imx_drm_mode_config_helpers; > > - drm->mode_config.allow_fb_modifiers = true; > > drm->mode_config.normalize_zpos = true; > > > > > > > > > > ret = drmm_mode_config_init(drm); > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 09/12] drm/stm: Don't set allow_fb_modifiers explicitly [not found] <20210413094904.3736372-1-daniel.vetter@ffwll.ch> 2021-04-13 9:48 ` [PATCH 03/12] drm/exynos: Don't set allow_fb_modifiers explicitly Daniel Vetter 2021-04-13 9:48 ` [PATCH 05/12] drm/imx: " Daniel Vetter @ 2021-04-13 9:49 ` Daniel Vetter 2 siblings, 0 replies; 11+ messages in thread From: Daniel Vetter @ 2021-04-13 9:49 UTC (permalink / raw) To: DRI Development Cc: Intel Graphics Development, Daniel Vetter, Daniel Vetter, Yannick Fertre, Philippe Cornu, Benjamin Gaignard, Maxime Coquelin, Alexandre Torgue, linux-stm32, linux-arm-kernel Since commit 890880ddfdbe256083170866e49c87618b706ac7 Author: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Date: Fri Jan 4 09:56:10 2019 +0100 drm: Auto-set allow_fb_modifiers when given modifiers at plane init this is done automatically as part of plane init, if drivers set the modifier list correctly. Which is the case here. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Yannick Fertre <yannick.fertre@foss.st.com> Cc: Philippe Cornu <philippe.cornu@foss.st.com> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-arm-kernel@lists.infradead.org --- drivers/gpu/drm/stm/ltdc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index 65c3c79ad1d5..e99771b947b6 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b/drivers/gpu/drm/stm/ltdc.c @@ -1326,8 +1326,6 @@ int ltdc_load(struct drm_device *ddev) goto err; } - ddev->mode_config.allow_fb_modifiers = true; - ret = ltdc_crtc_init(ddev, crtc); if (ret) { DRM_ERROR("Failed to init crtc\n"); -- 2.31.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-04-20 8:43 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210413094904.3736372-1-daniel.vetter@ffwll.ch>
2021-04-13 9:48 ` [PATCH 03/12] drm/exynos: Don't set allow_fb_modifiers explicitly Daniel Vetter
2021-04-20 6:31 ` Inki Dae
2021-04-20 8:41 ` Daniel Vetter
2021-04-13 9:48 ` [PATCH 05/12] drm/imx: " Daniel Vetter
2021-04-13 11:47 ` Lucas Stach
2021-04-13 14:04 ` Daniel Vetter
2021-04-13 14:14 ` Lucas Stach
2021-04-14 2:24 ` Liu Ying
2021-04-14 9:10 ` Daniel Vetter
2021-04-15 11:35 ` Daniel Vetter
2021-04-13 9:49 ` [PATCH 09/12] drm/stm: " Daniel Vetter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).