* [PATCH 1/1] drm/mediatek: Remove redundant error printing in mtk_cec_probe()
@ 2021-05-11 11:32 Zhen Lei
2021-05-11 13:13 ` Baruch Siach
0 siblings, 1 reply; 3+ messages in thread
From: Zhen Lei @ 2021-05-11 11:32 UTC (permalink / raw)
To: Chun-Kuang Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, dri-devel, linux-mediatek, linux-arm-kernel
Cc: Zhen Lei
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.
Therefore, remove the error printing here to simplify code and reduce the
binary size.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/gpu/drm/mediatek/mtk_cec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_cec.c b/drivers/gpu/drm/mediatek/mtk_cec.c
index e9cef5c0c8f7eff..fd593ff99bfd447 100644
--- a/drivers/gpu/drm/mediatek/mtk_cec.c
+++ b/drivers/gpu/drm/mediatek/mtk_cec.c
@@ -197,7 +197,6 @@ static int mtk_cec_probe(struct platform_device *pdev)
cec->regs = devm_ioremap_resource(dev, res);
if (IS_ERR(cec->regs)) {
ret = PTR_ERR(cec->regs);
- dev_err(dev, "Failed to ioremap cec: %d\n", ret);
return ret;
}
--
2.26.0.106.g9fadedd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] drm/mediatek: Remove redundant error printing in mtk_cec_probe()
2021-05-11 11:32 [PATCH 1/1] drm/mediatek: Remove redundant error printing in mtk_cec_probe() Zhen Lei
@ 2021-05-11 13:13 ` Baruch Siach
2021-05-11 13:18 ` Leizhen (ThunderTown)
0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2021-05-11 13:13 UTC (permalink / raw)
To: Zhen Lei
Cc: Chun-Kuang Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, dri-devel, linux-mediatek, linux-arm-kernel
Hi Zhen Lei,
On Tue, May 11 2021, Zhen Lei wrote:
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error
> information contains the device name, failure cause, and possibly resource
> information.
>
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/gpu/drm/mediatek/mtk_cec.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_cec.c b/drivers/gpu/drm/mediatek/mtk_cec.c
> index e9cef5c0c8f7eff..fd593ff99bfd447 100644
> --- a/drivers/gpu/drm/mediatek/mtk_cec.c
> +++ b/drivers/gpu/drm/mediatek/mtk_cec.c
> @@ -197,7 +197,6 @@ static int mtk_cec_probe(struct platform_device *pdev)
> cec->regs = devm_ioremap_resource(dev, res);
> if (IS_ERR(cec->regs)) {
> ret = PTR_ERR(cec->regs);
> - dev_err(dev, "Failed to ioremap cec: %d\n", ret);
> return ret;
You can just return PTR_ERR() directly. No need to set 'ret'.
baruch
> }
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] drm/mediatek: Remove redundant error printing in mtk_cec_probe()
2021-05-11 13:13 ` Baruch Siach
@ 2021-05-11 13:18 ` Leizhen (ThunderTown)
0 siblings, 0 replies; 3+ messages in thread
From: Leizhen (ThunderTown) @ 2021-05-11 13:18 UTC (permalink / raw)
To: Baruch Siach
Cc: Chun-Kuang Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, dri-devel, linux-mediatek, linux-arm-kernel
On 2021/5/11 21:13, Baruch Siach wrote:
> Hi Zhen Lei,
>
> On Tue, May 11 2021, Zhen Lei wrote:
>> When devm_ioremap_resource() fails, a clear enough error message will be
>> printed by its subfunction __devm_ioremap_resource(). The error
>> information contains the device name, failure cause, and possibly resource
>> information.
>>
>> Therefore, remove the error printing here to simplify code and reduce the
>> binary size.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>> drivers/gpu/drm/mediatek/mtk_cec.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/mediatek/mtk_cec.c b/drivers/gpu/drm/mediatek/mtk_cec.c
>> index e9cef5c0c8f7eff..fd593ff99bfd447 100644
>> --- a/drivers/gpu/drm/mediatek/mtk_cec.c
>> +++ b/drivers/gpu/drm/mediatek/mtk_cec.c
>> @@ -197,7 +197,6 @@ static int mtk_cec_probe(struct platform_device *pdev)
>> cec->regs = devm_ioremap_resource(dev, res);
>> if (IS_ERR(cec->regs)) {
>> ret = PTR_ERR(cec->regs);
>> - dev_err(dev, "Failed to ioremap cec: %d\n", ret);
>> return ret;
>
> You can just return PTR_ERR() directly. No need to set 'ret'.
Right, I will fix it tomorrow.
>
> baruch
>
>> }
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-11 13:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 11:32 [PATCH 1/1] drm/mediatek: Remove redundant error printing in mtk_cec_probe() Zhen Lei
2021-05-11 13:13 ` Baruch Siach
2021-05-11 13:18 ` Leizhen (ThunderTown)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).