From: "yukuai (C)" <yukuai3@huawei.com>
To: Markus Elfring <Markus.Elfring@web.de>, <kernel@pengutronix.de>,
<linux-arm-kernel@lists.infradead.org>, <linux-imx@nxp.com>
Cc: Anson Huang <Anson.Huang@nxp.com>, Yi Zhang <yi.zhang@huawei.com>,
Fabio Estevam <festevam@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
kernel-janitors@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH] ARM: imx6: add missing put_device() call in imx6q_suspend_init()
Date: Fri, 5 Jun 2020 17:08:37 +0800 [thread overview]
Message-ID: <2ab2cc9f-c720-75ca-e20c-0e4236ff45fd@huawei.com> (raw)
In-Reply-To: <cf810c93-297c-c02c-9bba-8c3d097b8e31@web.de>
On 2020/6/5 3:07, Markus Elfring wrote:
>> if of_find_device_by_node() succeed, imx6q_suspend_init() doesn't have a
>> corresponding put_device(). Thus add a jump target to fix the exception
>> handling for this function implementation.
>
> Do you find a previous update suggestion useful?
>
> ARM: imx6: Add missing put_device() call in imx6q_suspend_init()
> https://lore.kernel.org/linux-arm-kernel/5acd7308-f6e1-4b1e-c744-bb2e5fdca1be@web.de/
> https://lore.kernel.org/patchwork/patch/1151158/
> https://lkml.org/lkml/2019/11/9/125
Hi, Markus
It is useful indeed. Although I didn't run cocci script, since it can
produce too many false result which is hard to filter out.
BTW, I see you haver done the work already, I guess I won't send any
patches related to 'missing put_device after of_find_device_by_node()'.
Any idea why these pathes didn't get applied ?
Best regards,
Yu Kuai
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next parent reply other threads:[~2020-06-05 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cf810c93-297c-c02c-9bba-8c3d097b8e31@web.de>
2020-06-05 9:08 ` yukuai (C) [this message]
2020-06-05 10:15 ` ARM: imx6: add missing put_device() call in imx6q_suspend_init() Markus Elfring
[not found] ` <20200623073220.GV30139@dragon>
[not found] ` <5300cb30-2243-9bfe-125c-96e720cd1f29@web.de>
[not found] ` <20200623110222.GX30139@dragon>
[not found] ` <9f429c51-0fa9-16dc-4d62-d456551c5376@web.de>
[not found] ` <20200623120919.GE30139@dragon>
[not found] ` <66038b6c-6691-eda2-af15-f315270d4bee@web.de>
[not found] ` <CAJBJ56J9NfYPxnqtLfbeCHkRy2-xPEUJq7r3RvM8yi434AQF2Q@mail.gmail.com>
2020-06-24 14:26 ` Markus Elfring
2020-06-04 12:54 [PATCH] " yu kuai
-- strict thread matches above, loose matches on Subject: below --
2019-11-09 15:30 [PATCH] ARM: imx6: Add " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ab2cc9f-c720-75ca-e20c-0e4236ff45fd@huawei.com \
--to=yukuai3@huawei.com \
--cc=Anson.Huang@nxp.com \
--cc=Markus.Elfring@web.de \
--cc=festevam@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).