linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: bcm2835-rpi-zero-w: Drop unnecessary pinctrl
@ 2019-01-20 17:06 Stefan Wahren
  2019-01-21 20:29 ` Eric Anholt
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Wahren @ 2019-01-20 17:06 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Florian Fainelli, Ray Jui,
	Scott Branden, Eric Anholt
  Cc: Stefan Wahren, devicetree, Linus Walleij,
	bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel

There is no need to specify a pinctrl for the reset GPIO. So we better
remove this avoid a potential conflict between pinctrl and pwrseq
after the pinmux driver has been changed to strict:

pinctrl-bcm2835 20200000.gpio: pin gpio41 already requested by wifi-pwrseq;
cannot claim for pinctrl-bcm2835:499
pinctrl-bcm2835 20200000.gpio: pin-41 (pinctrl-bcm2835:499) status -22
pwrseq_simple: probe of wifi-pwrseq failed with error -22

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 arch/arm/boot/dts/bcm2835-rpi-zero-w.dts | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts b/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts
index 644d907..6071213 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts
@@ -25,8 +25,6 @@
 
 	wifi_pwrseq: wifi-pwrseq {
 		compatible = "mmc-pwrseq-simple";
-		pinctrl-names = "default";
-		pinctrl-0 = <&wl_on>;
 		reset-gpios = <&gpio 41 GPIO_ACTIVE_LOW>;
 	};
 };
@@ -98,11 +96,6 @@
 			  "SD_DATA3_R";
 
 	pinctrl-0 = <&gpioout &alt0>;
-
-	wl_on: wl-on {
-		brcm,pins = <41>;
-		brcm,function = <BCM2835_FSEL_GPIO_OUT>;
-	};
 };
 
 &hdmi {
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: bcm2835-rpi-zero-w: Drop unnecessary pinctrl
  2019-01-20 17:06 [PATCH] ARM: dts: bcm2835-rpi-zero-w: Drop unnecessary pinctrl Stefan Wahren
@ 2019-01-21 20:29 ` Eric Anholt
  2019-01-22  7:59   ` Stefan Wahren
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Anholt @ 2019-01-21 20:29 UTC (permalink / raw)
  To: Stefan Wahren, Rob Herring, Mark Rutland, Florian Fainelli,
	Ray Jui, Scott Branden
  Cc: Stefan Wahren, devicetree, Linus Walleij,
	bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel


[-- Attachment #1.1: Type: text/plain, Size: 597 bytes --]

Stefan Wahren <stefan.wahren@i2se.com> writes:

> There is no need to specify a pinctrl for the reset GPIO. So we better
> remove this avoid a potential conflict between pinctrl and pwrseq
> after the pinmux driver has been changed to strict:
>
> pinctrl-bcm2835 20200000.gpio: pin gpio41 already requested by wifi-pwrseq;
> cannot claim for pinctrl-bcm2835:499
> pinctrl-bcm2835 20200000.gpio: pin-41 (pinctrl-bcm2835:499) status -22
> pwrseq_simple: probe of wifi-pwrseq failed with error -22
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>

Reviewed-by: Eric Anholt <eric@anholt.net>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: bcm2835-rpi-zero-w: Drop unnecessary pinctrl
  2019-01-21 20:29 ` Eric Anholt
@ 2019-01-22  7:59   ` Stefan Wahren
  0 siblings, 0 replies; 3+ messages in thread
From: Stefan Wahren @ 2019-01-22  7:59 UTC (permalink / raw)
  To: Eric Anholt, Rob Herring, Mark Rutland, Florian Fainelli,
	Ray Jui, Scott Branden
  Cc: devicetree, Linus Walleij, bcm-kernel-feedback-list,
	linux-rpi-kernel, linux-arm-kernel

Am 21.01.19 um 21:29 schrieb Eric Anholt:
> Stefan Wahren <stefan.wahren@i2se.com> writes:
>
>> There is no need to specify a pinctrl for the reset GPIO. So we better
>> remove this avoid a potential conflict between pinctrl and pwrseq
>> after the pinmux driver has been changed to strict:
>>
>> pinctrl-bcm2835 20200000.gpio: pin gpio41 already requested by wifi-pwrseq;
>> cannot claim for pinctrl-bcm2835:499
>> pinctrl-bcm2835 20200000.gpio: pin-41 (pinctrl-bcm2835:499) status -22
>> pwrseq_simple: probe of wifi-pwrseq failed with error -22
>>
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Reviewed-by: Eric Anholt <eric@anholt.net>

Applied to bcm2835-dt-next

Thanks


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-01-22  7:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-20 17:06 [PATCH] ARM: dts: bcm2835-rpi-zero-w: Drop unnecessary pinctrl Stefan Wahren
2019-01-21 20:29 ` Eric Anholt
2019-01-22  7:59   ` Stefan Wahren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).