* [PATCH] drm/rockchip: Remove unneeded semicolon
@ 2022-05-06 1:55 Haowen Bai
2022-05-08 14:54 ` Heiko Stuebner
0 siblings, 1 reply; 4+ messages in thread
From: Haowen Bai @ 2022-05-06 1:55 UTC (permalink / raw)
To: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter
Cc: Haowen Bai, dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel
Fixes coccicheck warning:
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:1476:2-3: Unneeded semicolon
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index 0b49fed16535..7f9d88634a77 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -1473,7 +1473,7 @@ static void rk3568_set_intf_mux(struct vop2_video_port *vp, int id,
default:
drm_err(vop2->drm, "Invalid interface id %d on vp%d\n", id, vp->id);
return;
- };
+ }
dip |= RK3568_DSP_IF_POL__CFG_DONE_IMD;
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/rockchip: Remove unneeded semicolon
2022-05-06 1:55 [PATCH] drm/rockchip: Remove unneeded semicolon Haowen Bai
@ 2022-05-08 14:54 ` Heiko Stuebner
0 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2022-05-08 14:54 UTC (permalink / raw)
To: Sandy Huang, David Airlie, Daniel Vetter, Haowen Bai
Cc: Haowen Bai, dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel
Am Freitag, 6. Mai 2022, 03:55:57 CEST schrieb Haowen Bai:
> Fixes coccicheck warning:
>
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:1476:2-3: Unneeded semicolon
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
Yang Li was slightly faster [0] than this patch, so I've picked that one.
[0] https://lore.kernel.org/r/20220505232659.4405-1-yang.lee@linux.alibaba.com
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> index 0b49fed16535..7f9d88634a77 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> @@ -1473,7 +1473,7 @@ static void rk3568_set_intf_mux(struct vop2_video_port *vp, int id,
> default:
> drm_err(vop2->drm, "Invalid interface id %d on vp%d\n", id, vp->id);
> return;
> - };
> + }
>
> dip |= RK3568_DSP_IF_POL__CFG_DONE_IMD;
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/rockchip: Remove unneeded semicolon
2020-04-24 7:44 Zheng Bin
@ 2020-04-27 19:18 ` Heiko Stuebner
0 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2020-04-27 19:18 UTC (permalink / raw)
To: linux-arm-kernel, airlied, daniel, linux-rockchip, Zheng Bin,
dri-devel, hjc
Cc: Heiko Stuebner
On Fri, 24 Apr 2020 15:44:10 +0800, Zheng Bin wrote:
> Fixes coccicheck warning:
>
> drivers/gpu/drm/rockchip/cdn-dp-reg.c:604:2-3: Unneeded semicolon
> drivers/gpu/drm/rockchip/cdn-dp-reg.c:622:2-3: Unneeded semicolon
> drivers/gpu/drm/rockchip/cdn-dp-reg.c:703:2-3: Unneeded semicolon
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
>
> [...]
Applied, thanks!
[1/1] drm/rockchip: Remove unneeded semicolon
commit: 611e22b1d9f61a8742c99433de9ff40795574c61
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drm/rockchip: Remove unneeded semicolon
@ 2020-04-24 7:44 Zheng Bin
2020-04-27 19:18 ` Heiko Stuebner
0 siblings, 1 reply; 4+ messages in thread
From: Zheng Bin @ 2020-04-24 7:44 UTC (permalink / raw)
To: hjc, heiko, airlied, daniel, dri-devel, linux-arm-kernel, linux-rockchip
Cc: zhengbin13
Fixes coccicheck warning:
drivers/gpu/drm/rockchip/cdn-dp-reg.c:604:2-3: Unneeded semicolon
drivers/gpu/drm/rockchip/cdn-dp-reg.c:622:2-3: Unneeded semicolon
drivers/gpu/drm/rockchip/cdn-dp-reg.c:703:2-3: Unneeded semicolon
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/gpu/drm/rockchip/cdn-dp-reg.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-reg.c b/drivers/gpu/drm/rockchip/cdn-dp-reg.c
index 7361c07cb4a7..9d2163ef4d6e 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-reg.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-reg.c
@@ -601,7 +601,7 @@ static int cdn_dp_get_msa_misc(struct video_info *video,
case YCBCR_4_2_0:
val[0] = 5;
break;
- };
+ }
switch (video->color_depth) {
case 6:
@@ -619,7 +619,7 @@ static int cdn_dp_get_msa_misc(struct video_info *video,
case 16:
val[1] = 4;
break;
- };
+ }
msa_misc = 2 * val[0] + 32 * val[1] +
((video->color_fmt == Y_ONLY) ? (1 << 14) : 0);
@@ -700,7 +700,7 @@ int cdn_dp_config_video(struct cdn_dp_device *dp)
case 16:
val = BCS_16;
break;
- };
+ }
val += video->color_fmt << 8;
ret = cdn_dp_reg_write(dp, DP_FRAMER_PXL_REPR, val);
--
2.26.0.106.g9fadedd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-08 14:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-06 1:55 [PATCH] drm/rockchip: Remove unneeded semicolon Haowen Bai
2022-05-08 14:54 ` Heiko Stuebner
-- strict thread matches above, loose matches on Subject: below --
2020-04-24 7:44 Zheng Bin
2020-04-27 19:18 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).