Re: [PATCH v7 0/6] support a new type of PMIC, including two chips(rk817 and rk809)

Re: [PATCH v7 0/6] support a new type of PMIC, including two chips(rk817 and rk809)

[Heiko Stübner]

Hi Lee,

Am Mittwoch, 2. Januar 2019, 11:19:56 CET schrieb Tony Xie:
> Most of functions and registers of the rk817 and rk808 are the same,
> so they can share allmost all codes.

do you have this series on your radar somewhere or should Tony
resend the series? As it looks like it fell through the cracks somehow.


Thanks
Heiko


> Their specifications are as follows:
>   1) The RK809 and RK809 consist of 5 DCDCs, 9 LDOs and have the same
> registers
>      for these components except dcdc5.
>   2) The dcdc5 is a boost dcdc for RK817 and is a buck for RK809.
>   3) The RK817 has one switch but The Rk809 has two.
> 
> Changes in V2:
> 1. initialize the pm_pwroff_fn to NULL.
> 2. use EXPORT_SYMBOL_GPL to export pm_power_off_prepare.
> 3. change patch 2/3/4/5 subjects.
> 
> Changes in V3
> 1. change patch 4 subjects
> 2. replace pr_ with dev_ for printing in patch 2
> 3. modify switch1 and switch2 configs in patch 2
> 4. explain gpio information for rk809 and rk817 in patch 4
> 
> Changes in V4:
> 1. modify some codes for patch 2 and patch 5 according to comments
> 2. add reviewer mail lists for patch 3 and 4
> 
> Changes in V5:
> modify some codes for patch 1 according to reveiw comments for v3.
>  1) remove the pm_power_off_prepare() and replace with shutdown
> call-back from syscore
>  2) move the macro REGMAP_IRQ_M into the regmap.h and rename it
> REGMAP_IRQ_LINE
>  3) make some dev_warn() log clear
> 
> Changes in V6:
> modify some codes according to reveiw comments for v5.
> 
> Changes in V7:
> modify some codes for patch 2 according to reveiw comments.
> 
> Tony Xie (6):
>   mfd: rk808: remove the id_table
>   mfd: rk808: Add RK817 and RK809 support
>   regulator: rk808: add RK809 and RK817 support.
>   dt-bindings: mfd: rk808: Add binding information for RK809 and RK817.
>   rtc: rk808: add RK809 and RK817 support.
>   clk: RK808: add RK809 and RK817 support.
> 
>  .../devicetree/bindings/mfd/rk808.txt         |  44 ++
>  drivers/clk/Kconfig                           |   9 +-
>  drivers/clk/clk-rk808.c                       |  64 +-
>  drivers/mfd/Kconfig                           |   6 +-
>  drivers/mfd/rk808.c                           | 199 +++++-
>  drivers/regulator/Kconfig                     |   4 +-
>  drivers/regulator/rk808-regulator.c           | 657 +++++++++++++++++-
>  drivers/rtc/Kconfig                           |   4 +-
>  drivers/rtc/rtc-rk808.c                       |  68 +-
>  include/linux/mfd/rk808.h                     | 175 +++++
>  10 files changed, 1164 insertions(+), 66 deletions(-)





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v7 0/6] support a new type of PMIC,including two chips(rk817 and rk809)

[Lee Jones]

On Tue, 19 Mar 2019, Heiko Stübner wrote:
> Am Mittwoch, 2. Januar 2019, 11:19:56 CET schrieb Tony Xie:
> > Most of functions and registers of the rk817 and rk808 are the same,
> > so they can share allmost all codes.
> 
> do you have this series on your radar somewhere or should Tony
> resend the series? As it looks like it fell through the cracks somehow.

It wasn't, but it is now, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v7 1/6] mfd: rk808: remove the id_table

[Lee Jones]

On Wed, 02 Jan 2019, Tony Xie wrote:

> Remove the id_table because it's not used.
> 
> Signed-off-by: Tony Xie <tony.xie@rock-chips.com>
> ---
>  drivers/mfd/rk808.c | 9 ---------
>  1 file changed, 9 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v7 2/6] mfd: rk808: Add RK817 and RK809 support

[Lee Jones]

On Wed, 02 Jan 2019, Tony Xie wrote:

> The RK809 and RK817 are a Power Management IC (PMIC) for multimedia
> and handheld devices. They contains the following components:
>   - Regulators
>   - RTC
>   - Clocking
> 
> Both RK809 and RK817 chips are using a similar register map,
> so we can reuse the RTC and Clocking functionality.
> Most of regulators have a some implementation also.
> 
> Signed-off-by: Tony Xie <tony.xie@rock-chips.com>
> Acked-by: Stephen Boyd <sboyd@kernel.org>
> ---
>  drivers/mfd/Kconfig       |   6 +-
>  drivers/mfd/rk808.c       | 192 +++++++++++++++++++++++++++++++++++++-
>  include/linux/mfd/rk808.h | 172 ++++++++++++++++++++++++++++++++++
>  3 files changed, 364 insertions(+), 6 deletions(-)

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v7 2/6] mfd: rk808: Add RK817 and RK809 support

[Heiko Stuebner]

Hi Lee,

Am Dienstag, 2. April 2019, 08:33:05 CEST schrieb Lee Jones:
> On Wed, 02 Jan 2019, Tony Xie wrote:
> 
> > The RK809 and RK817 are a Power Management IC (PMIC) for multimedia
> > and handheld devices. They contains the following components:
> >   - Regulators
> >   - RTC
> >   - Clocking
> > 
> > Both RK809 and RK817 chips are using a similar register map,
> > so we can reuse the RTC and Clocking functionality.
> > Most of regulators have a some implementation also.
> > 
> > Signed-off-by: Tony Xie <tony.xie@rock-chips.com>
> > Acked-by: Stephen Boyd <sboyd@kernel.org>
> > ---
> >  drivers/mfd/Kconfig       |   6 +-
> >  drivers/mfd/rk808.c       | 192 +++++++++++++++++++++++++++++++++++++-
> >  include/linux/mfd/rk808.h | 172 ++++++++++++++++++++++++++++++++++
> >  3 files changed, 364 insertions(+), 6 deletions(-)
> 
> For my own reference:
>   Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

do you have some sort of merge plan for this or are you waiting for
specific Acks? I guess if we're waiting for an Ack from Mark Brown,
we'll need a resend of the patch.

All other patches have Acks from their subsystem maintainers (rtc, clk)
so you could pick up all patches except patch3 and I could just resend
this one, which in turn could also go through the regulator tree.

Otherwise we'll probably need a resend of the series, as Mark most of
the time doesn't keep old patch series around.


Heiko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v7 2/6] mfd: rk808: Add RK817 and RK809 support

[Lee Jones]

On Thu, 11 Apr 2019, Heiko Stuebner wrote:

> Hi Lee,
> 
> Am Dienstag, 2. April 2019, 08:33:05 CEST schrieb Lee Jones:
> > On Wed, 02 Jan 2019, Tony Xie wrote:
> > 
> > > The RK809 and RK817 are a Power Management IC (PMIC) for multimedia
> > > and handheld devices. They contains the following components:
> > >   - Regulators
> > >   - RTC
> > >   - Clocking
> > > 
> > > Both RK809 and RK817 chips are using a similar register map,
> > > so we can reuse the RTC and Clocking functionality.
> > > Most of regulators have a some implementation also.
> > > 
> > > Signed-off-by: Tony Xie <tony.xie@rock-chips.com>
> > > Acked-by: Stephen Boyd <sboyd@kernel.org>
> > > ---
> > >  drivers/mfd/Kconfig       |   6 +-
> > >  drivers/mfd/rk808.c       | 192 +++++++++++++++++++++++++++++++++++++-
> > >  include/linux/mfd/rk808.h | 172 ++++++++++++++++++++++++++++++++++
> > >  3 files changed, 364 insertions(+), 6 deletions(-)
> > 
> > For my own reference:
> >   Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> 
> do you have some sort of merge plan for this or are you waiting for
> specific Acks? I guess if we're waiting for an Ack from Mark Brown,
> we'll need a resend of the patch.
> 
> All other patches have Acks from their subsystem maintainers (rtc, clk)
> so you could pick up all patches except patch3 and I could just resend
> this one, which in turn could also go through the regulator tree.
> 
> Otherwise we'll probably need a resend of the series, as Mark most of
> the time doesn't keep old patch series around.

Try resending it.  Hopefully he will review in the next week or so can
I can collect it when I return back from Shared Parental Leave.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v7 0/6] support a new type of PMIC, including two chips(rk817 and rk809)

[Tony Xie]

Most of functions and registers of the rk817 and rk808 are the same,
so they can share allmost all codes.

Their specifications are as follows:
  1) The RK809 and RK809 consist of 5 DCDCs, 9 LDOs and have the same
registers
     for these components except dcdc5.
  2) The dcdc5 is a boost dcdc for RK817 and is a buck for RK809.
  3) The RK817 has one switch but The Rk809 has two.

Changes in V2:
1. initialize the pm_pwroff_fn to NULL. 
2. use EXPORT_SYMBOL_GPL to export pm_power_off_prepare.
3. change patch 2/3/4/5 subjects. 

Changes in V3
1. change patch 4 subjects
2. replace pr_ with dev_ for printing in patch 2
3. modify switch1 and switch2 configs in patch 2
4. explain gpio information for rk809 and rk817 in patch 4

Changes in V4:
1. modify some codes for patch 2 and patch 5 according to comments 
2. add reviewer mail lists for patch 3 and 4

Changes in V5:
modify some codes for patch 1 according to reveiw comments for v3.
 1) remove the pm_power_off_prepare() and replace with shutdown
call-back from syscore
 2) move the macro REGMAP_IRQ_M into the regmap.h and rename it
REGMAP_IRQ_LINE
 3) make some dev_warn() log clear

Changes in V6:
modify some codes according to reveiw comments for v5.

Changes in V7:
modify some codes for patch 2 according to reveiw comments.

Tony Xie (6):
  mfd: rk808: remove the id_table
  mfd: rk808: Add RK817 and RK809 support
  regulator: rk808: add RK809 and RK817 support.
  dt-bindings: mfd: rk808: Add binding information for RK809 and RK817.
  rtc: rk808: add RK809 and RK817 support.
  clk: RK808: add RK809 and RK817 support.

 .../devicetree/bindings/mfd/rk808.txt         |  44 ++
 drivers/clk/Kconfig                           |   9 +-
 drivers/clk/clk-rk808.c                       |  64 +-
 drivers/mfd/Kconfig                           |   6 +-
 drivers/mfd/rk808.c                           | 199 +++++-
 drivers/regulator/Kconfig                     |   4 +-
 drivers/regulator/rk808-regulator.c           | 657 +++++++++++++++++-
 drivers/rtc/Kconfig                           |   4 +-
 drivers/rtc/rtc-rk808.c                       |  68 +-
 include/linux/mfd/rk808.h                     | 175 +++++
 10 files changed, 1164 insertions(+), 66 deletions(-)

-- 
2.17.1




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel