* [PATCH -next] udc: lpc32xx: make symbol 'lpc32xx_usbddata' static
@ 2020-07-07 10:53 Wei Yongjun
2020-07-12 7:51 ` Vladimir Zapolskiy
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2020-07-07 10:53 UTC (permalink / raw)
To: Hulk Robot, Felipe Balbi, Greg Kroah-Hartman, Vladimir Zapolskiy,
Sylvain Lemieux, Arnd Bergmann, Gustavo A. R. Silva,
Colin Ian King, Corentin Labbe
Cc: linux-usb, Wei Yongjun, linux-arm-kernel
The sparse tool complains as follows:
drivers/usb/gadget/udc/lpc32xx_udc.c:2989:25: warning:
symbol 'lpc32xx_usbddata' was not declared. Should it be static?
This variable is not used outside of lpc32xx_udc.c, so this commit
marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/usb/gadget/udc/lpc32xx_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c
index 4a112670cc6c..e8a4637a9a17 100644
--- a/drivers/usb/gadget/udc/lpc32xx_udc.c
+++ b/drivers/usb/gadget/udc/lpc32xx_udc.c
@@ -2986,7 +2986,7 @@ static void lpc32xx_rmwkup_chg(int remote_wakup_enable)
/* Enable or disable USB remote wakeup */
}
-struct lpc32xx_usbd_cfg lpc32xx_usbddata = {
+static struct lpc32xx_usbd_cfg lpc32xx_usbddata = {
.vbus_drv_pol = 0,
.conn_chgb = &lpc32xx_usbd_conn_chg,
.susp_chgb = &lpc32xx_usbd_susp_chg,
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] udc: lpc32xx: make symbol 'lpc32xx_usbddata' static
2020-07-07 10:53 [PATCH -next] udc: lpc32xx: make symbol 'lpc32xx_usbddata' static Wei Yongjun
@ 2020-07-12 7:51 ` Vladimir Zapolskiy
0 siblings, 0 replies; 2+ messages in thread
From: Vladimir Zapolskiy @ 2020-07-12 7:51 UTC (permalink / raw)
To: Wei Yongjun, Felipe Balbi
Cc: Arnd Bergmann, Gustavo A. R. Silva, Greg Kroah-Hartman,
linux-usb, Hulk Robot, Corentin Labbe, Sylvain Lemieux,
Colin Ian King, linux-arm-kernel
On 7/7/20 1:53 PM, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/usb/gadget/udc/lpc32xx_udc.c:2989:25: warning:
> symbol 'lpc32xx_usbddata' was not declared. Should it be static?
>
> This variable is not used outside of lpc32xx_udc.c, so this commit
> marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
--
Best wishes,
Vladimir
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-12 7:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-07 10:53 [PATCH -next] udc: lpc32xx: make symbol 'lpc32xx_usbddata' static Wei Yongjun
2020-07-12 7:51 ` Vladimir Zapolskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).