* Re: [PATCH v2 1/2] dt-bindings: pinctrl: add support for MediaTek mt8188
[not found] ` <20220727102140.6676-2-hui.liu@mediatek.com>
@ 2022-07-27 10:30 ` Krzysztof Kozlowski
2022-07-27 13:57 ` Rob Herring
1 sibling, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-27 10:30 UTC (permalink / raw)
To: Hui Liu, linus.walleij, robh+dt, krzysztof.kozlowski+dt, matthias.bgg
Cc: Project_Global_Chrome_Upstream_Group, jianguo.zhang, zhiyong.tao,
sean.wang, linux-gpio, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel
On 27/07/2022 12:21, Hui Liu wrote:
> From: "Hui.Liu" <hui.liu@mediatek.com>
>
> Add pinctrl function header file and binding document for mt8188.
>
> Signed-off-by: Hui.Liu <hui.liu@mediatek.com>
> ---
> .../pinctrl/mediatek,mt8188-pinctrl.yaml | 238 +++
> .../pinctrl/mediatek,mt8188-pinfunc.h | 1280 +++++++++++++++++
> 2 files changed, 1518 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml
> create mode 100644 include/dt-bindings/pinctrl/mediatek,mt8188-pinfunc.h
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml
> new file mode 100644
> index 000000000000..a9d5e9eec35d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml
> @@ -0,0 +1,238 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/pinctrl-mt8188.yaml#
Does not look like you tested the bindings. Please run `make
dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: pinctrl: add support for MediaTek mt8188
[not found] ` <20220727102140.6676-2-hui.liu@mediatek.com>
2022-07-27 10:30 ` [PATCH v2 1/2] dt-bindings: pinctrl: add support for MediaTek mt8188 Krzysztof Kozlowski
@ 2022-07-27 13:57 ` Rob Herring
1 sibling, 0 replies; 2+ messages in thread
From: Rob Herring @ 2022-07-27 13:57 UTC (permalink / raw)
To: Hui Liu
Cc: linux-gpio, Project_Global_Chrome_Upstream_Group, jianguo.zhang,
sean.wang, devicetree, linux-mediatek, linux-kernel,
linus.walleij, zhiyong.tao, linux-arm-kernel, robh+dt,
krzysztof.kozlowski+dt, matthias.bgg
On Wed, 27 Jul 2022 18:21:39 +0800, Hui Liu wrote:
> From: "Hui.Liu" <hui.liu@mediatek.com>
>
> Add pinctrl function header file and binding document for mt8188.
>
> Signed-off-by: Hui.Liu <hui.liu@mediatek.com>
> ---
> .../pinctrl/mediatek,mt8188-pinctrl.yaml | 238 +++
> .../pinctrl/mediatek,mt8188-pinfunc.h | 1280 +++++++++++++++++
> 2 files changed, 1518 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml
> create mode 100644 include/dt-bindings/pinctrl/mediatek,mt8188-pinfunc.h
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/pinctrl/mediatek,mt8188-pinctrl.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.example.dtb: pinctrl@10005000: spi0-pins:pins-spi:bias-pull-up: More than one condition true in oneOf schema:
{'oneOf': [{'items': [{'items': [{'enum': [100, 101, 102, 103]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{},
{'items': [{'items': [{'enum': [200,
201,
202,
203,
204,
205,
206,
207]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{},
{'items': [{'items': [{'enum': [1000,
1500,
2000,
3000,
4000,
5000,
10000,
75000]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{}]}
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.example.dtb: pinctrl@10005000: spi0-pins:pins-spi-mi:bias-pull-down: More than one condition true in oneOf schema:
{'oneOf': [{'items': [{'items': [{'enum': [100, 101, 102, 103]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{},
{'items': [{'items': [{'enum': [200,
201,
202,
203,
204,
205,
206,
207]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{},
{'items': [{'items': [{'enum': [75000, 5000]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{}]}
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.example.dtb: pinctrl@10005000: i2c0-pins:pins:bias-pull-down: More than one condition true in oneOf schema:
{'oneOf': [{'items': [{'items': [{'enum': [100, 101, 102, 103]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{},
{'items': [{'items': [{'enum': [200,
201,
202,
203,
204,
205,
206,
207]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{},
{'items': [{'items': [{'enum': [75000, 5000]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{}]}
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.example.dtb: pinctrl@10005000: i2c1-pins:pins:bias-pull-up: More than one condition true in oneOf schema:
{'oneOf': [{'items': [{'items': [{'enum': [100, 101, 102, 103]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{},
{'items': [{'items': [{'enum': [200,
201,
202,
203,
204,
205,
206,
207]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{},
{'items': [{'items': [{'enum': [1000,
1500,
2000,
3000,
4000,
5000,
10000,
75000]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{}]}
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-27 13:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220727102140.6676-1-hui.liu@mediatek.com>
[not found] ` <20220727102140.6676-2-hui.liu@mediatek.com>
2022-07-27 10:30 ` [PATCH v2 1/2] dt-bindings: pinctrl: add support for MediaTek mt8188 Krzysztof Kozlowski
2022-07-27 13:57 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).