* [PATCH] media: staging: use strscpy() instead of strlcpy()
@ 2019-03-29 15:29 Mauro Carvalho Chehab
2019-03-29 15:30 ` Hans Verkuil
2019-03-29 20:31 ` Mukesh Ojha
0 siblings, 2 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2019-03-29 15:29 UTC (permalink / raw)
Cc: devel, Fabio Estevam, YueHaibing, Pengutronix Kernel Team,
linux-rockchip, Ezequiel Garcia, Greg Kroah-Hartman,
Sascha Hauer, Heiko Stuebner, Mauro Carvalho Chehab,
Hans Verkuil, NXP Linux Team, Philipp Zabel, Steve Longerbeam,
Mauro Carvalho Chehab, Shawn Guo, linux-arm-kernel,
Linux Media Mailing List
There are a few left overs at staging with were still using the
deprecated strlcpy() function.
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
---
drivers/staging/media/imx/imx-media-dev-common.c | 4 ++--
drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/imx/imx-media-dev-common.c b/drivers/staging/media/imx/imx-media-dev-common.c
index 910594125889..6cd93419b81d 100644
--- a/drivers/staging/media/imx/imx-media-dev-common.c
+++ b/drivers/staging/media/imx/imx-media-dev-common.c
@@ -30,7 +30,7 @@ struct imx_media_dev *imx_media_dev_init(struct device *dev)
dev_set_drvdata(dev, imxmd);
- strlcpy(imxmd->md.model, "imx-media", sizeof(imxmd->md.model));
+ strscpy(imxmd->md.model, "imx-media", sizeof(imxmd->md.model));
imxmd->md.ops = &imx_media_md_ops;
imxmd->md.dev = dev;
@@ -38,7 +38,7 @@ struct imx_media_dev *imx_media_dev_init(struct device *dev)
imxmd->v4l2_dev.mdev = &imxmd->md;
imxmd->v4l2_dev.notify = imx_media_notify;
- strlcpy(imxmd->v4l2_dev.name, "imx-media",
+ strscpy(imxmd->v4l2_dev.name, "imx-media",
sizeof(imxmd->v4l2_dev.name));
media_device_init(&imxmd->md);
diff --git a/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c b/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c
index 57611464ad07..58721c46fba4 100644
--- a/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c
+++ b/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c
@@ -462,7 +462,7 @@ static int rockchip_vpu_probe(struct platform_device *pdev)
}
vpu->mdev.dev = vpu->dev;
- strlcpy(vpu->mdev.model, DRIVER_NAME, sizeof(vpu->mdev.model));
+ strscpy(vpu->mdev.model, DRIVER_NAME, sizeof(vpu->mdev.model));
media_device_init(&vpu->mdev);
vpu->v4l2_dev.mdev = &vpu->mdev;
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: staging: use strscpy() instead of strlcpy()
2019-03-29 15:29 [PATCH] media: staging: use strscpy() instead of strlcpy() Mauro Carvalho Chehab
@ 2019-03-29 15:30 ` Hans Verkuil
2019-03-29 20:31 ` Mukesh Ojha
1 sibling, 0 replies; 3+ messages in thread
From: Hans Verkuil @ 2019-03-29 15:30 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: devel, Fabio Estevam, YueHaibing, Pengutronix Kernel Team,
Ezequiel Garcia, Greg Kroah-Hartman, Sascha Hauer,
Heiko Stuebner, Mauro Carvalho Chehab, linux-rockchip,
NXP Linux Team, Philipp Zabel, Steve Longerbeam, Shawn Guo,
linux-arm-kernel, Linux Media Mailing List
On 3/29/19 4:29 PM, Mauro Carvalho Chehab wrote:
> There are a few left overs at staging with were still using the
> deprecated strlcpy() function.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Thanks!
Hans
> ---
> drivers/staging/media/imx/imx-media-dev-common.c | 4 ++--
> drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-dev-common.c b/drivers/staging/media/imx/imx-media-dev-common.c
> index 910594125889..6cd93419b81d 100644
> --- a/drivers/staging/media/imx/imx-media-dev-common.c
> +++ b/drivers/staging/media/imx/imx-media-dev-common.c
> @@ -30,7 +30,7 @@ struct imx_media_dev *imx_media_dev_init(struct device *dev)
>
> dev_set_drvdata(dev, imxmd);
>
> - strlcpy(imxmd->md.model, "imx-media", sizeof(imxmd->md.model));
> + strscpy(imxmd->md.model, "imx-media", sizeof(imxmd->md.model));
> imxmd->md.ops = &imx_media_md_ops;
> imxmd->md.dev = dev;
>
> @@ -38,7 +38,7 @@ struct imx_media_dev *imx_media_dev_init(struct device *dev)
>
> imxmd->v4l2_dev.mdev = &imxmd->md;
> imxmd->v4l2_dev.notify = imx_media_notify;
> - strlcpy(imxmd->v4l2_dev.name, "imx-media",
> + strscpy(imxmd->v4l2_dev.name, "imx-media",
> sizeof(imxmd->v4l2_dev.name));
>
> media_device_init(&imxmd->md);
> diff --git a/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c b/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c
> index 57611464ad07..58721c46fba4 100644
> --- a/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c
> +++ b/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c
> @@ -462,7 +462,7 @@ static int rockchip_vpu_probe(struct platform_device *pdev)
> }
>
> vpu->mdev.dev = vpu->dev;
> - strlcpy(vpu->mdev.model, DRIVER_NAME, sizeof(vpu->mdev.model));
> + strscpy(vpu->mdev.model, DRIVER_NAME, sizeof(vpu->mdev.model));
> media_device_init(&vpu->mdev);
> vpu->v4l2_dev.mdev = &vpu->mdev;
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: staging: use strscpy() instead of strlcpy()
2019-03-29 15:29 [PATCH] media: staging: use strscpy() instead of strlcpy() Mauro Carvalho Chehab
2019-03-29 15:30 ` Hans Verkuil
@ 2019-03-29 20:31 ` Mukesh Ojha
1 sibling, 0 replies; 3+ messages in thread
From: Mukesh Ojha @ 2019-03-29 20:31 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: devel, Heiko Stuebner, Ezequiel Garcia, Sascha Hauer,
Steve Longerbeam, YueHaibing, Shawn Guo, Mauro Carvalho Chehab,
linux-rockchip, NXP Linux Team, Pengutronix Kernel Team,
Greg Kroah-Hartman, Hans Verkuil, Philipp Zabel, Fabio Estevam,
linux-arm-kernel, Linux Media Mailing List
On 3/29/2019 8:59 PM, Mauro Carvalho Chehab wrote:
> There are a few left overs at staging with were still using the
> deprecated strlcpy() function.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
s/with/which
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/staging/media/imx/imx-media-dev-common.c | 4 ++--
> drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-dev-common.c b/drivers/staging/media/imx/imx-media-dev-common.c
> index 910594125889..6cd93419b81d 100644
> --- a/drivers/staging/media/imx/imx-media-dev-common.c
> +++ b/drivers/staging/media/imx/imx-media-dev-common.c
> @@ -30,7 +30,7 @@ struct imx_media_dev *imx_media_dev_init(struct device *dev)
>
> dev_set_drvdata(dev, imxmd);
>
> - strlcpy(imxmd->md.model, "imx-media", sizeof(imxmd->md.model));
> + strscpy(imxmd->md.model, "imx-media", sizeof(imxmd->md.model));
> imxmd->md.ops = &imx_media_md_ops;
> imxmd->md.dev = dev;
>
> @@ -38,7 +38,7 @@ struct imx_media_dev *imx_media_dev_init(struct device *dev)
>
> imxmd->v4l2_dev.mdev = &imxmd->md;
> imxmd->v4l2_dev.notify = imx_media_notify;
> - strlcpy(imxmd->v4l2_dev.name, "imx-media",
> + strscpy(imxmd->v4l2_dev.name, "imx-media",
> sizeof(imxmd->v4l2_dev.name));
>
> media_device_init(&imxmd->md);
> diff --git a/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c b/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c
> index 57611464ad07..58721c46fba4 100644
> --- a/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c
> +++ b/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c
> @@ -462,7 +462,7 @@ static int rockchip_vpu_probe(struct platform_device *pdev)
> }
>
> vpu->mdev.dev = vpu->dev;
> - strlcpy(vpu->mdev.model, DRIVER_NAME, sizeof(vpu->mdev.model));
> + strscpy(vpu->mdev.model, DRIVER_NAME, sizeof(vpu->mdev.model));
> media_device_init(&vpu->mdev);
> vpu->v4l2_dev.mdev = &vpu->mdev;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-29 20:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-29 15:29 [PATCH] media: staging: use strscpy() instead of strlcpy() Mauro Carvalho Chehab
2019-03-29 15:30 ` Hans Verkuil
2019-03-29 20:31 ` Mukesh Ojha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).