From: Jeremy Linton <jeremy.linton@arm.com>
To: Mark Brown <broonie@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: Szabolcs Nagy <szabolcs.nagy@arm.com>,
Dave Martin <dave.martin@arm.com>,
"H . J . Lu" <hjl.tools@gmail.com>,
Yu-cheng Yu <yu-cheng.yu@intel.com>,
linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
libc-alpha@sourceware.org
Subject: Re: [PATCH v2 0/3] arm64: Enable BTI for the executable as well as the interpreter
Date: Thu, 10 Jun 2021 11:28:12 -0500 [thread overview]
Message-ID: <43e67d7b-aab9-db1f-f74b-a87ba7442d47@arm.com> (raw)
In-Reply-To: <20210604112450.13344-1-broonie@kernel.org>
Hi,
On 6/4/21 6:24 AM, Mark Brown wrote:
> Deployments of BTI on arm64 have run into issues interacting with
> systemd's MemoryDenyWriteExecute feature. Currently for dynamically
> linked executables the kernel will only handle architecture specific
> properties like BTI for the interpreter, the expectation is that the
> interpreter will then handle any properties on the main executable.
> For BTI this means remapping the executable segments PROT_EXEC |
> PROT_BTI.
>
> This interacts poorly with MemoryDenyWriteExecute since that is
> implemented using a seccomp filter which prevents setting PROT_EXEC on
> already mapped memory and lacks the context to be able to detect that
> memory is already mapped with PROT_EXEC. This series resolves this by
> handling the BTI property for both the interpreter and the main
> executable.
I've got a Fedora34 system booting in qemu or a model with BTI enabled.
On that system I took the systemd-resolved executable, which is one of
the services with MDWE enabled, and replaced a number of the bti's with
nops. I expect the service to continue to work with the fedora or
mainline 5.13 kernel and it does. If instead I boot with MDWE=no for the
service, it should fail to start given either of those kernels, and it does.
Thus, I expect that with his patch applied to 5.13 the service will fail
to start regardless of the state of MDWE, but it seems to continue
starting when I set MDWE=yes. Same behavior with v1 FWTW.
Of course, there is a good chance I've messed something up or i'm
missing something. I should really validate the /lib/ld-linux behavior
itself too. I guess this could just as well be a glibc issue (f34 has
glibc 2.33-5 which appears to have the re-mmap on failure patch). Either
way, systemd-resolved is a LSB PIE, with /lib/ld-linux as its
interpreter. I've not dug too deep into debugging this, cause I've got a
couple other things I need to deal with in the next couple days, and I
strongly dislike booting a full debug+system on the model. chuckle, sorry...
Thanks,
>
> This does mean that we may get more code with BTI enabled if running on
> a system without BTI support in the dynamic linker, this is expected to
> be a safe configuration and testing seems to confirm that. It also
> reduces the flexibility userspace has to disable BTI but it is expected
> that for cases where there are problems which require BTI to be disabled
> it is more likely that it will need to be disabled on a system level.
>
> v2:
> - Add a patch dropping has_interp from arch_adjust_elf_prot()
> - Fix bisection issue with static executables on arm64 in the first
> patch.
>
> Mark Brown (3):
> elf: Allow architectures to parse properties on the main executable
> arm64: Enable BTI for main executable as well as the interpreter
> elf: Remove has_interp property from arch_adjust_elf_prot()
>
> arch/arm64/include/asm/elf.h | 13 ++++++++++---
> arch/arm64/kernel/process.c | 20 +++++++-------------
> fs/binfmt_elf.c | 29 ++++++++++++++++++++---------
> include/linux/elf.h | 8 +++++---
> 4 files changed, 42 insertions(+), 28 deletions(-)
>
>
> base-commit: c4681547bcce777daf576925a966ffa824edd09d
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-10 17:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 11:24 [PATCH v2 0/3] arm64: Enable BTI for the executable as well as the interpreter Mark Brown
2021-06-04 11:24 ` [PATCH v2 1/3] elf: Allow architectures to parse properties on the main executable Mark Brown
2021-06-09 15:16 ` Dave Martin
2021-06-10 13:41 ` Mark Brown
2021-06-04 11:24 ` [PATCH v2 2/3] arm64: Enable BTI for main executable as well as the interpreter Mark Brown
2021-06-09 15:17 ` Dave Martin
2021-06-10 13:19 ` Mark Brown
2021-06-10 15:34 ` Dave Martin
2021-06-04 11:24 ` [PATCH v2 3/3] elf: Remove has_interp property from arch_adjust_elf_prot() Mark Brown
2021-06-09 15:17 ` Dave Martin
2021-06-09 16:55 ` Yu, Yu-cheng
2021-06-10 9:58 ` Dave Martin
2021-06-10 18:17 ` Yu, Yu-cheng
2021-06-10 13:34 ` Mark Brown
2021-06-10 15:40 ` Dave Martin
2021-06-10 16:28 ` Jeremy Linton [this message]
2021-06-14 16:00 ` [PATCH v2 0/3] arm64: Enable BTI for the executable as well as the interpreter Mark Brown
2021-06-15 15:22 ` Dave Martin
2021-06-15 15:33 ` Mark Brown
2021-06-15 15:41 ` Dave Martin
2021-06-16 5:12 ` Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43e67d7b-aab9-db1f-f74b-a87ba7442d47@arm.com \
--to=jeremy.linton@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dave.martin@arm.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=szabolcs.nagy@arm.com \
--cc=will@kernel.org \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).