* [PATCH v2] dt-bindings: mxsfb: Document i.MX8M power-domains property
@ 2022-12-12 5:14 Marek Vasut
2022-12-12 5:37 ` Liu Ying
0 siblings, 1 reply; 2+ messages in thread
From: Marek Vasut @ 2022-12-12 5:14 UTC (permalink / raw)
To: devicetree
Cc: Marek Vasut, Krzysztof Kozlowski, Fabio Estevam,
Krzysztof Kozlowski, Liu Ying, Lucas Stach, NXP Linux Team,
Rob Herring, Shawn Guo, linux-arm-kernel
The power-domains property is mandatory on i.MX8M Mini, Nano, Plus.
Document the property and mark it as required on the aforementioned
variants of the IP, present in those SoCs.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Liu Ying <victor.liu@nxp.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
To: devicetree@vger.kernel.org
---
V2: - Add AB from Krzysztof
- Add mx6sx power domain into the list
---
.../devicetree/bindings/display/fsl,lcdif.yaml | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
index 876015a44a1e6..d51b4e7957f25 100644
--- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
+++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
@@ -52,6 +52,9 @@ properties:
interrupts:
maxItems: 1
+ power-domains:
+ maxItems: 1
+
port:
$ref: /schemas/graph.yaml#/properties/port
description: The LCDIF output port
@@ -87,6 +90,18 @@ allOf:
maxItems: 1
clock-names:
maxItems: 1
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - fsl,imx6sx-lcdif
+ - fsl,imx8mm-lcdif
+ - fsl,imx8mn-lcdif
+ - fsl,imx8mp-lcdif
+ then:
+ required:
+ - power-domains
examples:
- |
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] dt-bindings: mxsfb: Document i.MX8M power-domains property
2022-12-12 5:14 [PATCH v2] dt-bindings: mxsfb: Document i.MX8M power-domains property Marek Vasut
@ 2022-12-12 5:37 ` Liu Ying
0 siblings, 0 replies; 2+ messages in thread
From: Liu Ying @ 2022-12-12 5:37 UTC (permalink / raw)
To: Marek Vasut, devicetree
Cc: Krzysztof Kozlowski, Fabio Estevam, Krzysztof Kozlowski,
Lucas Stach, NXP Linux Team, Rob Herring, Shawn Guo,
linux-arm-kernel
On Mon, 2022-12-12 at 06:14 +0100, Marek Vasut wrote:
> The power-domains property is mandatory on i.MX8M Mini, Nano, Plus.
> Document the property and mark it as required on the aforementioned
> variants of the IP, present in those SoCs.
Please mention both i.MX6sl and i.MX6sx SoCs in the patch subject and
commit message.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Liu Ying <victor.liu@nxp.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> To: devicetree@vger.kernel.org
> ---
> V2: - Add AB from Krzysztof
> - Add mx6sx power domain into the list
> ---
> .../devicetree/bindings/display/fsl,lcdif.yaml | 15
> +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> index 876015a44a1e6..d51b4e7957f25 100644
> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> @@ -52,6 +52,9 @@ properties:
> interrupts:
> maxItems: 1
>
> + power-domains:
> + maxItems: 1
> +
> port:
> $ref: /schemas/graph.yaml#/properties/port
> description: The LCDIF output port
> @@ -87,6 +90,18 @@ allOf:
> maxItems: 1
> clock-names:
> maxItems: 1
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
As I mentioned in v1 review comment, please add '- fsl,imx6sl-lcdif'
here too?
> + - fsl,imx6sx-lcdif
> + - fsl,imx8mm-lcdif
> + - fsl,imx8mn-lcdif
> + - fsl,imx8mp-lcdif
> + then:
> + required:
> + - power-domains
Now that this is required for i.MX6sx LCDIF, the examples needs to be
updated to add the property for i.MX6sx LCDIF node. Otherwise, 'make
dt_binding_check' would report error I think.
Regards,
Liu Ying
>
> examples:
> - |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-12 5:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-12 5:14 [PATCH v2] dt-bindings: mxsfb: Document i.MX8M power-domains property Marek Vasut
2022-12-12 5:37 ` Liu Ying
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).