* [hisi:next/drivers 5/6] drivers/bus/hisi_lpc.c:656:3: error: implicit declaration of function 'hisi_lpc_acpi_remove'; did you mean 'hisi_lpc_acpi_probe'?
@ 2019-07-01 4:23 kbuild test robot
2019-07-11 12:11 ` John Garry
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2019-07-01 4:23 UTC (permalink / raw)
To: John Garry; +Cc: Wei Xu, kbuild-all, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1845 bytes --]
tree: https://github.com/hisilicon/linux-hisi next/drivers
head: 07c811af1c00d7b4212eac86900b023b6405a954
commit: 0c4222bbba45e475d680037bbd9398420ce5d9c6 [5/6] bus: hisi_lpc: Add .remove method to avoid driver unbind crash
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 0c4222bbba45e475d680037bbd9398420ce5d9c6
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/bus/hisi_lpc.c: In function 'hisi_lpc_remove':
>> drivers/bus/hisi_lpc.c:656:3: error: implicit declaration of function 'hisi_lpc_acpi_remove'; did you mean 'hisi_lpc_acpi_probe'? [-Werror=implicit-function-declaration]
hisi_lpc_acpi_remove(dev);
^~~~~~~~~~~~~~~~~~~~
hisi_lpc_acpi_probe
cc1: some warnings being treated as errors
vim +656 drivers/bus/hisi_lpc.c
647
648 static int hisi_lpc_remove(struct platform_device *pdev)
649 {
650 struct device *dev = &pdev->dev;
651 struct acpi_device *acpi_device = ACPI_COMPANION(dev);
652 struct hisi_lpc_dev *lpcdev = dev_get_drvdata(dev);
653 struct logic_pio_hwaddr *range = lpcdev->io_host;
654
655 if (acpi_device)
> 656 hisi_lpc_acpi_remove(dev);
657 else
658 of_platform_depopulate(dev);
659
660 logic_pio_unregister_range(range);
661
662 return 0;
663 }
664
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65718 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [hisi:next/drivers 5/6] drivers/bus/hisi_lpc.c:656:3: error: implicit declaration of function 'hisi_lpc_acpi_remove'; did you mean 'hisi_lpc_acpi_probe'?
2019-07-01 4:23 [hisi:next/drivers 5/6] drivers/bus/hisi_lpc.c:656:3: error: implicit declaration of function 'hisi_lpc_acpi_remove'; did you mean 'hisi_lpc_acpi_probe'? kbuild test robot
@ 2019-07-11 12:11 ` John Garry
0 siblings, 0 replies; 2+ messages in thread
From: John Garry @ 2019-07-11 12:11 UTC (permalink / raw)
To: kbuild test robot; +Cc: olof, Wei Xu, arnd, kbuild-all, linux-arm-kernel
在 01/07/2019 12:23, kbuild test robot 写道:
> tree: https://github.com/hisilicon/linux-hisi next/drivers
> head: 07c811af1c00d7b4212eac86900b023b6405a954
> commit: 0c4222bbba45e475d680037bbd9398420ce5d9c6 [5/6] bus: hisi_lpc: Add .remove method to avoid driver unbind crash
> config: arm64-allyesconfig (attached as .config)
> compiler: aarch64-linux-gcc (GCC) 7.4.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 0c4222bbba45e475d680037bbd9398420ce5d9c6
> # save the attached .config to linux build tree
> GCC_VERSION=7.4.0 make.cross ARCH=arm64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> drivers/bus/hisi_lpc.c: In function 'hisi_lpc_remove':
>>> drivers/bus/hisi_lpc.c:656:3: error: implicit declaration of function 'hisi_lpc_acpi_remove'; did you mean 'hisi_lpc_acpi_probe'? [-Werror=implicit-function-declaration]
> hisi_lpc_acpi_remove(dev);
> ^~~~~~~~~~~~~~~~~~~~
> hisi_lpc_acpi_probe
> cc1: some warnings being treated as errors
>
> vim +656 drivers/bus/hisi_lpc.c
This code seems to be in linux-next, but Olof said that he dropped the
branch containing the patchset.
John
>
> 647
> 648 static int hisi_lpc_remove(struct platform_device *pdev)
> 649 {
> 650 struct device *dev = &pdev->dev;
> 651 struct acpi_device *acpi_device = ACPI_COMPANION(dev);
> 652 struct hisi_lpc_dev *lpcdev = dev_get_drvdata(dev);
> 653 struct logic_pio_hwaddr *range = lpcdev->io_host;
> 654
> 655 if (acpi_device)
> > 656 hisi_lpc_acpi_remove(dev);
> 657 else
> 658 of_platform_depopulate(dev);
> 659
> 660 logic_pio_unregister_range(range);
> 661
> 662 return 0;
> 663 }
> 664
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-11 12:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-01 4:23 [hisi:next/drivers 5/6] drivers/bus/hisi_lpc.c:656:3: error: implicit declaration of function 'hisi_lpc_acpi_remove'; did you mean 'hisi_lpc_acpi_probe'? kbuild test robot
2019-07-11 12:11 ` John Garry
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).