linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Álvaro Fernández Rojas" <noltari@gmail.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	"Jonas Gorski" <jonas.gorski@gmail.com>,
	"Necip Fazil Yildiran" <fazilyildiran@gmail.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 02/15] gpio: regmap: set gpio_chip of_node
Date: Thu, 04 Mar 2021 18:24:12 +0100	[thread overview]
Message-ID: <4839e31730b22004f1ebe9510d3823ce@walle.cc> (raw)
In-Reply-To: <CAHp75Ve9uW6+kpNmsG2BaaOymoAKXPdebNCfRnxUpAZoQnfZ0Q@mail.gmail.com>

Am 2021-03-04 17:46, schrieb Andy Shevchenko:
> On Thu, Mar 4, 2021 at 6:33 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>> On Thu, Mar 4, 2021 at 5:44 PM Álvaro Fernández Rojas 
>> <noltari@gmail.com> wrote:
> 
> Let me summarize what we can do this independently on any of my
> patches and be okay with.
> 
> In the regmap GPIO configuration you supply struct fwnode_handle 
> *fwnode.
> You can you fwnode API in the actual GPIO controller driver.
> Inside gpio-regmap simply do this for now
> 
> gc->of_node = to_of_node(config->fwnode);

If doing so, can we please have a comment saying that config->fwnode
might be NULL in which case the fwnode of the parent is used?

> The last part is an amendment I have told about, but it can be done
> later on by switching the entire GPIO chip to use fwnode instead of
> of_node.

-- 
-michael

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-04 17:26 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-04  8:56 [PATCH v4 00/15] pinctrl: add BCM63XX pincontrol support Álvaro Fernández Rojas
2021-03-04  8:56 ` [PATCH v4 01/15] gpio: guard gpiochip_irqchip_add_domain() with GPIOLIB_IRQCHIP Álvaro Fernández Rojas
2021-03-04 10:33   ` Andy Shevchenko
2021-03-04 10:36   ` Álvaro Fernández Rojas
2021-03-09 16:20   ` Linus Walleij
2021-03-04  8:56 ` [PATCH v4 02/15] gpio: regmap: set gpio_chip of_node Álvaro Fernández Rojas
2021-03-04 10:35   ` Andy Shevchenko
2021-03-04 15:06     ` Álvaro Fernández Rojas
2021-03-04 15:17       ` Andy Shevchenko
2021-03-04 15:24         ` Álvaro Fernández Rojas
2021-03-04 15:28           ` Andy Shevchenko
2021-03-04 15:44             ` Álvaro Fernández Rojas
2021-03-04 16:33               ` Andy Shevchenko
2021-03-04 16:46                 ` Andy Shevchenko
2021-03-04 17:24                   ` Michael Walle [this message]
2021-03-05  9:44                     ` Andy Shevchenko
2021-03-05  7:45                 ` Álvaro Fernández Rojas
2021-03-05  9:49                   ` Andy Shevchenko
2021-03-04  8:56 ` [PATCH v4 03/15] pinctrl: bcm: add bcm63xx base code Álvaro Fernández Rojas
2021-03-04 10:43   ` Andy Shevchenko
2021-03-04 11:17     ` Álvaro Fernández Rojas
2021-03-04 12:09       ` Andy Shevchenko
2021-03-04 12:28         ` Álvaro Fernández Rojas
2021-03-04 15:19           ` Andy Shevchenko
2021-03-04  8:56 ` [PATCH v4 04/15] Documentation: add BCM6328 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-04 12:53   ` Michael Walle
2021-03-04  8:57 ` [PATCH v4 05/15] pinctrl: add a pincontrol driver for BCM6328 Álvaro Fernández Rojas
2021-03-04 10:49   ` Andy Shevchenko
2021-03-04 11:13     ` Álvaro Fernández Rojas
2021-03-04 12:12       ` Andy Shevchenko
2021-03-04 12:25         ` Álvaro Fernández Rojas
2021-03-04 15:25           ` Andy Shevchenko
2021-03-04 15:33             ` Álvaro Fernández Rojas
2021-03-04 15:36               ` Andy Shevchenko
2021-03-04  8:57 ` [PATCH v4 06/15] Documentation: add BCM6358 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-04  8:57 ` [PATCH v4 07/15] pinctrl: add a pincontrol driver for BCM6358 Álvaro Fernández Rojas
2021-03-04  8:57 ` [PATCH v4 08/15] Documentation: add BCM6362 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-04  8:57 ` [PATCH v4 09/15] pinctrl: add a pincontrol driver for BCM6362 Álvaro Fernández Rojas
2021-03-04  8:57 ` [PATCH v4 10/15] Documentation: add BCM6368 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-04  8:57 ` [PATCH v4 11/15] pinctrl: add a pincontrol driver for BCM6368 Álvaro Fernández Rojas
2021-03-04  8:57 ` [PATCH v4 12/15] Documentation: add BCM63268 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-04  8:57 ` [PATCH v4 13/15] pinctrl: add a pincontrol driver for BCM63268 Álvaro Fernández Rojas
2021-03-04  8:57 ` [PATCH v4 14/15] Documentation: add BCM6318 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-04  8:57 ` [PATCH v4 15/15] pinctrl: add a pincontrol driver for BCM6318 Álvaro Fernández Rojas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4839e31730b22004f1ebe9510d3823ce@walle.cc \
    --to=michael@walle.cc \
    --cc=andy.shevchenko@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=fazilyildiran@gmail.com \
    --cc=jonas.gorski@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noltari@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).