From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Michael Walle <michael@walle.cc>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
Jonas Gorski <jonas.gorski@gmail.com>,
Necip Fazil Yildiran <fazilyildiran@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 05/15] pinctrl: add a pincontrol driver for BCM6328
Date: Thu, 4 Mar 2021 12:49:48 +0200 [thread overview]
Message-ID: <CAHp75Vc8Gk0ZVjfQH71-Du1ZB1HT5qrgbT6HZgXQd-C6xE05ZQ@mail.gmail.com> (raw)
In-Reply-To: <20210304085710.7128-6-noltari@gmail.com>
On Thu, Mar 4, 2021 at 10:57 AM Álvaro Fernández Rojas
<noltari@gmail.com> wrote:
>
> Add a pincontrol driver for BCM6328. BCM628 supports muxing 32 pins as
> GPIOs, as LEDs for the integrated LED controller, or various other
> functions. Its pincontrol mux registers also control other aspects, like
> switching the second USB port between host and device mode.
...
> +static inline unsigned int bcm6328_mux_off(unsigned int pin)
> +{
> + static const unsigned int bcm6328_mux[] = {
> + BCM6328_MUX_LO_REG,
> + BCM6328_MUX_HI_REG,
> + BCM6328_MUX_OTHER_REG
When it's not terminator add a comma, otherwise remove a comma.
Also, why is it inside a function? It's anyway global and constant.
> + };
...
> + regmap_update_bits(pc->regs, bcm6328_mux_off(pin),
> + 3UL << ((pin % 16) * 2),
3UL => #define BLABLA GENMASK(1, 0)
> + mux << ((pin % 16) * 2));
...
> +static const struct of_device_id bcm6328_pinctrl_match[] = {
> + { .compatible = "brcm,bcm6328-pinctrl", },
> + { },
No comma.
> +};
Above comments to all your patches.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-04 10:52 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 8:56 [PATCH v4 00/15] pinctrl: add BCM63XX pincontrol support Álvaro Fernández Rojas
2021-03-04 8:56 ` [PATCH v4 01/15] gpio: guard gpiochip_irqchip_add_domain() with GPIOLIB_IRQCHIP Álvaro Fernández Rojas
2021-03-04 10:33 ` Andy Shevchenko
2021-03-04 10:36 ` Álvaro Fernández Rojas
2021-03-09 16:20 ` Linus Walleij
2021-03-04 8:56 ` [PATCH v4 02/15] gpio: regmap: set gpio_chip of_node Álvaro Fernández Rojas
2021-03-04 10:35 ` Andy Shevchenko
2021-03-04 15:06 ` Álvaro Fernández Rojas
2021-03-04 15:17 ` Andy Shevchenko
2021-03-04 15:24 ` Álvaro Fernández Rojas
2021-03-04 15:28 ` Andy Shevchenko
2021-03-04 15:44 ` Álvaro Fernández Rojas
2021-03-04 16:33 ` Andy Shevchenko
2021-03-04 16:46 ` Andy Shevchenko
2021-03-04 17:24 ` Michael Walle
2021-03-05 9:44 ` Andy Shevchenko
2021-03-05 7:45 ` Álvaro Fernández Rojas
2021-03-05 9:49 ` Andy Shevchenko
2021-03-04 8:56 ` [PATCH v4 03/15] pinctrl: bcm: add bcm63xx base code Álvaro Fernández Rojas
2021-03-04 10:43 ` Andy Shevchenko
2021-03-04 11:17 ` Álvaro Fernández Rojas
2021-03-04 12:09 ` Andy Shevchenko
2021-03-04 12:28 ` Álvaro Fernández Rojas
2021-03-04 15:19 ` Andy Shevchenko
2021-03-04 8:56 ` [PATCH v4 04/15] Documentation: add BCM6328 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-04 12:53 ` Michael Walle
2021-03-04 8:57 ` [PATCH v4 05/15] pinctrl: add a pincontrol driver for BCM6328 Álvaro Fernández Rojas
2021-03-04 10:49 ` Andy Shevchenko [this message]
2021-03-04 11:13 ` Álvaro Fernández Rojas
2021-03-04 12:12 ` Andy Shevchenko
2021-03-04 12:25 ` Álvaro Fernández Rojas
2021-03-04 15:25 ` Andy Shevchenko
2021-03-04 15:33 ` Álvaro Fernández Rojas
2021-03-04 15:36 ` Andy Shevchenko
2021-03-04 8:57 ` [PATCH v4 06/15] Documentation: add BCM6358 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-04 8:57 ` [PATCH v4 07/15] pinctrl: add a pincontrol driver for BCM6358 Álvaro Fernández Rojas
2021-03-04 8:57 ` [PATCH v4 08/15] Documentation: add BCM6362 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-04 8:57 ` [PATCH v4 09/15] pinctrl: add a pincontrol driver for BCM6362 Álvaro Fernández Rojas
2021-03-04 8:57 ` [PATCH v4 10/15] Documentation: add BCM6368 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-04 8:57 ` [PATCH v4 11/15] pinctrl: add a pincontrol driver for BCM6368 Álvaro Fernández Rojas
2021-03-04 8:57 ` [PATCH v4 12/15] Documentation: add BCM63268 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-04 8:57 ` [PATCH v4 13/15] pinctrl: add a pincontrol driver for BCM63268 Álvaro Fernández Rojas
2021-03-04 8:57 ` [PATCH v4 14/15] Documentation: add BCM6318 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-04 8:57 ` [PATCH v4 15/15] pinctrl: add a pincontrol driver for BCM6318 Álvaro Fernández Rojas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vc8Gk0ZVjfQH71-Du1ZB1HT5qrgbT6HZgXQd-C6xE05ZQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=fazilyildiran@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=noltari@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).