From: Marek Vasut <marex@denx.de>
To: Teresa Remmet <T.Remmet@phytec.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Cc: "aisheng.dong@nxp.com" <aisheng.dong@nxp.com>,
"peng.fan@nxp.com" <peng.fan@nxp.com>, "hs@denx.de" <hs@denx.de>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-imx@nxp.com" <linux-imx@nxp.com>
Subject: Re: [PATCH 2/2] arm64: dts: freescale: Add support EQOS MAC on phyBOARD-Pollux-i.MX8MP
Date: Sun, 28 Feb 2021 22:14:15 +0100 [thread overview]
Message-ID: <4b4a2ea9-eb41-d1cf-e7cb-a8f17b3429a9@denx.de> (raw)
In-Reply-To: <f06b614808941c7c91741ba1da2d9599498ba2ee.camel@phytec.de>
On 2/17/21 9:17 PM, Teresa Remmet wrote:
> Hello Marek,
Hello Teresa,
> Am Dienstag, den 16.02.2021, 10:38 +0100 schrieb Marek Vasut:
>> The board has both MACs routed out, enable the EQOS.
[...]
>> --- a/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
>> @@ -38,6 +38,30 @@
>> cpu-supply = <&buck2>;
>> };
>>
>> +&eqos {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_eqos>;
>> + phy-mode = "rgmii-id";
>> + phy-handle = <ðphy0>;
>> + status = "okay";
>> +
>> + mdio {
>> + compatible = "snps,dwmac-mdio";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + ethphy0: ethernet-phy@1 {
>> + compatible = "ethernet-phy-ieee802.3-c22";
>> + reg = <0x1>;
>> + ti,rx-internal-delay =
>> <DP83867_RGMIIDCTL_1_50_NS>;
>> + ti,tx-internal-delay =
>> <DP83867_RGMIIDCTL_1_50_NS>;
>> + ti,fifo-depth =
>> <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
>> + ti,clk-output-sel = <DP83867_CLK_O_SEL_OFF>;
>> + enet-phy-lane-no-swap;
>> + };
>> + };
>> +};
>
> I would prefer having this added to imx8mp-phyboard-pollux-rdk.dts.
> The phy of eqos is populated on the carrier board and not on the SoM.
> Boards using the same SoM should not need to patch in the imx8mp-phycore-som.dtsi
> to make it fit for their selected phy.
All right, V2 is coming soon.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-02-28 21:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 9:38 [PATCH 1/2] arm64: dts: imx8mp: add eqos node and alias Marek Vasut
2021-02-16 9:38 ` [PATCH 2/2] arm64: dts: freescale: Add support EQOS MAC on phyBOARD-Pollux-i.MX8MP Marek Vasut
2021-02-17 20:17 ` Teresa Remmet
2021-02-28 21:14 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b4a2ea9-eb41-d1cf-e7cb-a8f17b3429a9@denx.de \
--to=marex@denx.de \
--cc=T.Remmet@phytec.de \
--cc=aisheng.dong@nxp.com \
--cc=hs@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=peng.fan@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).