* [PATCH] arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box
@ 2019-09-29 3:22 Vivek Unune
2019-09-29 11:22 ` Vicente Bergas
2019-10-10 21:30 ` Heiko Stuebner
0 siblings, 2 replies; 7+ messages in thread
From: Vivek Unune @ 2019-09-29 3:22 UTC (permalink / raw)
To: robh+dt, mark.rutland, heiko, ezequiel, vicencb, akash
Cc: devicetree, Vivek Unune, linux-kernel, linux-arm-kernel, linux-rockchip
Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
Signed-off-by: Vivek Unune <npcomplete13@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
index 0d1f5f9a0de9..c133e8d64b2a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
@@ -644,7 +644,7 @@
status = "okay";
u2phy0_host: host-port {
- phy-supply = <&vcc5v0_host>;
+ phy-supply = <&vcc5v0_typec>;
status = "okay";
};
@@ -712,7 +712,7 @@
&usbdrd_dwc3_0 {
status = "okay";
- dr_mode = "otg";
+ dr_mode = "host";
};
&usbdrd3_1 {
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box
2019-09-29 3:22 [PATCH] arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box Vivek Unune
@ 2019-09-29 11:22 ` Vicente Bergas
2019-09-29 23:46 ` Vivek Unune
2019-10-10 21:30 ` Heiko Stuebner
1 sibling, 1 reply; 7+ messages in thread
From: Vicente Bergas @ 2019-09-29 11:22 UTC (permalink / raw)
To: Vivek Unune
Cc: mark.rutland, devicetree, heiko, Felipe Balbi, Felipe Balbi,
linux-kernel, linux-rockchip, robh+dt, akash, ezequiel,
linux-arm-kernel, Roger Quadros
On Sunday, September 29, 2019 5:22:30 AM CEST, Vivek Unune wrote:
> Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
>
> Signed-off-by: Vivek Unune <npcomplete13@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> index 0d1f5f9a0de9..c133e8d64b2a 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> @@ -644,7 +644,7 @@
> status = "okay";
>
> u2phy0_host: host-port {
> - phy-supply = <&vcc5v0_host>;
> + phy-supply = <&vcc5v0_typec>;
> status = "okay";
> };
>
> @@ -712,7 +712,7 @@
>
> &usbdrd_dwc3_0 {
> status = "okay";
> - dr_mode = "otg";
> + dr_mode = "host";
> };
>
> &usbdrd3_1 {
Hi Vivek,
which is the relationship of your patch and this commit:
e1d9149e8389f1690cdd4e4056766dd26488a0fe
arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire
with respect to this other commit:
c09b73cfac2a9317f1104169045c519c6021aa1d
usb: dwc3: don't set gadget->is_otg flag
?
I did not test reverting e1d9149e since c09b73cf was applied.
Regards,
Vicenç.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box
2019-09-29 11:22 ` Vicente Bergas
@ 2019-09-29 23:46 ` Vivek Unune
2019-10-04 21:45 ` Heiko Stuebner
0 siblings, 1 reply; 7+ messages in thread
From: Vivek Unune @ 2019-09-29 23:46 UTC (permalink / raw)
To: Vicente Bergas
Cc: mark.rutland, devicetree, heiko, Felipe Balbi, Felipe Balbi,
linux-kernel, linux-rockchip, robh+dt, akash, ezequiel,
linux-arm-kernel, Roger Quadros
On Sun, Sep 29, 2019 at 01:22:17PM +0200, Vicente Bergas wrote:
> On Sunday, September 29, 2019 5:22:30 AM CEST, Vivek Unune wrote:
> > Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
> >
> > Signed-off-by: Vivek Unune <npcomplete13@gmail.com>
> > ---
> > arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > index 0d1f5f9a0de9..c133e8d64b2a 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > @@ -644,7 +644,7 @@
> > status = "okay";
> > u2phy0_host: host-port {
> > - phy-supply = <&vcc5v0_host>;
> > + phy-supply = <&vcc5v0_typec>;
> > status = "okay";
> > };
> > @@ -712,7 +712,7 @@
> > &usbdrd_dwc3_0 {
> > status = "okay";
> > - dr_mode = "otg";
> > + dr_mode = "host";
> > };
> > &usbdrd3_1 {
>
> Hi Vivek,
>
> which is the relationship of your patch and this commit:
>
> e1d9149e8389f1690cdd4e4056766dd26488a0fe
> arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire
>
> with respect to this other commit:
>
> c09b73cfac2a9317f1104169045c519c6021aa1d
> usb: dwc3: don't set gadget->is_otg flag
>
> ?
>
> I did not test reverting e1d9149e since c09b73cf was applied.
>
> Regards,
> Vicenç.
>
Hi Vicenç,
Indeed, I was motivated by e1d9149e ("arm64: dts: rockchip: Fix USB3
Type-C on rk3399-sapphire"). X99 TV box showed exact same symptoms
with usb-c port. After applying the fix, it worked.
I was not aware of c09b73cf ("usb: dwc3: don't set gadget->is_otg
flag") and it will be interesting to test it. This might render
my fix unecessary.
Thanks,
Vivek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box
2019-09-29 23:46 ` Vivek Unune
@ 2019-10-04 21:45 ` Heiko Stuebner
2019-10-05 0:52 ` Vivek Unune
0 siblings, 1 reply; 7+ messages in thread
From: Heiko Stuebner @ 2019-10-04 21:45 UTC (permalink / raw)
To: Vivek Unune
Cc: mark.rutland, devicetree, Felipe Balbi, Felipe Balbi,
linux-kernel, Vicente Bergas, linux-rockchip, robh+dt, akash,
ezequiel, linux-arm-kernel, Roger Quadros
Hi Vivek,
Am Montag, 30. September 2019, 01:46:15 CEST schrieb Vivek Unune:
> On Sun, Sep 29, 2019 at 01:22:17PM +0200, Vicente Bergas wrote:
> > On Sunday, September 29, 2019 5:22:30 AM CEST, Vivek Unune wrote:
> > > Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
> > >
> > > Signed-off-by: Vivek Unune <npcomplete13@gmail.com>
> > > ---
> > > arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > index 0d1f5f9a0de9..c133e8d64b2a 100644
> > > --- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > @@ -644,7 +644,7 @@
> > > status = "okay";
> > > u2phy0_host: host-port {
> > > - phy-supply = <&vcc5v0_host>;
> > > + phy-supply = <&vcc5v0_typec>;
> > > status = "okay";
> > > };
> > > @@ -712,7 +712,7 @@
> > > &usbdrd_dwc3_0 {
> > > status = "okay";
> > > - dr_mode = "otg";
> > > + dr_mode = "host";
> > > };
> > > &usbdrd3_1 {
> >
> > Hi Vivek,
> >
> > which is the relationship of your patch and this commit:
> >
> > e1d9149e8389f1690cdd4e4056766dd26488a0fe
> > arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire
> >
> > with respect to this other commit:
> >
> > c09b73cfac2a9317f1104169045c519c6021aa1d
> > usb: dwc3: don't set gadget->is_otg flag
> >
> > ?
> >
> > I did not test reverting e1d9149e since c09b73cf was applied.
> >
> > Regards,
> > Vicenç.
> >
>
> Hi Vicenç,
>
> Indeed, I was motivated by e1d9149e ("arm64: dts: rockchip: Fix USB3
> Type-C on rk3399-sapphire"). X99 TV box showed exact same symptoms
> with usb-c port. After applying the fix, it worked.
>
> I was not aware of c09b73cf ("usb: dwc3: don't set gadget->is_otg
> flag") and it will be interesting to test it. This might render
> my fix unecessary.
So I'll let this patch sit here for now.
Once you've done the testing, can you please respond with the
result (both positive and negative results please).
Thanks
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box
2019-10-04 21:45 ` Heiko Stuebner
@ 2019-10-05 0:52 ` Vivek Unune
2019-10-06 19:50 ` Vicente Bergas
0 siblings, 1 reply; 7+ messages in thread
From: Vivek Unune @ 2019-10-05 0:52 UTC (permalink / raw)
To: Heiko Stuebner
Cc: mark.rutland, devicetree, Felipe Balbi, Felipe Balbi,
linux-kernel, Vicente Bergas, linux-rockchip, robh+dt, akash,
ezequiel, linux-arm-kernel, Roger Quadros
On Fri, Oct 04, 2019 at 11:45:08PM +0200, Heiko Stuebner wrote:
> Hi Vivek,
>
> Am Montag, 30. September 2019, 01:46:15 CEST schrieb Vivek Unune:
> > On Sun, Sep 29, 2019 at 01:22:17PM +0200, Vicente Bergas wrote:
> > > On Sunday, September 29, 2019 5:22:30 AM CEST, Vivek Unune wrote:
> > > > Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
> > > >
> > > > Signed-off-by: Vivek Unune <npcomplete13@gmail.com>
> > > > ---
> > > > arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > > b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > > index 0d1f5f9a0de9..c133e8d64b2a 100644
> > > > --- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > > @@ -644,7 +644,7 @@
> > > > status = "okay";
> > > > u2phy0_host: host-port {
> > > > - phy-supply = <&vcc5v0_host>;
> > > > + phy-supply = <&vcc5v0_typec>;
> > > > status = "okay";
> > > > };
> > > > @@ -712,7 +712,7 @@
> > > > &usbdrd_dwc3_0 {
> > > > status = "okay";
> > > > - dr_mode = "otg";
> > > > + dr_mode = "host";
> > > > };
> > > > &usbdrd3_1 {
> > >
> > > Hi Vivek,
> > >
> > > which is the relationship of your patch and this commit:
> > >
> > > e1d9149e8389f1690cdd4e4056766dd26488a0fe
> > > arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire
> > >
> > > with respect to this other commit:
> > >
> > > c09b73cfac2a9317f1104169045c519c6021aa1d
> > > usb: dwc3: don't set gadget->is_otg flag
> > >
> > > ?
> > >
> > > I did not test reverting e1d9149e since c09b73cf was applied.
> > >
> > > Regards,
> > > Vicenç.
> > >
> >
> > Hi Vicenç,
> >
> > Indeed, I was motivated by e1d9149e ("arm64: dts: rockchip: Fix USB3
> > Type-C on rk3399-sapphire"). X99 TV box showed exact same symptoms
> > with usb-c port. After applying the fix, it worked.
> >
> > I was not aware of c09b73cf ("usb: dwc3: don't set gadget->is_otg
> > flag") and it will be interesting to test it. This might render
> > my fix unecessary.
>
> So I'll let this patch sit here for now.
> Once you've done the testing, can you please respond with the
> result (both positive and negative results please).
>
> Thanks
> Heiko
>
>
Hi Heiko,
I tested the c09b73cf patch without modifying exsisting dts. I can confirm
that that patch doesn't work for me. No usb-c devices were recognized.
Vicenç - were you able to test it?
As soon as I apply dts patch, usb-c devices are recognized.
Thanks,
Vivek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box
2019-10-05 0:52 ` Vivek Unune
@ 2019-10-06 19:50 ` Vicente Bergas
0 siblings, 0 replies; 7+ messages in thread
From: Vicente Bergas @ 2019-10-06 19:50 UTC (permalink / raw)
To: Vivek Unune
Cc: mark.rutland, devicetree, Heiko Stuebner, Felipe Balbi,
Felipe Balbi, linux-kernel, linux-rockchip, robh+dt, akash,
ezequiel, linux-arm-kernel, Roger Quadros
On Saturday, October 5, 2019 2:52:00 AM CEST, Vivek Unune wrote:
> On Fri, Oct 04, 2019 at 11:45:08PM +0200, Heiko Stuebner wrote:
>> Hi Vivek,
>>
>> Am Montag, 30. September 2019, 01:46:15 CEST schrieb Vivek Unune: ...
>
> Hi Heiko,
>
> I tested the c09b73cf patch without modifying exsisting dts. I can confirm
> that that patch doesn't work for me. No usb-c devices were recognized.
>
> Vicenç - were you able to test it?
I can also confirm that
c09b73cfac2a9317f1104169045c519c6021aa1d
usb: dwc3: don't set gadget->is_otg flag
alone does not fix the issue.
e1d9149e8389f1690cdd4e4056766dd26488a0fe
arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire
is still required for the USB-C to work on the Sapphire board.
Regards,
Vicenç.
> As soon as I apply dts patch, usb-c devices are recognized.
>
> Thanks,
>
> Vivek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box
2019-09-29 3:22 [PATCH] arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box Vivek Unune
2019-09-29 11:22 ` Vicente Bergas
@ 2019-10-10 21:30 ` Heiko Stuebner
1 sibling, 0 replies; 7+ messages in thread
From: Heiko Stuebner @ 2019-10-10 21:30 UTC (permalink / raw)
To: Vivek Unune
Cc: mark.rutland, devicetree, linux-kernel, vicencb, linux-rockchip,
robh+dt, akash, ezequiel, linux-arm-kernel
Am Sonntag, 29. September 2019, 05:22:30 CEST schrieb Vivek Unune:
> Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
>
> Signed-off-by: Vivek Unune <npcomplete13@gmail.com>
applied as fix for 5.4
Thanks
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-10-10 21:31 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-29 3:22 [PATCH] arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box Vivek Unune
2019-09-29 11:22 ` Vicente Bergas
2019-09-29 23:46 ` Vivek Unune
2019-10-04 21:45 ` Heiko Stuebner
2019-10-05 0:52 ` Vivek Unune
2019-10-06 19:50 ` Vicente Bergas
2019-10-10 21:30 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).