* [PATCH] fix usb2 on rock64
@ 2019-03-08 7:35 Dan Johansen
2019-03-08 10:48 ` Tomohiro Mayama
0 siblings, 1 reply; 3+ messages in thread
From: Dan Johansen @ 2019-03-08 7:35 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-rockchip
From 5d027bc9dc27b7bb46268e2f92e853368e5f097f Mon Sep 17 00:00:00 2001
From: Strit <strit@manjaro.org>
Date: Tue, 5 Mar 2019 16:35:48 +0100
Subject: [PATCH] fix usb2 port on rock64
Fix the issue with usb not getting power on the rock64 board from
pine64.org.
Signed-off-by: Dan Johansen <strit@manjaro.org>
---
arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
index 040b36ef0dd2..4877eb1c095a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
@@ -47,7 +47,7 @@
vcc_host1_5v: vcc_otg_5v: vcc-host1-5v-regulator {
compatible = "regulator-fixed";
enable-active-high;
- gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
+ gpio = <&gpio0 RK_PD3 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&usb20_host_drv>;
regulator-name = "vcc_host1_5v";
@@ -266,7 +266,7 @@
usb2 {
usb20_host_drv: usb20-host-drv {
- rockchip,pins = <0 RK_PA2 RK_FUNC_GPIO &pcfg_pull_none>;
+ rockchip,pins = <0 RK_PD3 RK_FUNC_GPIO &pcfg_pull_none>;
};
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fix usb2 on rock64
2019-03-08 7:35 [PATCH] fix usb2 on rock64 Dan Johansen
@ 2019-03-08 10:48 ` Tomohiro Mayama
2019-08-23 9:56 ` Dan Johansen
0 siblings, 1 reply; 3+ messages in thread
From: Tomohiro Mayama @ 2019-03-08 10:48 UTC (permalink / raw)
To: strit, linux-arm-kernel; +Cc: linux-rockchip
Hello Dan,
On 2019/03/08 16:35, Dan Johansen wrote:
> - gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
> + gpio = <&gpio0 RK_PD3 GPIO_ACTIVE_HIGH>;
According to Robin's advice by reading the schematic, correct GPIO pin
assignment is RK_PA2, but GPIO_ACTIVE_LOW. This fixed the USB problem
for me.
Please see the following thread:
https://lists.infradead.org/pipermail/linux-rockchip/2019-March/023298.html
Also please see this patch:
https://lists.infradead.org/pipermail/linux-rockchip/2019-March/023300.html
Or won't your problem be fixed with this patch?
Regards,
Tomohiro
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix usb2 on rock64
2019-03-08 10:48 ` Tomohiro Mayama
@ 2019-08-23 9:56 ` Dan Johansen
0 siblings, 0 replies; 3+ messages in thread
From: Dan Johansen @ 2019-08-23 9:56 UTC (permalink / raw)
To: Tomohiro Mayama; +Cc: linux-rockchip, linux-arm-kernel
Tomohiro Mayama skrev den 2019-03-08 11:48:
> Hello Dan,
>
> On 2019/03/08 16:35, Dan Johansen wrote:
>> - gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
>> + gpio = <&gpio0 RK_PD3 GPIO_ACTIVE_HIGH>;
>
> According to Robin's advice by reading the schematic, correct GPIO pin
> assignment is RK_PA2, but GPIO_ACTIVE_LOW. This fixed the USB problem
> for me.
>
> Please see the following thread:
> https://lists.infradead.org/pipermail/linux-rockchip/2019-March/023298.html
>
> Also please see this patch:
> https://lists.infradead.org/pipermail/linux-rockchip/2019-March/023300.html
>
> Or won't your problem be fixed with this patch?
>
> Regards,
> Tomohiro
Ah, didn't see that one.
Yes it does.
Sorry. Please remove this patch submission.
--
Sincerely
Dan "Strit" Johansen
Project Lead on the Manjaro ARM project
https://www.manjaro.org
Catch me on:
Mastodon: @strit@mastodon.social
Matrix: @strit:matrix.org
Wire: @strit
Email: strit@manjaro.org
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-23 10:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-08 7:35 [PATCH] fix usb2 on rock64 Dan Johansen
2019-03-08 10:48 ` Tomohiro Mayama
2019-08-23 9:56 ` Dan Johansen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).