From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org,
agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, ping.bai@nxp.com,
aford173@gmail.com, abel.vesa@nxp.com,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V2 03/13] soc: imx: gpcv2: switch to clk_bulk_* API
Date: Thu, 6 May 2021 08:30:10 +0200 [thread overview]
Message-ID: <4e810413-84c8-f04d-45c4-9eabcca2dab0@kontron.de> (raw)
In-Reply-To: <20210506010440.7016-4-peng.fan@oss.nxp.com>
On 06.05.21 03:04, Peng Fan (OSS) wrote:
> From: Lucas Stach <l.stach@pengutronix.de>
>
> Use clk_bulk API to simplify the code a bit. Also add some error
> checking to the clk_prepare_enable calls.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> ---
> drivers/soc/imx/gpcv2.c | 60 +++++++++--------------------------------
> 1 file changed, 12 insertions(+), 48 deletions(-)
>
> diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
> index 552d3e6bee52..4222b6e87e7c 100644
> --- a/drivers/soc/imx/gpcv2.c
> +++ b/drivers/soc/imx/gpcv2.c
> @@ -100,13 +100,11 @@
>
> #define GPC_PGC_CTRL_PCR BIT(0)
>
> -#define GPC_CLK_MAX 6
> -
> struct imx_pgc_domain {
> struct generic_pm_domain genpd;
> struct regmap *regmap;
> struct regulator *regulator;
> - struct clk *clk[GPC_CLK_MAX];
> + struct clk_bulk_data *clks;
> int num_clks;
>
> unsigned int pgc;
> @@ -149,8 +147,12 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct generic_pm_domain *genpd,
> }
>
> /* Enable reset clocks for all devices in the domain */
> - for (i = 0; i < domain->num_clks; i++)
> - clk_prepare_enable(domain->clk[i]);
> + ret = clk_bulk_prepare_enable(domain->num_clks, domain->clks);
> + if (ret) {
> + dev_err(domain->dev, "failed to enable reset clocks\n");
> + regulator_disable(domain->regulator);
> + return ret;
> + }
>
> if (enable_power_control)
> regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc),
> @@ -187,8 +189,7 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct generic_pm_domain *genpd,
> GPC_PGC_CTRL_PCR, 0);
>
> /* Disable reset clocks for all devices in the domain */
> - for (i = 0; i < domain->num_clks; i++)
> - clk_disable_unprepare(domain->clk[i]);
> + clk_bulk_disable_unprepare(domain->num_clks, domain->clks);
>
> if (has_regulator && !on) {
> int err;
> @@ -438,41 +439,6 @@ static const struct imx_pgc_domain_data imx8m_pgc_domain_data = {
> .reg_access_table = &imx8m_access_table,
> };
>
> -static int imx_pgc_get_clocks(struct imx_pgc_domain *domain)
> -{
> - int i, ret;
> -
> - for (i = 0; ; i++) {
> - struct clk *clk = of_clk_get(domain->dev->of_node, i);
> - if (IS_ERR(clk))
> - break;
> - if (i >= GPC_CLK_MAX) {
> - dev_err(domain->dev, "more than %d clocks\n",
> - GPC_CLK_MAX);
> - ret = -EINVAL;
> - goto clk_err;
> - }
> - domain->clk[i] = clk;
> - }
> - domain->num_clks = i;
> -
> - return 0;
> -
> -clk_err:
> - while (i--)
> - clk_put(domain->clk[i]);
> -
> - return ret;
> -}
> -
> -static void imx_pgc_put_clocks(struct imx_pgc_domain *domain)
> -{
> - int i;
> -
> - for (i = domain->num_clks - 1; i >= 0; i--)
> - clk_put(domain->clk[i]);
> -}
> -
> static int imx_pgc_domain_probe(struct platform_device *pdev)
> {
> struct imx_pgc_domain *domain = pdev->dev.platform_data;
> @@ -490,9 +456,10 @@ static int imx_pgc_domain_probe(struct platform_device *pdev)
> domain->voltage, domain->voltage);
> }
>
> - ret = imx_pgc_get_clocks(domain);
> - if (ret)
> - return dev_err_probe(domain->dev, ret, "Failed to get domain's clocks\n");
> + domain->num_clks = devm_clk_bulk_get_all(domain->dev, &domain->clks);
> + if (domain->num_clks < 0)
> + return dev_err_probe(domain->dev, domain->num_clks,
> + "Failed to get domain's clocks\n");
>
> regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING,
> domain->bits.map, domain->bits.map);
> @@ -517,7 +484,6 @@ static int imx_pgc_domain_probe(struct platform_device *pdev)
> out_domain_unmap:
> regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING,
> domain->bits.map, 0);
> - imx_pgc_put_clocks(domain);
>
> return ret;
> }
> @@ -532,8 +498,6 @@ static int imx_pgc_domain_remove(struct platform_device *pdev)
> regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING,
> domain->bits.map, 0);
>
> - imx_pgc_put_clocks(domain);
> -
> return 0;
> }
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-06 6:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 1:04 [PATCH V2 00/13] soc: imx: gpcv2: support i.MX8MM Peng Fan (OSS)
2021-05-06 1:04 ` [PATCH V2 01/13] soc: imx: gpcv2: move to more ideomatic error handling in probe Peng Fan (OSS)
2021-05-06 1:04 ` [PATCH V2 02/13] soc: imx: gpcv2: move domain mapping to domain driver probe Peng Fan (OSS)
2021-05-06 1:04 ` [PATCH V2 03/13] soc: imx: gpcv2: switch to clk_bulk_* API Peng Fan (OSS)
2021-05-06 6:30 ` Frieder Schrempf [this message]
2021-05-06 1:04 ` [PATCH V2 04/13] soc: imx: gpcv2: split power up and power down sequence control Peng Fan (OSS)
2021-05-06 6:36 ` Frieder Schrempf
2021-05-06 1:04 ` [PATCH V2 05/13] soc: imx: gpcv2: wait for ADB400 handshake Peng Fan (OSS)
2021-05-06 1:04 ` [PATCH V2 06/13] soc: imx: gpcv2: add runtime PM support for power-domains Peng Fan (OSS)
2021-05-06 1:04 ` [PATCH V2 07/13] soc: imx: gpcv2: allow domains without power-sequence control Peng Fan (OSS)
2021-05-06 1:04 ` [PATCH V2 08/13] dt-bindings: imx: gpcv2: add support for optional resets Peng Fan (OSS)
2021-05-06 6:43 ` Frieder Schrempf
2021-05-07 21:16 ` Rob Herring
2021-05-08 0:50 ` Peng Fan
2021-05-06 1:04 ` [PATCH V2 09/13] soc: " Peng Fan (OSS)
2021-05-06 1:04 ` [PATCH V2 10/13] dt-bindings: power: add defines for i.MX8MM power domains Peng Fan (OSS)
2021-05-06 1:04 ` [PATCH V2 11/13] soc: imx: gpcv2: add support " Peng Fan (OSS)
2021-05-06 1:04 ` [PATCH V2 12/13] soc: imx: gpcv2: Add support for missing i.MX8MM VPU/DISPMIX " Peng Fan (OSS)
2021-05-06 1:04 ` [PATCH V2 13/13] soc: imx: gpcv2: move reset assert after requesting domain power up Peng Fan (OSS)
2021-05-06 6:56 ` Frieder Schrempf
2021-05-06 8:32 ` [PATCH V2 00/13] soc: imx: gpcv2: support i.MX8MM Frieder Schrempf
2021-05-19 16:09 ` Frieder Schrempf
2021-05-20 15:16 ` Frieder Schrempf
2021-07-21 20:51 ` Lucas Stach
2021-07-22 6:36 ` Frieder Schrempf
2021-08-04 14:30 ` Ezequiel Garcia
2021-08-09 8:15 ` Lucas Stach
2021-09-03 12:26 ` Benjamin Gaignard
-- strict thread matches above, loose matches on Subject: below --
2020-11-05 17:44 [PATCH v2 00/13] i.MX8MM power domain support Lucas Stach
2020-11-05 17:44 ` [PATCH v2 03/13] soc: imx: gpcv2: switch to clk_bulk_* API Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e810413-84c8-f04d-45c4-9eabcca2dab0@kontron.de \
--to=frieder.schrempf@kontron.de \
--cc=abel.vesa@nxp.com \
--cc=aford173@gmail.com \
--cc=agx@sigxcpu.org \
--cc=andrew.smirnov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).