* [PATCH -next] soc: bcm: bcm2835-pm: Make local symbol static
@ 2019-01-16 5:44 Wei Yongjun
2019-01-16 18:06 ` Scott Branden
2019-02-01 5:06 ` Florian Fainelli
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2019-01-16 5:44 UTC (permalink / raw)
To: Eric Anholt, Stefan Wahren, Florian Fainelli, Ray Jui,
Scott Branden, Rob Herring
Cc: kernel-janitors, linux-kernel, bcm-kernel-feedback-list,
linux-rpi-kernel, Wei Yongjun, linux-arm-kernel
Fixes the following sparse warning:
drivers/soc/bcm/bcm2835-power.c:556:32: warning:
symbol 'bcm2835_reset_ops' was not declared. Should it be static?
Fixes: 670c672608a1 ("soc: bcm: bcm2835-pm: Add support for power domains under a new binding.")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/soc/bcm/bcm2835-power.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/bcm/bcm2835-power.c b/drivers/soc/bcm/bcm2835-power.c
index 4841295..9351349 100644
--- a/drivers/soc/bcm/bcm2835-power.c
+++ b/drivers/soc/bcm/bcm2835-power.c
@@ -553,7 +553,7 @@ static int bcm2835_reset_status(struct reset_controller_dev *rcdev,
}
}
-const struct reset_control_ops bcm2835_reset_ops = {
+static const struct reset_control_ops bcm2835_reset_ops = {
.reset = bcm2835_reset_reset,
.status = bcm2835_reset_status,
};
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] soc: bcm: bcm2835-pm: Make local symbol static
2019-01-16 5:44 [PATCH -next] soc: bcm: bcm2835-pm: Make local symbol static Wei Yongjun
@ 2019-01-16 18:06 ` Scott Branden
2019-02-01 5:06 ` Florian Fainelli
1 sibling, 0 replies; 3+ messages in thread
From: Scott Branden @ 2019-01-16 18:06 UTC (permalink / raw)
To: Wei Yongjun, Eric Anholt, Stefan Wahren, Florian Fainelli,
Ray Jui, Scott Branden, Rob Herring
Cc: kernel-janitors, bcm-kernel-feedback-list, linux-rpi-kernel,
linux-arm-kernel, linux-kernel
Looks good.
On 2019-01-15 9:44 p.m., Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/soc/bcm/bcm2835-power.c:556:32: warning:
> symbol 'bcm2835_reset_ops' was not declared. Should it be static?
>
> Fixes: 670c672608a1 ("soc: bcm: bcm2835-pm: Add support for power domains under a new binding.")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
> drivers/soc/bcm/bcm2835-power.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/bcm/bcm2835-power.c b/drivers/soc/bcm/bcm2835-power.c
> index 4841295..9351349 100644
> --- a/drivers/soc/bcm/bcm2835-power.c
> +++ b/drivers/soc/bcm/bcm2835-power.c
> @@ -553,7 +553,7 @@ static int bcm2835_reset_status(struct reset_controller_dev *rcdev,
> }
> }
>
> -const struct reset_control_ops bcm2835_reset_ops = {
> +static const struct reset_control_ops bcm2835_reset_ops = {
> .reset = bcm2835_reset_reset,
> .status = bcm2835_reset_status,
> };
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] soc: bcm: bcm2835-pm: Make local symbol static
2019-01-16 5:44 [PATCH -next] soc: bcm: bcm2835-pm: Make local symbol static Wei Yongjun
2019-01-16 18:06 ` Scott Branden
@ 2019-02-01 5:06 ` Florian Fainelli
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2019-02-01 5:06 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Wei Yongjun, Eric Anholt,
Stefan Wahren, Ray Jui,
Scott
Branden, Rob Herring
Cc: kernel-janitors, linux-rpi-kernel, linux-arm-kernel, linux-kernel
On Wed, 16 Jan 2019 05:44:17 +0000, Wei Yongjun <weiyongjun1@huawei.com> wrote:
> Fixes the following sparse warning:
>
> drivers/soc/bcm/bcm2835-power.c:556:32: warning:
> symbol 'bcm2835_reset_ops' was not declared. Should it be static?
>
> Fixes: 670c672608a1 ("soc: bcm: bcm2835-pm: Add support for power domains under a new binding.")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
Applied to drivers/next, thanks!
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-01 5:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-16 5:44 [PATCH -next] soc: bcm: bcm2835-pm: Make local symbol static Wei Yongjun
2019-01-16 18:06 ` Scott Branden
2019-02-01 5:06 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).