From: loic.pallardy@st.com (Loic PALLARDY)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] mfd: db8500-prcmu: get base address from resource
Date: Thu, 21 Mar 2013 21:26:21 +0100 [thread overview]
Message-ID: <514B6CED.2030302@st.com> (raw)
In-Reply-To: <201303211907.49075.arnd@arndb.de>
On 03/21/2013 08:07 PM, Arnd Bergmann wrote:
> On Thursday 21 March 2013, Linus Walleij wrote:
>> On Thu, Mar 21, 2013 at 1:15 PM, Arnd Bergmann<arnd@arndb.de> wrote:
>>
>>> On Thursday 21 March 2013 12:49:11 Linus Walleij wrote:
>>>> -#define PRCM_PLLARM_LOCKP (_PRCMU_BASE + 0x0a8)
>>>> +#define PRCM_PLLARM_LOCKP (prcmu_base + 0x0a8)
>>>> #define PRCM_PLLARM_LOCKP_PRCM_PLLARM_LOCKP3 0x2
>>>
>>> While this is certainly the least invasive way to get rid of _PRCMU_BASE,
>>> it sucks to refer to local variables in macros. How hard would it
>>> be to find all users of these macros and put the prcmu_base addition
>>> there?
>>>
>>> The rest of this patch looks fine to me.
>>
>> Basically I didn't want to disturb Lo?cs work on PRCMU refactoring,
>> but if it is require I can surely do this.
>
> That's probably a good enough reason to leave it alone for now, but we
> should remember to fix it up later.
>
> How about adding a comment in the header so we don't forget about it?
>
I'll prefer to have same way to access all PRCM registers.
prcmu_base should be used only in db8500-prcmu.c file and
db8500-prcmu-regs.h should contain register offset.
Register should be accessed in db8500-prcmu.c file like:
val = readl(prcmu_base + PRCM_XXX);
Linus, I'll propose you a patch derived from prcmu refactoring stuff.
/Loic
> Arnd
next prev parent reply other threads:[~2013-03-21 20:26 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 11:49 [PATCH 0/6] ARM: ux500: first multiplatform series Linus Walleij
2013-03-21 11:49 ` [PATCH 1/6] ARM: ux500: move debugmacro to debug includes Linus Walleij
2013-03-21 12:06 ` Arnd Bergmann
2013-03-21 11:49 ` [PATCH 2/6] clk: ux500: pass clock base adresses in init call Linus Walleij
2013-03-21 12:10 ` Arnd Bergmann
2013-03-21 14:05 ` Ulf Hansson
2013-03-21 17:50 ` Mike Turquette
2013-03-21 11:49 ` [PATCH 3/6] mfd: prcmu: pass a base and size with the early initcall Linus Walleij
2013-03-21 12:11 ` Arnd Bergmann
2013-03-21 14:01 ` Ulf Hansson
2013-03-21 11:49 ` [PATCH 4/6] mfd: db8500-prcmu: get base address from resource Linus Walleij
2013-03-21 12:15 ` Arnd Bergmann
2013-03-21 17:10 ` Linus Walleij
2013-03-21 19:07 ` Arnd Bergmann
2013-03-21 20:26 ` Loic PALLARDY [this message]
2013-03-21 11:49 ` [PATCH 5/6] ARM: ux500: move PRCMU functions into the CPUidle driver Linus Walleij
2013-03-21 12:14 ` Rickard Andersson
2013-03-21 12:30 ` Daniel Lezcano
2013-03-22 8:30 ` Rickard Andersson
2013-03-25 13:44 ` Linus Walleij
2013-03-25 13:58 ` Daniel Lezcano
2013-03-25 14:10 ` Linus Walleij
2013-03-25 14:11 ` Arnd Bergmann
2013-03-25 14:36 ` Linus Walleij
2013-03-25 15:13 ` Arnd Bergmann
2013-03-25 15:48 ` Linus Walleij
2013-03-21 11:49 ` [PATCH 6/6] ARM: ux500: get rid of <mach/[hardware|db8500-regs].h> Linus Walleij
2013-03-21 12:21 ` Arnd Bergmann
2013-03-21 21:51 ` [PATCH 0/9] More ux500 multiplatform stuff Arnd Bergmann
2013-03-21 21:51 ` [PATCH 1/9] ARM: ux500: move mach/msp.h to include/linux/platform_data.h Arnd Bergmann
2013-03-21 21:51 ` [PATCH 2/9] ARM: ux500: split out prcmu initialization Arnd Bergmann
2013-03-21 21:51 ` [PATCH 3/9] ARM: ux500: make irqs.h local to platform Arnd Bergmann
2013-03-21 21:51 ` [PATCH 4/9] ARM: ux500: kill mach/hardware.h some more Arnd Bergmann
2013-03-21 21:51 ` [PATCH 5/9] staging: ste_rmi4: kill platform_data hack Arnd Bergmann
2013-03-25 13:12 ` Linus Walleij
2013-03-25 18:00 ` Greg KH
2013-03-21 21:51 ` [PATCH 6/9] power: pm2301_charger: remove __devinit annotations Arnd Bergmann
2013-03-22 12:14 ` Linus Walleij
2013-03-22 15:16 ` Anton Vorontsov
2013-03-25 3:09 ` Anton Vorontsov
2013-03-21 21:51 ` [PATCH 7/9] ARM: ux500: make remaining headers local Arnd Bergmann
2013-03-21 21:51 ` [PATCH 8/9] ARM: ux500: move to multiplatform Arnd Bergmann
2013-03-21 21:51 ` [PATCH 9/9] ARM: ux500: build hotplug.o for ARMv7-a Arnd Bergmann
2013-03-22 13:21 ` [PATCH 0/9] More ux500 multiplatform stuff Linus Walleij
2013-03-22 13:34 ` Arnd Bergmann
2013-03-22 13:36 ` Linus Walleij
2013-03-22 14:16 ` Arnd Bergmann
2013-03-22 14:39 ` Linus Walleij
2013-03-22 15:25 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514B6CED.2030302@st.com \
--to=loic.pallardy@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).