* [PATCH] drivers: soc: Fix mailbox suspend/resume no irq for IMX SCU
@ 2020-07-06 15:00 Vincenzo Frascino
2020-07-06 15:12 ` Daniel Baluta
2020-07-13 10:03 ` Aisheng Dong
0 siblings, 2 replies; 3+ messages in thread
From: Vincenzo Frascino @ 2020-07-06 15:00 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel
Cc: Fabio Estevam, Sascha Hauer, Jassi Brar, NXP Linux Team,
Pengutronix Kernel Team, vincenzo.frascino, Shawn Guo
imx_mu_suspend_noirq()/imx_mu_resume_noirq() are currently used only
when CONFIG_PM_SLEEP configuration options is enabled. Having it
disabled triggers the following warning at compile time:
drivers/mailbox/imx-mailbox.c:611:12: warning: ‘imx_mu_resume_noirq’
defined but not used [-Wunused-function]
static int imx_mu_resume_noirq(struct device *dev)
drivers/mailbox/imx-mailbox.c:601:12: warning: ‘imx_mu_suspend_noirq’
defined but not used [-Wunused-function]
static int imx_mu_suspend_noirq(struct device *dev)
Make imx_mu_suspend_noirq()/imx_mu_resume_noirq() __maybe_unused to
address the issue.
Cc: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
---
drivers/mailbox/imx-mailbox.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
index 7205b825c8b5..f54f36948414 100644
--- a/drivers/mailbox/imx-mailbox.c
+++ b/drivers/mailbox/imx-mailbox.c
@@ -598,7 +598,7 @@ static const struct of_device_id imx_mu_dt_ids[] = {
};
MODULE_DEVICE_TABLE(of, imx_mu_dt_ids);
-static int imx_mu_suspend_noirq(struct device *dev)
+static int __maybe_unused imx_mu_suspend_noirq(struct device *dev)
{
struct imx_mu_priv *priv = dev_get_drvdata(dev);
@@ -608,7 +608,7 @@ static int imx_mu_suspend_noirq(struct device *dev)
return 0;
}
-static int imx_mu_resume_noirq(struct device *dev)
+static int __maybe_unused imx_mu_resume_noirq(struct device *dev)
{
struct imx_mu_priv *priv = dev_get_drvdata(dev);
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: soc: Fix mailbox suspend/resume no irq for IMX SCU
2020-07-06 15:00 [PATCH] drivers: soc: Fix mailbox suspend/resume no irq for IMX SCU Vincenzo Frascino
@ 2020-07-06 15:12 ` Daniel Baluta
2020-07-13 10:03 ` Aisheng Dong
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Baluta @ 2020-07-06 15:12 UTC (permalink / raw)
To: Vincenzo Frascino, linux-kernel, linux-arm-kernel
Cc: Shawn Guo, Sascha Hauer, Jassi Brar, NXP Linux Team,
Pengutronix Kernel Team, Fabio Estevam
On 06.07.2020 18:00, Vincenzo Frascino wrote:
> imx_mu_suspend_noirq()/imx_mu_resume_noirq() are currently used only
> when CONFIG_PM_SLEEP configuration options is enabled. Having it
> disabled triggers the following warning at compile time:
>
> drivers/mailbox/imx-mailbox.c:611:12: warning: ‘imx_mu_resume_noirq’
> defined but not used [-Wunused-function]
> static int imx_mu_resume_noirq(struct device *dev)
>
> drivers/mailbox/imx-mailbox.c:601:12: warning: ‘imx_mu_suspend_noirq’
> defined but not used [-Wunused-function]
> static int imx_mu_suspend_noirq(struct device *dev)
>
> Make imx_mu_suspend_noirq()/imx_mu_resume_noirq() __maybe_unused to
> address the issue.
>
> Cc: Jassi Brar <jassisinghbrar@gmail.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] drivers: soc: Fix mailbox suspend/resume no irq for IMX SCU
2020-07-06 15:00 [PATCH] drivers: soc: Fix mailbox suspend/resume no irq for IMX SCU Vincenzo Frascino
2020-07-06 15:12 ` Daniel Baluta
@ 2020-07-13 10:03 ` Aisheng Dong
1 sibling, 0 replies; 3+ messages in thread
From: Aisheng Dong @ 2020-07-13 10:03 UTC (permalink / raw)
To: Vincenzo Frascino, linux-kernel, linux-arm-kernel
Cc: Shawn Guo, Sascha Hauer, Jassi Brar, dl-linux-imx,
Pengutronix Kernel Team, Fabio Estevam
> From: Vincenzo Frascino <vincenzo.frascino@arm.com>
> Sent: Monday, July 6, 2020 11:00 PM
>
> imx_mu_suspend_noirq()/imx_mu_resume_noirq() are currently used only
> when CONFIG_PM_SLEEP configuration options is enabled. Having it disabled
> triggers the following warning at compile time:
>
> drivers/mailbox/imx-mailbox.c:611:12: warning: ‘imx_mu_resume_noirq’
> defined but not used [-Wunused-function]
> static int imx_mu_resume_noirq(struct device *dev)
>
> drivers/mailbox/imx-mailbox.c:601:12: warning: ‘imx_mu_suspend_noirq’
> defined but not used [-Wunused-function]
> static int imx_mu_suspend_noirq(struct device *dev)
>
> Make imx_mu_suspend_noirq()/imx_mu_resume_noirq() __maybe_unused to
> address the issue.
>
> Cc: Jassi Brar <jassisinghbrar@gmail.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
There's already a fix:
https://lkml.org/lkml/2020/6/22/1555
Regards
Aisheng
> ---
> drivers/mailbox/imx-mailbox.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> index 7205b825c8b5..f54f36948414 100644
> --- a/drivers/mailbox/imx-mailbox.c
> +++ b/drivers/mailbox/imx-mailbox.c
> @@ -598,7 +598,7 @@ static const struct of_device_id imx_mu_dt_ids[] = { };
> MODULE_DEVICE_TABLE(of, imx_mu_dt_ids);
>
> -static int imx_mu_suspend_noirq(struct device *dev)
> +static int __maybe_unused imx_mu_suspend_noirq(struct device *dev)
> {
> struct imx_mu_priv *priv = dev_get_drvdata(dev);
>
> @@ -608,7 +608,7 @@ static int imx_mu_suspend_noirq(struct device *dev)
> return 0;
> }
>
> -static int imx_mu_resume_noirq(struct device *dev)
> +static int __maybe_unused imx_mu_resume_noirq(struct device *dev)
> {
> struct imx_mu_priv *priv = dev_get_drvdata(dev);
>
> --
> 2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-13 10:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-06 15:00 [PATCH] drivers: soc: Fix mailbox suspend/resume no irq for IMX SCU Vincenzo Frascino
2020-07-06 15:12 ` Daniel Baluta
2020-07-13 10:03 ` Aisheng Dong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).