* [BUG] More select madness - keystone
@ 2014-01-02 17:26 Russell King - ARM Linux
2014-01-02 19:17 ` Santosh Shilimkar
0 siblings, 1 reply; 5+ messages in thread
From: Russell King - ARM Linux @ 2014-01-02 17:26 UTC (permalink / raw)
To: linux-arm-kernel
warning: (ARCH_KEYSTONE && SPI_DAVINCI) selects TI_EDMA which has unmet direct dependencies (DMADEVICES && (ARCH_DAVINCI || ARCH_OMAP || ARCH_KEYSTONE))
This results in the EDMA engine code not being built. Yet another
example of why improper use of the "select" statement is bad news
and leads to broken configurations.
--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
^ permalink raw reply [flat|nested] 5+ messages in thread
* [BUG] More select madness - keystone
2014-01-02 17:26 [BUG] More select madness - keystone Russell King - ARM Linux
@ 2014-01-02 19:17 ` Santosh Shilimkar
2014-01-02 19:37 ` Santosh Shilimkar
0 siblings, 1 reply; 5+ messages in thread
From: Santosh Shilimkar @ 2014-01-02 19:17 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 02 January 2014 12:26 PM, Russell King - ARM Linux wrote:
> warning: (ARCH_KEYSTONE && SPI_DAVINCI) selects TI_EDMA which has unmet direct dependencies (DMADEVICES && (ARCH_DAVINCI || ARCH_OMAP || ARCH_KEYSTONE))
>
> This results in the EDMA engine code not being built. Yet another
> example of why improper use of the "select" statement is bad news
> and leads to broken configurations.
>
Thanks for reporting Russell. Will have a look.
Regards,
Santosh
^ permalink raw reply [flat|nested] 5+ messages in thread
* [BUG] More select madness - keystone
2014-01-02 19:17 ` Santosh Shilimkar
@ 2014-01-02 19:37 ` Santosh Shilimkar
2014-01-08 4:12 ` Sekhar Nori
0 siblings, 1 reply; 5+ messages in thread
From: Santosh Shilimkar @ 2014-01-02 19:37 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 02 January 2014 02:17 PM, Santosh Shilimkar wrote:
> On Thursday 02 January 2014 12:26 PM, Russell King - ARM Linux wrote:
>> warning: (ARCH_KEYSTONE && SPI_DAVINCI) selects TI_EDMA which has unmet direct dependencies (DMADEVICES && (ARCH_DAVINCI || ARCH_OMAP || ARCH_KEYSTONE))
>>
>> This results in the EDMA engine code not being built. Yet another
>> example of why improper use of the "select" statement is bad news
>> and leads to broken configurations.
>>
> Thanks for reporting Russell. Will have a look.
>
Just to be clear for records, the select was introduced before
KEYSTONE support was enabled. As per git blame, it came via commit
b5f1433059 {spi: davici - make davinci select edma}.
Regards,
Santosh
^ permalink raw reply [flat|nested] 5+ messages in thread
* [BUG] More select madness - keystone
2014-01-02 19:37 ` Santosh Shilimkar
@ 2014-01-08 4:12 ` Sekhar Nori
2014-01-08 14:06 ` Santosh Shilimkar
0 siblings, 1 reply; 5+ messages in thread
From: Sekhar Nori @ 2014-01-08 4:12 UTC (permalink / raw)
To: linux-arm-kernel
On Friday 03 January 2014 01:07 AM, Santosh Shilimkar wrote:
> On Thursday 02 January 2014 02:17 PM, Santosh Shilimkar wrote:
>> On Thursday 02 January 2014 12:26 PM, Russell King - ARM Linux wrote:
>>> warning: (ARCH_KEYSTONE && SPI_DAVINCI) selects TI_EDMA which has unmet direct dependencies (DMADEVICES && (ARCH_DAVINCI || ARCH_OMAP || ARCH_KEYSTONE))
>>>
>>> This results in the EDMA engine code not being built. Yet another
>>> example of why improper use of the "select" statement is bad news
>>> and leads to broken configurations.
>>>
>> Thanks for reporting Russell. Will have a look.
>>
> Just to be clear for records, the select was introduced before
> KEYSTONE support was enabled. As per git blame, it came via commit
> b5f1433059 {spi: davici - make davinci select edma}.
I don't quite recall why this was needed and the commit description does
not help. Anyway, this is not needed - at least with current code. I
verified that the DaVinci SPI driver builds correctly with TI_EDMA
switched off. I can send a revert.
BTW, it looks like arch/arm/mach-keystone/Kconfig has a select for
TI_EDMA as well and that needs to be removed too.
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 5+ messages in thread
* [BUG] More select madness - keystone
2014-01-08 4:12 ` Sekhar Nori
@ 2014-01-08 14:06 ` Santosh Shilimkar
0 siblings, 0 replies; 5+ messages in thread
From: Santosh Shilimkar @ 2014-01-08 14:06 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 07 January 2014 11:12 PM, Sekhar Nori wrote:
> On Friday 03 January 2014 01:07 AM, Santosh Shilimkar wrote:
>> On Thursday 02 January 2014 02:17 PM, Santosh Shilimkar wrote:
>>> On Thursday 02 January 2014 12:26 PM, Russell King - ARM Linux wrote:
>>>> warning: (ARCH_KEYSTONE && SPI_DAVINCI) selects TI_EDMA which has unmet direct dependencies (DMADEVICES && (ARCH_DAVINCI || ARCH_OMAP || ARCH_KEYSTONE))
>>>>
>>>> This results in the EDMA engine code not being built. Yet another
>>>> example of why improper use of the "select" statement is bad news
>>>> and leads to broken configurations.
>>>>
>>> Thanks for reporting Russell. Will have a look.
>>>
>> Just to be clear for records, the select was introduced before
>> KEYSTONE support was enabled. As per git blame, it came via commit
>> b5f1433059 {spi: davici - make davinci select edma}.
>
> I don't quite recall why this was needed and the commit description does
> not help. Anyway, this is not needed - at least with current code. I
> verified that the DaVinci SPI driver builds correctly with TI_EDMA
> switched off. I can send a revert.
>
Please do...
> BTW, it looks like arch/arm/mach-keystone/Kconfig has a select for
> TI_EDMA as well and that needs to be removed too.
>
I have patch to kill that. Will be posting that.
Regards,
Santosh
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-01-08 14:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-02 17:26 [BUG] More select madness - keystone Russell King - ARM Linux
2014-01-02 19:17 ` Santosh Shilimkar
2014-01-02 19:37 ` Santosh Shilimkar
2014-01-08 4:12 ` Sekhar Nori
2014-01-08 14:06 ` Santosh Shilimkar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).