* [PATCH 1/5] dt-bindings: pwm-stm32: add #pwm-cells
2019-06-19 9:52 [PATCH 0/5] Add missing pwm-cells to STM32 timers PWM Fabrice Gasnier
@ 2019-06-19 9:52 ` Fabrice Gasnier
2019-07-09 20:04 ` Rob Herring
2019-06-19 9:52 ` [PATCH 2/5] pwm: stm32: use 3 cells ->of_xlate() Fabrice Gasnier
` (4 subsequent siblings)
5 siblings, 1 reply; 9+ messages in thread
From: Fabrice Gasnier @ 2019-06-19 9:52 UTC (permalink / raw)
To: thierry.reding, robh+dt, alexandre.torgue
Cc: mark.rutland, devicetree, benjamin.gaignard, linux-pwm, linux,
linux-kernel, mcoquelin.stm32, fabrice.gasnier, linux-stm32,
linux-arm-kernel
STM32 Timers support generic 3 cells PWM bindings to encode PWM number,
period and polarity as defined in pwm.txt.
Fixes: cd9a99c2f8e8 ("dt-bindings: pwm: Add STM32 bindings")
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
Documentation/devicetree/bindings/pwm/pwm-stm32.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/pwm/pwm-stm32.txt b/Documentation/devicetree/bindings/pwm/pwm-stm32.txt
index 3e6d550..a8690bf 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-stm32.txt
+++ b/Documentation/devicetree/bindings/pwm/pwm-stm32.txt
@@ -8,6 +8,8 @@ Required parameters:
- pinctrl-names: Set to "default".
- pinctrl-0: List of phandles pointing to pin configuration nodes for PWM module.
For Pinctrl properties see ../pinctrl/pinctrl-bindings.txt
+- #pwm-cells: Should be set to 3. This PWM chip uses the default 3 cells
+ bindings defined in pwm.txt.
Optional parameters:
- st,breakinput: One or two <index level filter> to describe break input configurations.
@@ -28,6 +30,7 @@ Example:
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
pinctrl-0 = <&pwm1_pins>;
pinctrl-names = "default";
st,breakinput = <0 1 5>;
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 1/5] dt-bindings: pwm-stm32: add #pwm-cells
2019-06-19 9:52 ` [PATCH 1/5] dt-bindings: pwm-stm32: add #pwm-cells Fabrice Gasnier
@ 2019-07-09 20:04 ` Rob Herring
0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2019-07-09 20:04 UTC (permalink / raw)
To: Fabrice Gasnier
Cc: mark.rutland, devicetree, alexandre.torgue, linux-pwm, linux,
robh+dt, linux-kernel, thierry.reding, mcoquelin.stm32,
fabrice.gasnier, linux-stm32, linux-arm-kernel,
benjamin.gaignard
On Wed, 19 Jun 2019 11:52:01 +0200, Fabrice Gasnier wrote:
> STM32 Timers support generic 3 cells PWM bindings to encode PWM number,
> period and polarity as defined in pwm.txt.
>
> Fixes: cd9a99c2f8e8 ("dt-bindings: pwm: Add STM32 bindings")
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
> Documentation/devicetree/bindings/pwm/pwm-stm32.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/5] pwm: stm32: use 3 cells ->of_xlate()
2019-06-19 9:52 [PATCH 0/5] Add missing pwm-cells to STM32 timers PWM Fabrice Gasnier
2019-06-19 9:52 ` [PATCH 1/5] dt-bindings: pwm-stm32: add #pwm-cells Fabrice Gasnier
@ 2019-06-19 9:52 ` Fabrice Gasnier
2019-06-19 11:42 ` Benjamin GAIGNARD
2019-06-19 9:52 ` [PATCH 3/5] ARM: dts: stm32: add pwm cells to stm32mp157c Fabrice Gasnier
` (3 subsequent siblings)
5 siblings, 1 reply; 9+ messages in thread
From: Fabrice Gasnier @ 2019-06-19 9:52 UTC (permalink / raw)
To: thierry.reding, robh+dt, alexandre.torgue
Cc: mark.rutland, devicetree, benjamin.gaignard, linux-pwm, linux,
linux-kernel, mcoquelin.stm32, fabrice.gasnier, linux-stm32,
linux-arm-kernel
STM32 Timers support generic 3 cells PWM to encode PWM number, period and
polarity.
Fixes: 7edf7369205b ("pwm: Add driver for STM32 plaftorm")
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
drivers/pwm/pwm-stm32.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pwm/pwm-stm32.c b/drivers/pwm/pwm-stm32.c
index 4f84255..740e2de 100644
--- a/drivers/pwm/pwm-stm32.c
+++ b/drivers/pwm/pwm-stm32.c
@@ -608,6 +608,8 @@ static int stm32_pwm_probe(struct platform_device *pdev)
priv->regmap = ddata->regmap;
priv->clk = ddata->clk;
priv->max_arr = ddata->max_arr;
+ priv->chip.of_xlate = of_pwm_xlate_with_flags;
+ priv->chip.of_pwm_n_cells = 3;
if (!priv->regmap || !priv->clk)
return -EINVAL;
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/5] pwm: stm32: use 3 cells ->of_xlate()
2019-06-19 9:52 ` [PATCH 2/5] pwm: stm32: use 3 cells ->of_xlate() Fabrice Gasnier
@ 2019-06-19 11:42 ` Benjamin GAIGNARD
0 siblings, 0 replies; 9+ messages in thread
From: Benjamin GAIGNARD @ 2019-06-19 11:42 UTC (permalink / raw)
To: Fabrice GASNIER, thierry.reding, robh+dt, Alexandre TORGUE
Cc: mark.rutland, devicetree, linux-pwm, linux-kernel, linux,
mcoquelin.stm32, linux-stm32, linux-arm-kernel
On 6/19/19 11:52 AM, Fabrice Gasnier wrote:
> STM32 Timers support generic 3 cells PWM to encode PWM number, period and
> polarity.
>
> Fixes: 7edf7369205b ("pwm: Add driver for STM32 plaftorm")
Reviewed-by: Benjamin Gaignard <benjamin.gaignard@st.com>
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
> drivers/pwm/pwm-stm32.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pwm/pwm-stm32.c b/drivers/pwm/pwm-stm32.c
> index 4f84255..740e2de 100644
> --- a/drivers/pwm/pwm-stm32.c
> +++ b/drivers/pwm/pwm-stm32.c
> @@ -608,6 +608,8 @@ static int stm32_pwm_probe(struct platform_device *pdev)
> priv->regmap = ddata->regmap;
> priv->clk = ddata->clk;
> priv->max_arr = ddata->max_arr;
> + priv->chip.of_xlate = of_pwm_xlate_with_flags;
> + priv->chip.of_pwm_n_cells = 3;
>
> if (!priv->regmap || !priv->clk)
> return -EINVAL;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/5] ARM: dts: stm32: add pwm cells to stm32mp157c
2019-06-19 9:52 [PATCH 0/5] Add missing pwm-cells to STM32 timers PWM Fabrice Gasnier
2019-06-19 9:52 ` [PATCH 1/5] dt-bindings: pwm-stm32: add #pwm-cells Fabrice Gasnier
2019-06-19 9:52 ` [PATCH 2/5] pwm: stm32: use 3 cells ->of_xlate() Fabrice Gasnier
@ 2019-06-19 9:52 ` Fabrice Gasnier
2019-06-19 9:52 ` [PATCH 4/5] ARM: dts: stm32: add pwm cells to stm32f429 Fabrice Gasnier
` (2 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Fabrice Gasnier @ 2019-06-19 9:52 UTC (permalink / raw)
To: thierry.reding, robh+dt, alexandre.torgue
Cc: mark.rutland, devicetree, benjamin.gaignard, linux-pwm, linux,
linux-kernel, mcoquelin.stm32, fabrice.gasnier, linux-stm32,
linux-arm-kernel
STM32 Timers support generic 3 cells PWM to encode PWM number, period and
polarity.
Fixes: 61fc211c484d ("ARM: dts: stm32: add timers support to stm32mp157c")
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
arch/arm/boot/dts/stm32mp157c.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi
index 2afeee6..215dc95 100644
--- a/arch/arm/boot/dts/stm32mp157c.dtsi
+++ b/arch/arm/boot/dts/stm32mp157c.dtsi
@@ -133,6 +133,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -161,6 +162,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -187,6 +189,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -215,6 +218,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -272,6 +276,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -293,6 +298,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -314,6 +320,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -545,6 +552,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -575,6 +583,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -637,6 +646,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -661,6 +671,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
timer@15 {
@@ -684,6 +695,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 4/5] ARM: dts: stm32: add pwm cells to stm32f429
2019-06-19 9:52 [PATCH 0/5] Add missing pwm-cells to STM32 timers PWM Fabrice Gasnier
` (2 preceding siblings ...)
2019-06-19 9:52 ` [PATCH 3/5] ARM: dts: stm32: add pwm cells to stm32mp157c Fabrice Gasnier
@ 2019-06-19 9:52 ` Fabrice Gasnier
2019-06-19 9:52 ` [PATCH 5/5] ARM: dts: stm32: add pwm cells to stm32f746 Fabrice Gasnier
2019-07-29 7:22 ` [PATCH 0/5] Add missing pwm-cells to STM32 timers PWM Alexandre Torgue
5 siblings, 0 replies; 9+ messages in thread
From: Fabrice Gasnier @ 2019-06-19 9:52 UTC (permalink / raw)
To: thierry.reding, robh+dt, alexandre.torgue
Cc: mark.rutland, devicetree, benjamin.gaignard, linux-pwm, linux,
linux-kernel, mcoquelin.stm32, fabrice.gasnier, linux-stm32,
linux-arm-kernel
STM32 Timers support generic 3 cells PWM to encode PWM number, period and
polarity.
Fixes: c0e14fc712d9 ("ARM: dts: stm32: add Timers driver for stm32f429
MCU")
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
arch/arm/boot/dts/stm32f429.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
index 4a49544..5c8a826 100644
--- a/arch/arm/boot/dts/stm32f429.dtsi
+++ b/arch/arm/boot/dts/stm32f429.dtsi
@@ -112,6 +112,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -141,6 +142,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -170,6 +172,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -198,6 +201,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -267,6 +271,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -288,6 +293,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
};
@@ -303,6 +309,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
};
@@ -448,6 +455,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -469,6 +477,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -602,6 +611,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -623,6 +633,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
};
@@ -638,6 +649,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
};
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 5/5] ARM: dts: stm32: add pwm cells to stm32f746
2019-06-19 9:52 [PATCH 0/5] Add missing pwm-cells to STM32 timers PWM Fabrice Gasnier
` (3 preceding siblings ...)
2019-06-19 9:52 ` [PATCH 4/5] ARM: dts: stm32: add pwm cells to stm32f429 Fabrice Gasnier
@ 2019-06-19 9:52 ` Fabrice Gasnier
2019-07-29 7:22 ` [PATCH 0/5] Add missing pwm-cells to STM32 timers PWM Alexandre Torgue
5 siblings, 0 replies; 9+ messages in thread
From: Fabrice Gasnier @ 2019-06-19 9:52 UTC (permalink / raw)
To: thierry.reding, robh+dt, alexandre.torgue
Cc: mark.rutland, devicetree, benjamin.gaignard, linux-pwm, linux,
linux-kernel, mcoquelin.stm32, fabrice.gasnier, linux-stm32,
linux-arm-kernel
STM32 Timers support generic 3 cells PWM to encode PWM number, period and
polarity.
Fixes: 9bd7b77af8e4 ("ARM: dts: stm32: add Timers driver for stm32f746
MCU")
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
arch/arm/boot/dts/stm32f746.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi
index a25b700..d26f93f 100644
--- a/arch/arm/boot/dts/stm32f746.dtsi
+++ b/arch/arm/boot/dts/stm32f746.dtsi
@@ -94,6 +94,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -123,6 +124,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -152,6 +154,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -180,6 +183,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -249,6 +253,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -270,6 +275,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
};
@@ -285,6 +291,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
};
@@ -419,6 +426,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -440,6 +448,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -512,6 +521,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
@@ -533,6 +543,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
};
@@ -548,6 +559,7 @@
pwm {
compatible = "st,stm32-pwm";
+ #pwm-cells = <3>;
status = "disabled";
};
};
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 0/5] Add missing pwm-cells to STM32 timers PWM
2019-06-19 9:52 [PATCH 0/5] Add missing pwm-cells to STM32 timers PWM Fabrice Gasnier
` (4 preceding siblings ...)
2019-06-19 9:52 ` [PATCH 5/5] ARM: dts: stm32: add pwm cells to stm32f746 Fabrice Gasnier
@ 2019-07-29 7:22 ` Alexandre Torgue
5 siblings, 0 replies; 9+ messages in thread
From: Alexandre Torgue @ 2019-07-29 7:22 UTC (permalink / raw)
To: Fabrice Gasnier, thierry.reding, robh+dt
Cc: mark.rutland, devicetree, benjamin.gaignard, linux-pwm,
linux-kernel, linux, mcoquelin.stm32, linux-stm32,
linux-arm-kernel
Hi Fabrice
On 6/19/19 11:52 AM, Fabrice Gasnier wrote:
> This series adds missing generic 3-cells PWM to STM32 timers dt-bindings,
> PWM driver, and the relevant dtsi files for STM32F4, STM32F7 and STM32MP1.
>
> Fabrice Gasnier (5):
> dt-bindings: pwm-stm32: add #pwm-cells
> pwm: stm32: use 3 cells ->of_xlate()
> ARM: dts: stm32: add pwm cells to stm32mp157c
> ARM: dts: stm32: add pwm cells to stm32f429
> ARM: dts: stm32: add pwm cells to stm32f746
>
> Documentation/devicetree/bindings/pwm/pwm-stm32.txt | 3 +++
> arch/arm/boot/dts/stm32f429.dtsi | 12 ++++++++++++
> arch/arm/boot/dts/stm32f746.dtsi | 12 ++++++++++++
> arch/arm/boot/dts/stm32mp157c.dtsi | 12 ++++++++++++
> drivers/pwm/pwm-stm32.c | 2 ++
> 5 files changed, 41 insertions(+)
>
DT patches applied on stm32-next.
regards
Alex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread