linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/1] ARM: dts: sun5i: inet98v_rev2 fix regulator for the usb wifi
@ 2015-08-27 18:37 Hans de Goede
  2015-08-27 18:37 ` [PATCH] ARM: dts: sun5i: inet98v_rev2 fix regulator for the usb wifi module Hans de Goede
  2015-08-28 12:28 ` [PATCH 0/1] ARM: dts: sun5i: inet98v_rev2 fix regulator for the usb wifi Maxime Ripard
  0 siblings, 2 replies; 4+ messages in thread
From: Hans de Goede @ 2015-08-27 18:37 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Maxime,

Here is a fixup patch for the patch adding a dts for the inet98v_rev2.

I'm not sure if you've merged the original patch yet, hence I'm sending
this as a follow-up patch. If you've not yet merged the original patch
feel free to squash this fix in.

Regards,

Hans

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] ARM: dts: sun5i: inet98v_rev2 fix regulator for the usb wifi module
  2015-08-27 18:37 [PATCH 0/1] ARM: dts: sun5i: inet98v_rev2 fix regulator for the usb wifi Hans de Goede
@ 2015-08-27 18:37 ` Hans de Goede
  2015-08-28 12:28 ` [PATCH 0/1] ARM: dts: sun5i: inet98v_rev2 fix regulator for the usb wifi Maxime Ripard
  1 sibling, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2015-08-27 18:37 UTC (permalink / raw)
  To: linux-arm-kernel

The usb-wifi module is not connected to a gpio controller regulator
(as is typical on sunxi boards), instead is it connected to ldo3.

This commit fixes the us_phy usb1_vbus-supply setting thereby making
sure that we power the usb-wifi and that it can be used.

This commit also removes the wrong and now unused bits which refer to
the gpio controlled reg_usb1_vbus.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 arch/arm/boot/dts/sun5i-a13-inet-98v-rev2.dts | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/arch/arm/boot/dts/sun5i-a13-inet-98v-rev2.dts b/arch/arm/boot/dts/sun5i-a13-inet-98v-rev2.dts
index 6d466a2..6fa54b6 100644
--- a/arch/arm/boot/dts/sun5i-a13-inet-98v-rev2.dts
+++ b/arch/arm/boot/dts/sun5i-a13-inet-98v-rev2.dts
@@ -201,11 +201,6 @@
 	status = "okay";
 };
 
-&reg_usb1_vbus {
-	gpio = <&pio 6 11 GPIO_ACTIVE_HIGH>; /* PG11 */
-	status = "okay";
-};
-
 &uart1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart1_pins_b>;
@@ -221,16 +216,12 @@
 	allwinner,pins = "PG12";
 };
 
-&usb1_vbus_pin_a {
-	allwinner,pins = "PG11";
-};
-
 &usbphy {
 	pinctrl-names = "default";
 	pinctrl-0 = <&usb0_id_detect_pin>, <&usb0_vbus_detect_pin>;
 	usb0_id_det-gpio = <&pio 6 2 GPIO_ACTIVE_HIGH>; /* PG2 */
 	usb0_vbus_det-gpio = <&pio 6 1 GPIO_ACTIVE_HIGH>; /* PG1 */
 	usb0_vbus-supply = <&reg_usb0_vbus>;
-	usb1_vbus-supply = <&reg_usb1_vbus>;
+	usb1_vbus-supply = <&reg_ldo3>;
 	status = "okay";
 };
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 0/1] ARM: dts: sun5i: inet98v_rev2 fix regulator for the usb wifi
  2015-08-27 18:37 [PATCH 0/1] ARM: dts: sun5i: inet98v_rev2 fix regulator for the usb wifi Hans de Goede
  2015-08-27 18:37 ` [PATCH] ARM: dts: sun5i: inet98v_rev2 fix regulator for the usb wifi module Hans de Goede
@ 2015-08-28 12:28 ` Maxime Ripard
  2015-08-28 13:15   ` Hans de Goede
  1 sibling, 1 reply; 4+ messages in thread
From: Maxime Ripard @ 2015-08-28 12:28 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Hans,

On Thu, Aug 27, 2015 at 08:37:30PM +0200, Hans de Goede wrote:
> Hi Maxime,
> 
> Here is a fixup patch for the patch adding a dts for the inet98v_rev2.
> 
> I'm not sure if you've merged the original patch yet, hence I'm sending
> this as a follow-up patch. If you've not yet merged the original patch
> feel free to squash this fix in.

Have you ever submitted that first patch in the first place?

I'm don't have the DTS file you're patching in my tree, and I don't
see any email and/or patch relating to that board.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150828/5f0413b6/attachment.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 0/1] ARM: dts: sun5i: inet98v_rev2 fix regulator for the usb wifi
  2015-08-28 12:28 ` [PATCH 0/1] ARM: dts: sun5i: inet98v_rev2 fix regulator for the usb wifi Maxime Ripard
@ 2015-08-28 13:15   ` Hans de Goede
  0 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2015-08-28 13:15 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On 28-08-15 14:28, Maxime Ripard wrote:
> Hi Hans,
>
> On Thu, Aug 27, 2015 at 08:37:30PM +0200, Hans de Goede wrote:
>> Hi Maxime,
>>
>> Here is a fixup patch for the patch adding a dts for the inet98v_rev2.
>>
>> I'm not sure if you've merged the original patch yet, hence I'm sending
>> this as a follow-up patch. If you've not yet merged the original patch
>> feel free to squash this fix in.
>
> Have you ever submitted that first patch in the first place?
>
> I'm don't have the DTS file you're patching in my tree, and I don't
> see any email and/or patch relating to that board.

Oh, I thought I had posted it, ah well. I'll do a v2 (which I guess
really is v1 then) with the fix squashed in.

Regards,

Hans

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-08-28 13:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-27 18:37 [PATCH 0/1] ARM: dts: sun5i: inet98v_rev2 fix regulator for the usb wifi Hans de Goede
2015-08-27 18:37 ` [PATCH] ARM: dts: sun5i: inet98v_rev2 fix regulator for the usb wifi module Hans de Goede
2015-08-28 12:28 ` [PATCH 0/1] ARM: dts: sun5i: inet98v_rev2 fix regulator for the usb wifi Maxime Ripard
2015-08-28 13:15   ` Hans de Goede

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).