* [PATCH] media: s5p-mfc remove unnecessary error messages
@ 2016-07-13 0:33 Shuah Khan
2016-07-14 12:46 ` Javier Martinez Canillas
0 siblings, 1 reply; 4+ messages in thread
From: Shuah Khan @ 2016-07-13 0:33 UTC (permalink / raw)
To: linux-arm-kernel
Removing unnecessary error messages as appropriate error code is returned.
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c
index b6fde20..906f80c 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
@@ -759,7 +759,6 @@ static int s5p_mfc_open(struct file *file)
/* Allocate memory for context */
ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
if (!ctx) {
- mfc_err("Not enough memory\n");
ret = -ENOMEM;
goto err_alloc;
}
@@ -776,7 +775,6 @@ static int s5p_mfc_open(struct file *file)
while (dev->ctx[ctx->num]) {
ctx->num++;
if (ctx->num >= MFC_NUM_CONTEXTS) {
- mfc_err("Too many open contexts\n");
ret = -EBUSY;
goto err_no_ctx;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] media: s5p-mfc remove unnecessary error messages
2016-07-13 0:33 [PATCH] media: s5p-mfc remove unnecessary error messages Shuah Khan
@ 2016-07-14 12:46 ` Javier Martinez Canillas
2016-07-14 13:35 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Javier Martinez Canillas @ 2016-07-14 12:46 UTC (permalink / raw)
To: linux-arm-kernel
Hello Shuah,
On 07/12/2016 08:33 PM, Shuah Khan wrote:
> Removing unnecessary error messages as appropriate error code is returned.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c
> index b6fde20..906f80c 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
> @@ -759,7 +759,6 @@ static int s5p_mfc_open(struct file *file)
> /* Allocate memory for context */
> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> if (!ctx) {
> - mfc_err("Not enough memory\n");
I agree to remove this since in case of a OOM, the core already does a
stack dump and prints an error message so there's no need to it here.
> ret = -ENOMEM;
> goto err_alloc;
> }
> @@ -776,7 +775,6 @@ static int s5p_mfc_open(struct file *file)
> while (dev->ctx[ctx->num]) {
> ctx->num++;
> if (ctx->num >= MFC_NUM_CONTEXTS) {
> - mfc_err("Too many open contexts\n");
But I think this error message shouldn't be removed since explains why
the open failed, even when an error code is returned.
> ret = -EBUSY;
> goto err_no_ctx;
> }
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] media: s5p-mfc remove unnecessary error messages
2016-07-14 12:46 ` Javier Martinez Canillas
@ 2016-07-14 13:35 ` Shuah Khan
2016-07-14 13:36 ` Javier Martinez Canillas
0 siblings, 1 reply; 4+ messages in thread
From: Shuah Khan @ 2016-07-14 13:35 UTC (permalink / raw)
To: linux-arm-kernel
On 07/14/2016 06:46 AM, Javier Martinez Canillas wrote:
> Hello Shuah,
>
> On 07/12/2016 08:33 PM, Shuah Khan wrote:
>> Removing unnecessary error messages as appropriate error code is returned.
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>> drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c
>> index b6fde20..906f80c 100644
>> --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
>> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
>> @@ -759,7 +759,6 @@ static int s5p_mfc_open(struct file *file)
>> /* Allocate memory for context */
>> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
>> if (!ctx) {
>> - mfc_err("Not enough memory\n");
>
> I agree to remove this since in case of a OOM, the core already does a
> stack dump and prints an error message so there's no need to it here.
>
>> ret = -ENOMEM;
>> goto err_alloc;
>> }
>> @@ -776,7 +775,6 @@ static int s5p_mfc_open(struct file *file)
>> while (dev->ctx[ctx->num]) {
>> ctx->num++;
>> if (ctx->num >= MFC_NUM_CONTEXTS) {
>> - mfc_err("Too many open contexts\n");
>
> But I think this error message shouldn't be removed since explains why
> the open failed, even when an error code is returned.
This message isn't very informative and not sure if it is giving
any more information than EBUSY. It is a good debug message perhaps,
but not an error message. Would it be okay if I made it debug instead.
thanks,
-- Shuah
>
>> ret = -EBUSY;
>> goto err_no_ctx;
>> }
>>
>
> Best regards,
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] media: s5p-mfc remove unnecessary error messages
2016-07-14 13:35 ` Shuah Khan
@ 2016-07-14 13:36 ` Javier Martinez Canillas
0 siblings, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2016-07-14 13:36 UTC (permalink / raw)
To: linux-arm-kernel
Hello Shuah,
On 07/14/2016 09:35 AM, Shuah Khan wrote:
> On 07/14/2016 06:46 AM, Javier Martinez Canillas wrote:
>> Hello Shuah,
>>
>> On 07/12/2016 08:33 PM, Shuah Khan wrote:
>>> Removing unnecessary error messages as appropriate error code is returned.
>>>
>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>> ---
>>> drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c
>>> index b6fde20..906f80c 100644
>>> --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
>>> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
>>> @@ -759,7 +759,6 @@ static int s5p_mfc_open(struct file *file)
>>> /* Allocate memory for context */
>>> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
>>> if (!ctx) {
>>> - mfc_err("Not enough memory\n");
>>
>> I agree to remove this since in case of a OOM, the core already does a
>> stack dump and prints an error message so there's no need to it here.
>>
>>> ret = -ENOMEM;
>>> goto err_alloc;
>>> }
>>> @@ -776,7 +775,6 @@ static int s5p_mfc_open(struct file *file)
>>> while (dev->ctx[ctx->num]) {
>>> ctx->num++;
>>> if (ctx->num >= MFC_NUM_CONTEXTS) {
>>> - mfc_err("Too many open contexts\n");
>>
>> But I think this error message shouldn't be removed since explains why
>> the open failed, even when an error code is returned.
>
> This message isn't very informative and not sure if it is giving
> any more information than EBUSY. It is a good debug message perhaps,
> but not an error message. Would it be okay if I made it debug instead.
>
Making it a debug message sounds good to me.
> thanks,
> -- Shuah
>>
>>> ret = -EBUSY;
>>> goto err_no_ctx;
>>> }
>>>
>>
>> Best regards,
>>
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-14 13:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-13 0:33 [PATCH] media: s5p-mfc remove unnecessary error messages Shuah Khan
2016-07-14 12:46 ` Javier Martinez Canillas
2016-07-14 13:35 ` Shuah Khan
2016-07-14 13:36 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).