* [PATCH 0/3] Exynos5 DMC minor fixes
[not found] <CGME20190906101404eucas1p1d11e26276bfdacb7748f1391e29f45d0@eucas1p1.samsung.com>
@ 2019-09-06 10:13 ` Lukasz Luba
[not found] ` <CGME20190906101405eucas1p2e3da7b461810a3a520e76c636a06e486@eucas1p2.samsung.com>
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Lukasz Luba @ 2019-09-06 10:13 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-pm, linux-samsung-soc, linux-arm-kernel
Cc: mark.rutland, willy.mh.wolff.ml, b.zolnierkie, krzk, Lukasz Luba,
cw00.choi, kyungmin.park, robh+dt, kgene, s.nawrocki,
myungjoo.ham, m.szyprowski
Hi all,
This is a follow up patch set for the Exynos5 Dynamic Memory Controller
driver v13 [1]. The patches are based on Krzysztof's 'for-next' branch [2].
There are a few minor fixes captured during static analysis and a new
binding for 'samsung,K3QF2F20DB' LPDDR3 memory.
Regards,
Lukasz Luba
[1] https://lkml.org/lkml/2019/8/21/283
[2] https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/log/?h=for-next
Lukasz Luba (3):
memory: Exynos5422: minor fixes in DMC
ARM: dts: exynos: fix too long line in memory device
dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories
.../devicetree/bindings/ddr/lpddr3.txt | 29 +++++++++++++++++--
arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 3 +-
drivers/memory/samsung/exynos5422-dmc.c | 4 +--
3 files changed, 31 insertions(+), 5 deletions(-)
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/3] memory: Exynos5422: minor fixes in DMC
[not found] ` <CGME20190906101405eucas1p2e3da7b461810a3a520e76c636a06e486@eucas1p2.samsung.com>
@ 2019-09-06 10:13 ` Lukasz Luba
2019-09-06 10:51 ` Krzysztof Kozlowski
0 siblings, 1 reply; 12+ messages in thread
From: Lukasz Luba @ 2019-09-06 10:13 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-pm, linux-samsung-soc, linux-arm-kernel
Cc: mark.rutland, willy.mh.wolff.ml, b.zolnierkie, krzk, Lukasz Luba,
cw00.choi, kyungmin.park, robh+dt, kgene, s.nawrocki,
myungjoo.ham, m.szyprowski
Small fixes captured by static analyzes.
Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
---
drivers/memory/samsung/exynos5422-dmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
index 8c2ec29a7d57..a809fa997c03 100644
--- a/drivers/memory/samsung/exynos5422-dmc.c
+++ b/drivers/memory/samsung/exynos5422-dmc.c
@@ -269,7 +269,7 @@ static int exynos5_init_freq_table(struct exynos5_dmc *dmc,
return 0;
err_free_tables:
- kfree(dmc->opp);
+ devm_kfree(dmc->dev, dmc->opp);
err_opp:
dev_pm_opp_of_remove_table(dmc->dev);
@@ -732,7 +732,7 @@ static struct devfreq_dev_profile exynos5_dmc_df_profile = {
* statistics engine which supports only registered values. Thus, some alignment
* must be made.
*/
-unsigned long
+static unsigned long
exynos5_dmc_align_init_freq(struct exynos5_dmc *dmc,
unsigned long bootloader_init_freq)
{
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/3] ARM: dts: exynos: fix too long line in memory device
[not found] ` <CGME20190906101406eucas1p289695a398d757b116367257293c3544d@eucas1p2.samsung.com>
@ 2019-09-06 10:13 ` Lukasz Luba
0 siblings, 0 replies; 12+ messages in thread
From: Lukasz Luba @ 2019-09-06 10:13 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-pm, linux-samsung-soc, linux-arm-kernel
Cc: mark.rutland, willy.mh.wolff.ml, b.zolnierkie, krzk, Lukasz Luba,
cw00.choi, kyungmin.park, robh+dt, kgene, s.nawrocki,
myungjoo.ham, m.szyprowski
Small fix moving the comment to line above making sure the lines do not
exceed 80 characters.
Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
---
arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
index fe885ca969af..059fa32d1a8f 100644
--- a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
@@ -103,7 +103,8 @@
timings_samsung_K3QF2F20DB_800mhz: lpddr3-timings@800000000 {
compatible = "jedec,lpddr3-timings";
- reg = <800000000>; /* workaround: it shows max-freq */
+ /* workaround: 'reg' shows max-freq */
+ reg = <800000000>;
min-freq = <100000000>;
tRFC = <65000>;
tRRD = <6000>;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/3] dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories
[not found] ` <CGME20190906101407eucas1p15eb0df53374b27497b4793eab24becf6@eucas1p1.samsung.com>
@ 2019-09-06 10:13 ` Lukasz Luba
2019-09-06 10:56 ` Krzysztof Kozlowski
0 siblings, 1 reply; 12+ messages in thread
From: Lukasz Luba @ 2019-09-06 10:13 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-pm, linux-samsung-soc, linux-arm-kernel
Cc: mark.rutland, willy.mh.wolff.ml, b.zolnierkie, krzk, Lukasz Luba,
cw00.choi, kyungmin.park, robh+dt, kgene, s.nawrocki,
myungjoo.ham, m.szyprowski
Add description of bindings for Samsung k3qf2f20db LPDDR3 memory.
Minor fixes in the old documentation.
Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
---
.../devicetree/bindings/ddr/lpddr3.txt | 29 +++++++++++++++++--
1 file changed, 27 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/ddr/lpddr3.txt b/Documentation/devicetree/bindings/ddr/lpddr3.txt
index 3b2485b84b3f..de0905239767 100644
--- a/Documentation/devicetree/bindings/ddr/lpddr3.txt
+++ b/Documentation/devicetree/bindings/ddr/lpddr3.txt
@@ -40,10 +40,34 @@ Child nodes:
a given speed-bin. Please see Documentation/devicetree/
bindings/ddr/lpddr3-timings.txt for more information on "lpddr3-timings"
+Samsung K3QF2F20DB LPDDR3 memory
+------------------------------------------------------------
+
+This binding uses the LPDDR3 binding (described above)
+
+Required properties:
+- compatible: Should be:
+ "samsung,K3QF2F20DB"
+ followed by "jedec,lpddr3"
+- density : <u32> representing density in Mb (Mega bits)
+- io-width : <u32> representing bus width. Possible value 32
+- #address-cells: Must be set to 1
+- #size-cells: Must be set to 0
+
+Optional properties:
+
+The optional properties are the same as in the LPDDR3 generic bindings and
+values should be taken from the data-sheet. Detailed bindings are described
+above.
+
+Child nodes:
+
+Detailed bindings are described in LPDDR3 generic bindings described above.
+
Example:
samsung_K3QF2F20DB: lpddr3 {
- compatible = "Samsung,K3QF2F20DB", "jedec,lpddr3";
+ compatible = "samsung,K3QF2F20DB", "jedec,lpddr3";
density = <16384>;
io-width = <32>;
#address-cells = <1>;
@@ -73,7 +97,8 @@ samsung_K3QF2F20DB: lpddr3 {
timings_samsung_K3QF2F20DB_800mhz: lpddr3-timings@800000000 {
compatible = "jedec,lpddr3-timings";
- reg = <800000000>; /* workaround: it shows max-freq */
+ /* workaround: 'reg' shows max-freq */
+ reg = <800000000>;
min-freq = <100000000>;
tRFC = <65000>;
tRRD = <6000>;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] memory: Exynos5422: minor fixes in DMC
2019-09-06 10:13 ` [PATCH 1/3] memory: Exynos5422: minor fixes in DMC Lukasz Luba
@ 2019-09-06 10:51 ` Krzysztof Kozlowski
2019-09-06 11:43 ` Lukasz Luba
0 siblings, 1 reply; 12+ messages in thread
From: Krzysztof Kozlowski @ 2019-09-06 10:51 UTC (permalink / raw)
To: Lukasz Luba
Cc: mark.rutland, devicetree, willy.mh.wolff.ml, linux-samsung-soc,
Bartłomiej Żołnierkiewicz, linux-pm, linux-kernel,
robh+dt, Chanwoo Choi, kyungmin.park, kgene, myungjoo.ham,
s.nawrocki, linux-arm-kernel, Marek Szyprowski
On Fri, 6 Sep 2019 at 12:14, Lukasz Luba <l.luba@partner.samsung.com> wrote:
>
> Small fixes captured by static analyzes.
Explain please what are the errors being fixed. Additionally error
message from tool might be useful.
Also:
Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
> ---
> drivers/memory/samsung/exynos5422-dmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
> index 8c2ec29a7d57..a809fa997c03 100644
> --- a/drivers/memory/samsung/exynos5422-dmc.c
> +++ b/drivers/memory/samsung/exynos5422-dmc.c
> @@ -269,7 +269,7 @@ static int exynos5_init_freq_table(struct exynos5_dmc *dmc,
> return 0;
>
> err_free_tables:
> - kfree(dmc->opp);
> + devm_kfree(dmc->dev, dmc->opp);
> err_opp:
> dev_pm_opp_of_remove_table(dmc->dev);
>
> @@ -732,7 +732,7 @@ static struct devfreq_dev_profile exynos5_dmc_df_profile = {
> * statistics engine which supports only registered values. Thus, some alignment
> * must be made.
> */
> -unsigned long
> +static unsigned long
> exynos5_dmc_align_init_freq(struct exynos5_dmc *dmc,
> unsigned long bootloader_init_freq)
> {
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 3/3] dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories
2019-09-06 10:13 ` [PATCH 3/3] dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories Lukasz Luba
@ 2019-09-06 10:56 ` Krzysztof Kozlowski
2019-09-06 11:39 ` Lukasz Luba
0 siblings, 1 reply; 12+ messages in thread
From: Krzysztof Kozlowski @ 2019-09-06 10:56 UTC (permalink / raw)
To: Lukasz Luba
Cc: mark.rutland, devicetree, willy.mh.wolff.ml, linux-samsung-soc,
Bartłomiej Żołnierkiewicz, linux-pm, linux-kernel,
robh+dt, Chanwoo Choi, kyungmin.park, kgene, myungjoo.ham,
s.nawrocki, linux-arm-kernel, Marek Szyprowski
On Fri, 6 Sep 2019 at 12:14, Lukasz Luba <l.luba@partner.samsung.com> wrote:
>
> Add description of bindings for Samsung k3qf2f20db LPDDR3 memory.
> Minor fixes in the old documentation.
>
> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
> ---
> .../devicetree/bindings/ddr/lpddr3.txt | 29 +++++++++++++++++--
> 1 file changed, 27 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/ddr/lpddr3.txt b/Documentation/devicetree/bindings/ddr/lpddr3.txt
> index 3b2485b84b3f..de0905239767 100644
> --- a/Documentation/devicetree/bindings/ddr/lpddr3.txt
> +++ b/Documentation/devicetree/bindings/ddr/lpddr3.txt
> @@ -40,10 +40,34 @@ Child nodes:
> a given speed-bin. Please see Documentation/devicetree/
> bindings/ddr/lpddr3-timings.txt for more information on "lpddr3-timings"
>
> +Samsung K3QF2F20DB LPDDR3 memory
> +------------------------------------------------------------
> +
> +This binding uses the LPDDR3 binding (described above)
> +
> +Required properties:
> +- compatible: Should be:
> + "samsung,K3QF2F20DB"
> + followed by "jedec,lpddr3"
> +- density : <u32> representing density in Mb (Mega bits)
> +- io-width : <u32> representing bus width. Possible value 32
> +- #address-cells: Must be set to 1
> +- #size-cells: Must be set to 0
If you decided to repeat all properties again, then it deserves its
own bindings file. However I though about simpler solution - just
document compatible. Exactly the same as AT24 or AT25 EEPROM bindings.
There is not much benefit from copying all these properties.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 3/3] dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories
2019-09-06 10:56 ` Krzysztof Kozlowski
@ 2019-09-06 11:39 ` Lukasz Luba
2019-09-06 11:50 ` Krzysztof Kozlowski
0 siblings, 1 reply; 12+ messages in thread
From: Lukasz Luba @ 2019-09-06 11:39 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: mark.rutland, devicetree, willy.mh.wolff.ml, linux-samsung-soc,
Bartłomiej Żołnierkiewicz, linux-pm, linux-kernel,
robh+dt, Chanwoo Choi, kyungmin.park, kgene, myungjoo.ham,
s.nawrocki, linux-arm-kernel, Marek Szyprowski
Hi Krzysztof,
On 9/6/19 12:56 PM, Krzysztof Kozlowski wrote:
> On Fri, 6 Sep 2019 at 12:14, Lukasz Luba <l.luba@partner.samsung.com> wrote:
>>
>> Add description of bindings for Samsung k3qf2f20db LPDDR3 memory.
>> Minor fixes in the old documentation.
>>
>> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
>> ---
>> .../devicetree/bindings/ddr/lpddr3.txt | 29 +++++++++++++++++--
>> 1 file changed, 27 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/ddr/lpddr3.txt b/Documentation/devicetree/bindings/ddr/lpddr3.txt
>> index 3b2485b84b3f..de0905239767 100644
>> --- a/Documentation/devicetree/bindings/ddr/lpddr3.txt
>> +++ b/Documentation/devicetree/bindings/ddr/lpddr3.txt
>> @@ -40,10 +40,34 @@ Child nodes:
>> a given speed-bin. Please see Documentation/devicetree/
>> bindings/ddr/lpddr3-timings.txt for more information on "lpddr3-timings"
>>
>> +Samsung K3QF2F20DB LPDDR3 memory
>> +------------------------------------------------------------
>> +
>> +This binding uses the LPDDR3 binding (described above)
>> +
>> +Required properties:
>> +- compatible: Should be:
>> + "samsung,K3QF2F20DB"
>> + followed by "jedec,lpddr3"
>> +- density : <u32> representing density in Mb (Mega bits)
>> +- io-width : <u32> representing bus width. Possible value 32
>> +- #address-cells: Must be set to 1
>> +- #size-cells: Must be set to 0
>
> If you decided to repeat all properties again, then it deserves its
> own bindings file. However I though about simpler solution - just
> document compatible. Exactly the same as AT24 or AT25 EEPROM bindings.
> There is not much benefit from copying all these properties.
OK, I see. I will add only 'compatible' and skip the rest then.
So the lpddr3.txt file will get this addition:
+Samsung K3QF2F20DB LPDDR3 memory
+------------------------------------------------------------
+
+This binding uses the LPDDR3 binding (described above)
+
+Required properties:
+- compatible: Should be:
+ "samsung,K3QF2F20DB"
+ followed by "jedec,lpddr3"
+
+Optional properties:
+
+The optional properties are the same as in the LPDDR3 generic bindings and
+values should be taken from the data-sheet. Detailed bindings are described
+above.
+
+Child nodes:
+
+Detailed bindings are described in LPDDR3 generic bindings described above.
+
Is it OK?
Regards,
Lukasz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] memory: Exynos5422: minor fixes in DMC
2019-09-06 10:51 ` Krzysztof Kozlowski
@ 2019-09-06 11:43 ` Lukasz Luba
0 siblings, 0 replies; 12+ messages in thread
From: Lukasz Luba @ 2019-09-06 11:43 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: mark.rutland, devicetree, willy.mh.wolff.ml, linux-samsung-soc,
Bartłomiej Żołnierkiewicz, linux-pm, linux-kernel,
robh+dt, Chanwoo Choi, kyungmin.park, kgene, myungjoo.ham,
s.nawrocki, linux-arm-kernel, Marek Szyprowski
On 9/6/19 12:51 PM, Krzysztof Kozlowski wrote:
> On Fri, 6 Sep 2019 at 12:14, Lukasz Luba <l.luba@partner.samsung.com> wrote:
>>
>> Small fixes captured by static analyzes.
>
> Explain please what are the errors being fixed. Additionally error
> message from tool might be useful.
>
> Also:
> Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
OK, I will add it in the next version.
My apologies for missing your name there.
Regards,
Lukasz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 3/3] dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories
2019-09-06 11:39 ` Lukasz Luba
@ 2019-09-06 11:50 ` Krzysztof Kozlowski
2019-09-06 12:14 ` Lukasz Luba
2019-09-13 14:36 ` Rob Herring
0 siblings, 2 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2019-09-06 11:50 UTC (permalink / raw)
To: Lukasz Luba
Cc: mark.rutland, devicetree, willy.mh.wolff.ml, linux-samsung-soc,
Bartłomiej Żołnierkiewicz, linux-pm, linux-kernel,
robh+dt, Chanwoo Choi, kyungmin.park, kgene, myungjoo.ham,
s.nawrocki, linux-arm-kernel, Marek Szyprowski
On Fri, 6 Sep 2019 at 13:39, Lukasz Luba <l.luba@partner.samsung.com> wrote:
>
> Hi Krzysztof,
>
> On 9/6/19 12:56 PM, Krzysztof Kozlowski wrote:
> > On Fri, 6 Sep 2019 at 12:14, Lukasz Luba <l.luba@partner.samsung.com> wrote:
> >>
> >> Add description of bindings for Samsung k3qf2f20db LPDDR3 memory.
> >> Minor fixes in the old documentation.
> >>
> >> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
> >> ---
> >> .../devicetree/bindings/ddr/lpddr3.txt | 29 +++++++++++++++++--
> >> 1 file changed, 27 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/ddr/lpddr3.txt b/Documentation/devicetree/bindings/ddr/lpddr3.txt
> >> index 3b2485b84b3f..de0905239767 100644
> >> --- a/Documentation/devicetree/bindings/ddr/lpddr3.txt
> >> +++ b/Documentation/devicetree/bindings/ddr/lpddr3.txt
> >> @@ -40,10 +40,34 @@ Child nodes:
> >> a given speed-bin. Please see Documentation/devicetree/
> >> bindings/ddr/lpddr3-timings.txt for more information on "lpddr3-timings"
> >>
> >> +Samsung K3QF2F20DB LPDDR3 memory
> >> +------------------------------------------------------------
> >> +
> >> +This binding uses the LPDDR3 binding (described above)
> >> +
> >> +Required properties:
> >> +- compatible: Should be:
> >> + "samsung,K3QF2F20DB"
> >> + followed by "jedec,lpddr3"
> >> +- density : <u32> representing density in Mb (Mega bits)
> >> +- io-width : <u32> representing bus width. Possible value 32
> >> +- #address-cells: Must be set to 1
> >> +- #size-cells: Must be set to 0
> >
> > If you decided to repeat all properties again, then it deserves its
> > own bindings file. However I though about simpler solution - just
> > document compatible. Exactly the same as AT24 or AT25 EEPROM bindings.
> > There is not much benefit from copying all these properties.
> OK, I see. I will add only 'compatible' and skip the rest then.
> So the lpddr3.txt file will get this addition:
>
> +Samsung K3QF2F20DB LPDDR3 memory
> +------------------------------------------------------------
> +
> +This binding uses the LPDDR3 binding (described above)
> +
> +Required properties:
> +- compatible: Should be:
> + "samsung,K3QF2F20DB"
> + followed by "jedec,lpddr3"
> +
> +Optional properties:
> +
> +The optional properties are the same as in the LPDDR3 generic bindings and
> +values should be taken from the data-sheet. Detailed bindings are described
> +above.
> +
> +Child nodes:
> +
> +Detailed bindings are described in LPDDR3 generic bindings described above.
> +
>
> Is it OK?
To me it is still a lot of text just for one compatible and I can
image more of such entries for other memories... However I do not mind
and anyway, YAML will simplify it. If you're in doubt, wait for Rob's
reply as this is his part.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 3/3] dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories
2019-09-06 11:50 ` Krzysztof Kozlowski
@ 2019-09-06 12:14 ` Lukasz Luba
2019-09-13 14:36 ` Rob Herring
1 sibling, 0 replies; 12+ messages in thread
From: Lukasz Luba @ 2019-09-06 12:14 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: mark.rutland, devicetree, willy.mh.wolff.ml, linux-samsung-soc,
Bartłomiej Żołnierkiewicz, linux-pm, linux-kernel,
robh+dt, Chanwoo Choi, kyungmin.park, kgene, myungjoo.ham,
s.nawrocki, linux-arm-kernel, Marek Szyprowski
On 9/6/19 1:50 PM, Krzysztof Kozlowski wrote:
> On Fri, 6 Sep 2019 at 13:39, Lukasz Luba <l.luba@partner.samsung.com> wrote:
>>
>> Hi Krzysztof,
>>
>> On 9/6/19 12:56 PM, Krzysztof Kozlowski wrote:
>>> On Fri, 6 Sep 2019 at 12:14, Lukasz Luba <l.luba@partner.samsung.com> wrote:
>>>>
>>>> Add description of bindings for Samsung k3qf2f20db LPDDR3 memory.
>>>> Minor fixes in the old documentation.
>>>>
>>>> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
>>>> ---
>>>> .../devicetree/bindings/ddr/lpddr3.txt | 29 +++++++++++++++++--
>>>> 1 file changed, 27 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/ddr/lpddr3.txt b/Documentation/devicetree/bindings/ddr/lpddr3.txt
>>>> index 3b2485b84b3f..de0905239767 100644
>>>> --- a/Documentation/devicetree/bindings/ddr/lpddr3.txt
>>>> +++ b/Documentation/devicetree/bindings/ddr/lpddr3.txt
>>>> @@ -40,10 +40,34 @@ Child nodes:
>>>> a given speed-bin. Please see Documentation/devicetree/
>>>> bindings/ddr/lpddr3-timings.txt for more information on "lpddr3-timings"
>>>>
>>>> +Samsung K3QF2F20DB LPDDR3 memory
>>>> +------------------------------------------------------------
>>>> +
>>>> +This binding uses the LPDDR3 binding (described above)
>>>> +
>>>> +Required properties:
>>>> +- compatible: Should be:
>>>> + "samsung,K3QF2F20DB"
>>>> + followed by "jedec,lpddr3"
>>>> +- density : <u32> representing density in Mb (Mega bits)
>>>> +- io-width : <u32> representing bus width. Possible value 32
>>>> +- #address-cells: Must be set to 1
>>>> +- #size-cells: Must be set to 0
>>>
>>> If you decided to repeat all properties again, then it deserves its
>>> own bindings file. However I though about simpler solution - just
>>> document compatible. Exactly the same as AT24 or AT25 EEPROM bindings.
>>> There is not much benefit from copying all these properties.
>> OK, I see. I will add only 'compatible' and skip the rest then.
>> So the lpddr3.txt file will get this addition:
>>
>> +Samsung K3QF2F20DB LPDDR3 memory
>> +------------------------------------------------------------
>> +
>> +This binding uses the LPDDR3 binding (described above)
>> +
>> +Required properties:
>> +- compatible: Should be:
>> + "samsung,K3QF2F20DB"
>> + followed by "jedec,lpddr3"
>> +
>> +Optional properties:
>> +
>> +The optional properties are the same as in the LPDDR3 generic bindings and
>> +values should be taken from the data-sheet. Detailed bindings are described
>> +above.
>> +
>> +Child nodes:
>> +
>> +Detailed bindings are described in LPDDR3 generic bindings described above.
>> +
>>
>> Is it OK?
>
> To me it is still a lot of text just for one compatible and I can
> image more of such entries for other memories... However I do not mind
> and anyway, YAML will simplify it. If you're in doubt, wait for Rob's
> reply as this is his part.
You are definitely right, YAML will simplify this.
I will wait a few days with the v2 series, maybe Rob would like to see
something different. If not, I will send v2 with the above change.
Thank you for your comments.
Regards,
Lukasz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 3/3] dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories
2019-09-06 11:50 ` Krzysztof Kozlowski
2019-09-06 12:14 ` Lukasz Luba
@ 2019-09-13 14:36 ` Rob Herring
2019-09-16 9:49 ` Lukasz Luba
1 sibling, 1 reply; 12+ messages in thread
From: Rob Herring @ 2019-09-13 14:36 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: mark.rutland, devicetree, willy.mh.wolff.ml, linux-samsung-soc,
linux-pm, Bartłomiej Żołnierkiewicz, linux-kernel,
Lukasz Luba, Chanwoo Choi, kyungmin.park, kgene, myungjoo.ham,
s.nawrocki, linux-arm-kernel, Marek Szyprowski
On Fri, Sep 06, 2019 at 01:50:26PM +0200, Krzysztof Kozlowski wrote:
> On Fri, 6 Sep 2019 at 13:39, Lukasz Luba <l.luba@partner.samsung.com> wrote:
> >
> > Hi Krzysztof,
> >
> > On 9/6/19 12:56 PM, Krzysztof Kozlowski wrote:
> > > On Fri, 6 Sep 2019 at 12:14, Lukasz Luba <l.luba@partner.samsung.com> wrote:
> > >>
> > >> Add description of bindings for Samsung k3qf2f20db LPDDR3 memory.
> > >> Minor fixes in the old documentation.
> > >>
> > >> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
> > >> ---
> > >> .../devicetree/bindings/ddr/lpddr3.txt | 29 +++++++++++++++++--
> > >> 1 file changed, 27 insertions(+), 2 deletions(-)
> > >>
> > >> diff --git a/Documentation/devicetree/bindings/ddr/lpddr3.txt b/Documentation/devicetree/bindings/ddr/lpddr3.txt
> > >> index 3b2485b84b3f..de0905239767 100644
> > >> --- a/Documentation/devicetree/bindings/ddr/lpddr3.txt
> > >> +++ b/Documentation/devicetree/bindings/ddr/lpddr3.txt
> > >> @@ -40,10 +40,34 @@ Child nodes:
> > >> a given speed-bin. Please see Documentation/devicetree/
> > >> bindings/ddr/lpddr3-timings.txt for more information on "lpddr3-timings"
> > >>
> > >> +Samsung K3QF2F20DB LPDDR3 memory
> > >> +------------------------------------------------------------
> > >> +
> > >> +This binding uses the LPDDR3 binding (described above)
> > >> +
> > >> +Required properties:
> > >> +- compatible: Should be:
> > >> + "samsung,K3QF2F20DB"
> > >> + followed by "jedec,lpddr3"
> > >> +- density : <u32> representing density in Mb (Mega bits)
> > >> +- io-width : <u32> representing bus width. Possible value 32
> > >> +- #address-cells: Must be set to 1
> > >> +- #size-cells: Must be set to 0
> > >
> > > If you decided to repeat all properties again, then it deserves its
> > > own bindings file. However I though about simpler solution - just
> > > document compatible. Exactly the same as AT24 or AT25 EEPROM bindings.
> > > There is not much benefit from copying all these properties.
> > OK, I see. I will add only 'compatible' and skip the rest then.
> > So the lpddr3.txt file will get this addition:
> >
> > +Samsung K3QF2F20DB LPDDR3 memory
> > +------------------------------------------------------------
> > +
> > +This binding uses the LPDDR3 binding (described above)
> > +
> > +Required properties:
> > +- compatible: Should be:
> > + "samsung,K3QF2F20DB"
> > + followed by "jedec,lpddr3"
> > +
> > +Optional properties:
> > +
> > +The optional properties are the same as in the LPDDR3 generic bindings and
> > +values should be taken from the data-sheet. Detailed bindings are described
> > +above.
> > +
> > +Child nodes:
> > +
> > +Detailed bindings are described in LPDDR3 generic bindings described above.
> > +
> >
> > Is it OK?
>
> To me it is still a lot of text just for one compatible and I can
> image more of such entries for other memories... However I do not mind
> and anyway, YAML will simplify it. If you're in doubt, wait for Rob's
> reply as this is his part.
We can't have multiple (top-level) schema in one file, so better to add
in where the existing compatible strings are.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 3/3] dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories
2019-09-13 14:36 ` Rob Herring
@ 2019-09-16 9:49 ` Lukasz Luba
0 siblings, 0 replies; 12+ messages in thread
From: Lukasz Luba @ 2019-09-16 9:49 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: mark.rutland, devicetree, willy.mh.wolff.ml, linux-samsung-soc,
Bartłomiej Żołnierkiewicz, linux-pm, linux-kernel,
Chanwoo Choi, kyungmin.park, kgene, myungjoo.ham, s.nawrocki,
linux-arm-kernel, Marek Szyprowski
Hi Rob,
On 9/13/19 4:36 PM, Rob Herring wrote:
> On Fri, Sep 06, 2019 at 01:50:26PM +0200, Krzysztof Kozlowski wrote:
>> On Fri, 6 Sep 2019 at 13:39, Lukasz Luba <l.luba@partner.samsung.com> wrote:
>>>
>>> Hi Krzysztof,
>>>
>>> On 9/6/19 12:56 PM, Krzysztof Kozlowski wrote:
>>>> On Fri, 6 Sep 2019 at 12:14, Lukasz Luba <l.luba@partner.samsung.com> wrote:
>>>>>
>>>>> Add description of bindings for Samsung k3qf2f20db LPDDR3 memory.
>>>>> Minor fixes in the old documentation.
>>>>>
>>>>> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
>>>>> ---
>>>>> .../devicetree/bindings/ddr/lpddr3.txt | 29 +++++++++++++++++--
>>>>> 1 file changed, 27 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/ddr/lpddr3.txt b/Documentation/devicetree/bindings/ddr/lpddr3.txt
>>>>> index 3b2485b84b3f..de0905239767 100644
>>>>> --- a/Documentation/devicetree/bindings/ddr/lpddr3.txt
>>>>> +++ b/Documentation/devicetree/bindings/ddr/lpddr3.txt
>>>>> @@ -40,10 +40,34 @@ Child nodes:
>>>>> a given speed-bin. Please see Documentation/devicetree/
>>>>> bindings/ddr/lpddr3-timings.txt for more information on "lpddr3-timings"
>>>>>
>>>>> +Samsung K3QF2F20DB LPDDR3 memory
>>>>> +------------------------------------------------------------
>>>>> +
>>>>> +This binding uses the LPDDR3 binding (described above)
>>>>> +
>>>>> +Required properties:
>>>>> +- compatible: Should be:
>>>>> + "samsung,K3QF2F20DB"
>>>>> + followed by "jedec,lpddr3"
>>>>> +- density : <u32> representing density in Mb (Mega bits)
>>>>> +- io-width : <u32> representing bus width. Possible value 32
>>>>> +- #address-cells: Must be set to 1
>>>>> +- #size-cells: Must be set to 0
>>>>
>>>> If you decided to repeat all properties again, then it deserves its
>>>> own bindings file. However I though about simpler solution - just
>>>> document compatible. Exactly the same as AT24 or AT25 EEPROM bindings.
>>>> There is not much benefit from copying all these properties.
>>> OK, I see. I will add only 'compatible' and skip the rest then.
>>> So the lpddr3.txt file will get this addition:
>>>
>>> +Samsung K3QF2F20DB LPDDR3 memory
>>> +------------------------------------------------------------
>>> +
>>> +This binding uses the LPDDR3 binding (described above)
>>> +
>>> +Required properties:
>>> +- compatible: Should be:
>>> + "samsung,K3QF2F20DB"
>>> + followed by "jedec,lpddr3"
>>> +
>>> +Optional properties:
>>> +
>>> +The optional properties are the same as in the LPDDR3 generic bindings and
>>> +values should be taken from the data-sheet. Detailed bindings are described
>>> +above.
>>> +
>>> +Child nodes:
>>> +
>>> +Detailed bindings are described in LPDDR3 generic bindings described above.
>>> +
>>>
>>> Is it OK?
>>
>> To me it is still a lot of text just for one compatible and I can
>> image more of such entries for other memories... However I do not mind
>> and anyway, YAML will simplify it. If you're in doubt, wait for Rob's
>> reply as this is his part.
>
> We can't have multiple (top-level) schema in one file, so better to add
> in where the existing compatible strings are.
Thank you for your comment. I will add the needed string into existing
compatible then.
Regards,
Lukasz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-09-16 9:50 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190906101404eucas1p1d11e26276bfdacb7748f1391e29f45d0@eucas1p1.samsung.com>
2019-09-06 10:13 ` [PATCH 0/3] Exynos5 DMC minor fixes Lukasz Luba
[not found] ` <CGME20190906101405eucas1p2e3da7b461810a3a520e76c636a06e486@eucas1p2.samsung.com>
2019-09-06 10:13 ` [PATCH 1/3] memory: Exynos5422: minor fixes in DMC Lukasz Luba
2019-09-06 10:51 ` Krzysztof Kozlowski
2019-09-06 11:43 ` Lukasz Luba
[not found] ` <CGME20190906101406eucas1p289695a398d757b116367257293c3544d@eucas1p2.samsung.com>
2019-09-06 10:13 ` [PATCH 2/3] ARM: dts: exynos: fix too long line in memory device Lukasz Luba
[not found] ` <CGME20190906101407eucas1p15eb0df53374b27497b4793eab24becf6@eucas1p1.samsung.com>
2019-09-06 10:13 ` [PATCH 3/3] dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories Lukasz Luba
2019-09-06 10:56 ` Krzysztof Kozlowski
2019-09-06 11:39 ` Lukasz Luba
2019-09-06 11:50 ` Krzysztof Kozlowski
2019-09-06 12:14 ` Lukasz Luba
2019-09-13 14:36 ` Rob Herring
2019-09-16 9:49 ` Lukasz Luba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).