linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: rockchip: remove rk3288 fennec board support
@ 2019-08-20 10:03 Kever Yang
  2019-08-20 13:56 ` Heiko Stuebner
  0 siblings, 1 reply; 3+ messages in thread
From: Kever Yang @ 2019-08-20 10:03 UTC (permalink / raw)
  To: heiko
  Cc: Mark Rutland, devicetree, Kever Yang, linux-kernel,
	linux-rockchip, Rob Herring, linux-arm-kernel

Since there is no one using this board, remove it.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

 arch/arm/boot/dts/rk3288-fennec.dts | 347 ----------------------------
 1 file changed, 347 deletions(-)
 delete mode 100644 arch/arm/boot/dts/rk3288-fennec.dts

diff --git a/arch/arm/boot/dts/rk3288-fennec.dts b/arch/arm/boot/dts/rk3288-fennec.dts
deleted file mode 100644
index 4847cf902a15..000000000000
--- a/arch/arm/boot/dts/rk3288-fennec.dts
+++ /dev/null
@@ -1,347 +0,0 @@
-// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
-
-/dts-v1/;
-
-#include "rk3288.dtsi"
-
-/ {
-	model = "Rockchip RK3288 Fennec Board";
-	compatible = "rockchip,rk3288-fennec", "rockchip,rk3288";
-
-	memory@0 {
-		reg = <0x0 0x0 0x0 0x80000000>;
-		device_type = "memory";
-	};
-
-	ext_gmac: external-gmac-clock {
-		compatible = "fixed-clock";
-		#clock-cells = <0>;
-		clock-frequency = <125000000>;
-		clock-output-names = "ext_gmac";
-	};
-
-	vcc_sys: vsys-regulator {
-		compatible = "regulator-fixed";
-		regulator-name = "vcc_sys";
-		regulator-min-microvolt = <5000000>;
-		regulator-max-microvolt = <5000000>;
-		regulator-always-on;
-		regulator-boot-on;
-	};
-};
-
-&cpu0 {
-	cpu0-supply = <&vdd_cpu>;
-};
-
-&emmc {
-	bus-width = <8>;
-	cap-mmc-highspeed;
-	non-removable;
-	pinctrl-names = "default";
-	pinctrl-0 = <&emmc_clk &emmc_cmd &emmc_pwr &emmc_bus8>;
-	status = "okay";
-};
-
-&gmac {
-	assigned-clocks = <&cru SCLK_MAC>;
-	assigned-clock-parents = <&ext_gmac>;
-	clock_in_out = "input";
-	pinctrl-names = "default";
-	pinctrl-0 = <&rgmii_pins>, <&phy_rst>, <&phy_pmeb>, <&phy_int>;
-	phy-supply = <&vcc_lan>;
-	phy-mode = "rgmii";
-	snps,reset-active-low;
-	snps,reset-delays-us = <0 10000 1000000>;
-	snps,reset-gpio = <&gpio4 RK_PB0 GPIO_ACTIVE_LOW>;
-	tx_delay = <0x30>;
-	rx_delay = <0x10>;
-	status = "okay";
-};
-
-&gpu {
-	mali-supply = <&vdd_gpu>;
-	status = "okay";
-};
-
-&hdmi {
-	status = "okay";
-};
-
-&i2c0 {
-	status = "okay";
-	clock-frequency = <400000>;
-
-	rk808: pmic@1b {
-		compatible = "rockchip,rk808";
-		reg = <0x1b>;
-		interrupt-parent = <&gpio0>;
-		interrupts = <RK_PA4 IRQ_TYPE_LEVEL_LOW>;
-		#clock-cells = <1>;
-		clock-output-names = "xin32k", "rk808-clkout2";
-		pinctrl-names = "default";
-		pinctrl-0 = <&pmic_int &global_pwroff>;
-		rockchip,system-power-controller;
-		wakeup-source;
-
-		vcc1-supply = <&vcc_sys>;
-		vcc2-supply = <&vcc_sys>;
-		vcc3-supply = <&vcc_sys>;
-		vcc4-supply = <&vcc_sys>;
-		vcc6-supply = <&vcc_sys>;
-		vcc7-supply = <&vcc_sys>;
-		vcc8-supply = <&vcc_io>;
-		vcc9-supply = <&vcc_io>;
-		vcc10-supply = <&vcc_io>;
-		vcc11-supply = <&vcc_io>;
-		vcc12-supply = <&vcc_io>;
-		vddio-supply = <&vcc_io>;
-
-		regulators {
-			vdd_cpu: DCDC_REG1 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <750000>;
-				regulator-max-microvolt = <1350000>;
-				regulator-name = "vdd_arm";
-				regulator-state-mem {
-					regulator-off-in-suspend;
-				};
-			};
-
-			vdd_gpu: DCDC_REG2 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <850000>;
-				regulator-max-microvolt = <1250000>;
-				regulator-name = "vdd_gpu";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <1000000>;
-				};
-			};
-
-			vcc_ddr: DCDC_REG3 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-name = "vcc_ddr";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-				};
-			};
-
-			vcc_io: DCDC_REG4 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <3300000>;
-				regulator-max-microvolt = <3300000>;
-				regulator-name = "vcc_io";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <3300000>;
-				};
-			};
-
-			vccio_pmu: LDO_REG1 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <3300000>;
-				regulator-max-microvolt = <3300000>;
-				regulator-name = "vccio_pmu";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <3300000>;
-				};
-			};
-
-			vcca_33: LDO_REG2 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <3300000>;
-				regulator-max-microvolt = <3300000>;
-				regulator-name = "vcca_33";
-				regulator-state-mem {
-					regulator-off-in-suspend;
-				};
-			};
-
-			vdd_10: LDO_REG3 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <1000000>;
-				regulator-max-microvolt = <1000000>;
-				regulator-name = "vdd_10";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <1000000>;
-				};
-			};
-
-			vcc_wl: LDO_REG4 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <1800000>;
-				regulator-max-microvolt = <1800000>;
-				regulator-name = "vcc_wl";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <1800000>;
-				};
-			};
-
-			vccio_sd: LDO_REG5 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <1800000>;
-				regulator-max-microvolt = <3300000>;
-				regulator-name = "vccio_sd";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <3300000>;
-				};
-			};
-
-			vdd10_lcd: LDO_REG6 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <1000000>;
-				regulator-max-microvolt = <1000000>;
-				regulator-name = "vdd10_lcd";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <1000000>;
-				};
-			};
-
-			vcc_18: LDO_REG7 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <1800000>;
-				regulator-max-microvolt = <1800000>;
-				regulator-name = "vcc_18";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <1800000>;
-				};
-			};
-
-			vcc18_lcd: LDO_REG8 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <1800000>;
-				regulator-max-microvolt = <1800000>;
-				regulator-name = "vcc18_lcd";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <1800000>;
-				};
-			};
-
-			vcc_sd: SWITCH_REG1 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-name = "vcc_sd";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-				};
-			};
-
-			vcc_lan: SWITCH_REG2 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-name = "vcc_lan";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-				};
-			};
-		};
-	};
-};
-
-&pinctrl {
-	pcfg_output_high: pcfg-output-high {
-		output-high;
-	};
-
-	pcfg_output_low: pcfg-output-low {
-		output-low;
-	};
-
-	pcfg_pull_none_drv_8ma: pcfg-pull-none-drv-8ma {
-		drive-strength = <8>;
-	};
-
-	pcfg_pull_up_drv_8ma: pcfg-pull-up-drv-8ma {
-		bias-pull-up;
-		drive-strength = <8>;
-	};
-
-	gmac {
-		phy_int: phy-int {
-			rockchip,pins = <0 RK_PB1 RK_FUNC_GPIO &pcfg_pull_up>;
-		};
-
-		phy_pmeb: phy-pmeb {
-			rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>;
-		};
-
-		phy_rst: phy-rst {
-			rockchip,pins = <4 RK_PB0 RK_FUNC_GPIO &pcfg_output_high>;
-		};
-	};
-
-	pmic {
-		pmic_int: pmic-int {
-			rockchip,pins = <0 RK_PA4 RK_FUNC_GPIO &pcfg_pull_up>;
-		};
-	};
-
-	usbphy {
-		host_drv: host-drv {
-			rockchip,pins = <0 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
-		};
-	};
-};
-
-&uart2 {
-	status = "okay";
-};
-
-&usbphy {
-	pinctrl-names = "default";
-	pinctrl-0 = <&host_drv>;
-	vbus_drv-gpios = <&gpio0 RK_PB6 GPIO_ACTIVE_HIGH>;
-	status = "okay";
-};
-
-&usb_host0_ehci {
-	status = "okay";
-};
-
-&usb_host1 {
-	status = "okay";
-};
-
-&usb_otg {
-	status = "okay";
-};
-
-&usb_hsic {
-	status = "okay";
-};
-
-&vopb {
-	status = "okay";
-};
-
-&vopb_mmu {
-	status = "okay";
-};
-
-&vopl {
-	status = "okay";
-};
-
-&vopl_mmu {
-	status = "okay";
-};
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: rockchip: remove rk3288 fennec board support
  2019-08-20 10:03 [PATCH] ARM: dts: rockchip: remove rk3288 fennec board support Kever Yang
@ 2019-08-20 13:56 ` Heiko Stuebner
  2019-08-21  3:01   ` Kever Yang
  0 siblings, 1 reply; 3+ messages in thread
From: Heiko Stuebner @ 2019-08-20 13:56 UTC (permalink / raw)
  To: Kever Yang
  Cc: Mark Rutland, devicetree, linux-kernel, linux-rockchip,
	Rob Herring, linux-arm-kernel

Hi Kever,

Am Dienstag, 20. August 2019, 12:03:52 CEST schrieb Kever Yang:
> Since there is no one using this board, remove it.

so just to elaborate a bit, I guess this board was internal to Rockchip,
never went to the market and therefore is obsolete without any users,
right?

Also we should remove the binding  from
	Documentation/devicetree/bindings/arm/rockchip.yaml as well


Heiko


> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
>  arch/arm/boot/dts/rk3288-fennec.dts | 347 ----------------------------
>  1 file changed, 347 deletions(-)
>  delete mode 100644 arch/arm/boot/dts/rk3288-fennec.dts
> 
> diff --git a/arch/arm/boot/dts/rk3288-fennec.dts b/arch/arm/boot/dts/rk3288-fennec.dts
> deleted file mode 100644
> index 4847cf902a15..000000000000
> --- a/arch/arm/boot/dts/rk3288-fennec.dts
> +++ /dev/null
> @@ -1,347 +0,0 @@
> -// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> -
> -/dts-v1/;
> -
> -#include "rk3288.dtsi"
> -
> -/ {
> -	model = "Rockchip RK3288 Fennec Board";
> -	compatible = "rockchip,rk3288-fennec", "rockchip,rk3288";
> -
> -	memory@0 {
> -		reg = <0x0 0x0 0x0 0x80000000>;
> -		device_type = "memory";
> -	};
> -
> -	ext_gmac: external-gmac-clock {
> -		compatible = "fixed-clock";
> -		#clock-cells = <0>;
> -		clock-frequency = <125000000>;
> -		clock-output-names = "ext_gmac";
> -	};
> -
> -	vcc_sys: vsys-regulator {
> -		compatible = "regulator-fixed";
> -		regulator-name = "vcc_sys";
> -		regulator-min-microvolt = <5000000>;
> -		regulator-max-microvolt = <5000000>;
> -		regulator-always-on;
> -		regulator-boot-on;
> -	};
> -};
> -
> -&cpu0 {
> -	cpu0-supply = <&vdd_cpu>;
> -};
> -
> -&emmc {
> -	bus-width = <8>;
> -	cap-mmc-highspeed;
> -	non-removable;
> -	pinctrl-names = "default";
> -	pinctrl-0 = <&emmc_clk &emmc_cmd &emmc_pwr &emmc_bus8>;
> -	status = "okay";
> -};
> -
> -&gmac {
> -	assigned-clocks = <&cru SCLK_MAC>;
> -	assigned-clock-parents = <&ext_gmac>;
> -	clock_in_out = "input";
> -	pinctrl-names = "default";
> -	pinctrl-0 = <&rgmii_pins>, <&phy_rst>, <&phy_pmeb>, <&phy_int>;
> -	phy-supply = <&vcc_lan>;
> -	phy-mode = "rgmii";
> -	snps,reset-active-low;
> -	snps,reset-delays-us = <0 10000 1000000>;
> -	snps,reset-gpio = <&gpio4 RK_PB0 GPIO_ACTIVE_LOW>;
> -	tx_delay = <0x30>;
> -	rx_delay = <0x10>;
> -	status = "okay";
> -};
> -
> -&gpu {
> -	mali-supply = <&vdd_gpu>;
> -	status = "okay";
> -};
> -
> -&hdmi {
> -	status = "okay";
> -};
> -
> -&i2c0 {
> -	status = "okay";
> -	clock-frequency = <400000>;
> -
> -	rk808: pmic@1b {
> -		compatible = "rockchip,rk808";
> -		reg = <0x1b>;
> -		interrupt-parent = <&gpio0>;
> -		interrupts = <RK_PA4 IRQ_TYPE_LEVEL_LOW>;
> -		#clock-cells = <1>;
> -		clock-output-names = "xin32k", "rk808-clkout2";
> -		pinctrl-names = "default";
> -		pinctrl-0 = <&pmic_int &global_pwroff>;
> -		rockchip,system-power-controller;
> -		wakeup-source;
> -
> -		vcc1-supply = <&vcc_sys>;
> -		vcc2-supply = <&vcc_sys>;
> -		vcc3-supply = <&vcc_sys>;
> -		vcc4-supply = <&vcc_sys>;
> -		vcc6-supply = <&vcc_sys>;
> -		vcc7-supply = <&vcc_sys>;
> -		vcc8-supply = <&vcc_io>;
> -		vcc9-supply = <&vcc_io>;
> -		vcc10-supply = <&vcc_io>;
> -		vcc11-supply = <&vcc_io>;
> -		vcc12-supply = <&vcc_io>;
> -		vddio-supply = <&vcc_io>;
> -
> -		regulators {
> -			vdd_cpu: DCDC_REG1 {
> -				regulator-always-on;
> -				regulator-boot-on;
> -				regulator-min-microvolt = <750000>;
> -				regulator-max-microvolt = <1350000>;
> -				regulator-name = "vdd_arm";
> -				regulator-state-mem {
> -					regulator-off-in-suspend;
> -				};
> -			};
> -
> -			vdd_gpu: DCDC_REG2 {
> -				regulator-always-on;
> -				regulator-boot-on;
> -				regulator-min-microvolt = <850000>;
> -				regulator-max-microvolt = <1250000>;
> -				regulator-name = "vdd_gpu";
> -				regulator-state-mem {
> -					regulator-on-in-suspend;
> -					regulator-suspend-microvolt = <1000000>;
> -				};
> -			};
> -
> -			vcc_ddr: DCDC_REG3 {
> -				regulator-always-on;
> -				regulator-boot-on;
> -				regulator-name = "vcc_ddr";
> -				regulator-state-mem {
> -					regulator-on-in-suspend;
> -				};
> -			};
> -
> -			vcc_io: DCDC_REG4 {
> -				regulator-always-on;
> -				regulator-boot-on;
> -				regulator-min-microvolt = <3300000>;
> -				regulator-max-microvolt = <3300000>;
> -				regulator-name = "vcc_io";
> -				regulator-state-mem {
> -					regulator-on-in-suspend;
> -					regulator-suspend-microvolt = <3300000>;
> -				};
> -			};
> -
> -			vccio_pmu: LDO_REG1 {
> -				regulator-always-on;
> -				regulator-boot-on;
> -				regulator-min-microvolt = <3300000>;
> -				regulator-max-microvolt = <3300000>;
> -				regulator-name = "vccio_pmu";
> -				regulator-state-mem {
> -					regulator-on-in-suspend;
> -					regulator-suspend-microvolt = <3300000>;
> -				};
> -			};
> -
> -			vcca_33: LDO_REG2 {
> -				regulator-always-on;
> -				regulator-boot-on;
> -				regulator-min-microvolt = <3300000>;
> -				regulator-max-microvolt = <3300000>;
> -				regulator-name = "vcca_33";
> -				regulator-state-mem {
> -					regulator-off-in-suspend;
> -				};
> -			};
> -
> -			vdd_10: LDO_REG3 {
> -				regulator-always-on;
> -				regulator-boot-on;
> -				regulator-min-microvolt = <1000000>;
> -				regulator-max-microvolt = <1000000>;
> -				regulator-name = "vdd_10";
> -				regulator-state-mem {
> -					regulator-on-in-suspend;
> -					regulator-suspend-microvolt = <1000000>;
> -				};
> -			};
> -
> -			vcc_wl: LDO_REG4 {
> -				regulator-always-on;
> -				regulator-boot-on;
> -				regulator-min-microvolt = <1800000>;
> -				regulator-max-microvolt = <1800000>;
> -				regulator-name = "vcc_wl";
> -				regulator-state-mem {
> -					regulator-on-in-suspend;
> -					regulator-suspend-microvolt = <1800000>;
> -				};
> -			};
> -
> -			vccio_sd: LDO_REG5 {
> -				regulator-always-on;
> -				regulator-boot-on;
> -				regulator-min-microvolt = <1800000>;
> -				regulator-max-microvolt = <3300000>;
> -				regulator-name = "vccio_sd";
> -				regulator-state-mem {
> -					regulator-on-in-suspend;
> -					regulator-suspend-microvolt = <3300000>;
> -				};
> -			};
> -
> -			vdd10_lcd: LDO_REG6 {
> -				regulator-always-on;
> -				regulator-boot-on;
> -				regulator-min-microvolt = <1000000>;
> -				regulator-max-microvolt = <1000000>;
> -				regulator-name = "vdd10_lcd";
> -				regulator-state-mem {
> -					regulator-on-in-suspend;
> -					regulator-suspend-microvolt = <1000000>;
> -				};
> -			};
> -
> -			vcc_18: LDO_REG7 {
> -				regulator-always-on;
> -				regulator-boot-on;
> -				regulator-min-microvolt = <1800000>;
> -				regulator-max-microvolt = <1800000>;
> -				regulator-name = "vcc_18";
> -				regulator-state-mem {
> -					regulator-on-in-suspend;
> -					regulator-suspend-microvolt = <1800000>;
> -				};
> -			};
> -
> -			vcc18_lcd: LDO_REG8 {
> -				regulator-always-on;
> -				regulator-boot-on;
> -				regulator-min-microvolt = <1800000>;
> -				regulator-max-microvolt = <1800000>;
> -				regulator-name = "vcc18_lcd";
> -				regulator-state-mem {
> -					regulator-on-in-suspend;
> -					regulator-suspend-microvolt = <1800000>;
> -				};
> -			};
> -
> -			vcc_sd: SWITCH_REG1 {
> -				regulator-always-on;
> -				regulator-boot-on;
> -				regulator-name = "vcc_sd";
> -				regulator-state-mem {
> -					regulator-on-in-suspend;
> -				};
> -			};
> -
> -			vcc_lan: SWITCH_REG2 {
> -				regulator-always-on;
> -				regulator-boot-on;
> -				regulator-name = "vcc_lan";
> -				regulator-state-mem {
> -					regulator-on-in-suspend;
> -				};
> -			};
> -		};
> -	};
> -};
> -
> -&pinctrl {
> -	pcfg_output_high: pcfg-output-high {
> -		output-high;
> -	};
> -
> -	pcfg_output_low: pcfg-output-low {
> -		output-low;
> -	};
> -
> -	pcfg_pull_none_drv_8ma: pcfg-pull-none-drv-8ma {
> -		drive-strength = <8>;
> -	};
> -
> -	pcfg_pull_up_drv_8ma: pcfg-pull-up-drv-8ma {
> -		bias-pull-up;
> -		drive-strength = <8>;
> -	};
> -
> -	gmac {
> -		phy_int: phy-int {
> -			rockchip,pins = <0 RK_PB1 RK_FUNC_GPIO &pcfg_pull_up>;
> -		};
> -
> -		phy_pmeb: phy-pmeb {
> -			rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>;
> -		};
> -
> -		phy_rst: phy-rst {
> -			rockchip,pins = <4 RK_PB0 RK_FUNC_GPIO &pcfg_output_high>;
> -		};
> -	};
> -
> -	pmic {
> -		pmic_int: pmic-int {
> -			rockchip,pins = <0 RK_PA4 RK_FUNC_GPIO &pcfg_pull_up>;
> -		};
> -	};
> -
> -	usbphy {
> -		host_drv: host-drv {
> -			rockchip,pins = <0 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
> -		};
> -	};
> -};
> -
> -&uart2 {
> -	status = "okay";
> -};
> -
> -&usbphy {
> -	pinctrl-names = "default";
> -	pinctrl-0 = <&host_drv>;
> -	vbus_drv-gpios = <&gpio0 RK_PB6 GPIO_ACTIVE_HIGH>;
> -	status = "okay";
> -};
> -
> -&usb_host0_ehci {
> -	status = "okay";
> -};
> -
> -&usb_host1 {
> -	status = "okay";
> -};
> -
> -&usb_otg {
> -	status = "okay";
> -};
> -
> -&usb_hsic {
> -	status = "okay";
> -};
> -
> -&vopb {
> -	status = "okay";
> -};
> -
> -&vopb_mmu {
> -	status = "okay";
> -};
> -
> -&vopl {
> -	status = "okay";
> -};
> -
> -&vopl_mmu {
> -	status = "okay";
> -};
> 





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: rockchip: remove rk3288 fennec board support
  2019-08-20 13:56 ` Heiko Stuebner
@ 2019-08-21  3:01   ` Kever Yang
  0 siblings, 0 replies; 3+ messages in thread
From: Kever Yang @ 2019-08-21  3:01 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Mark Rutland, devicetree, linux-kernel, linux-rockchip,
	Rob Herring, linux-arm-kernel


On 2019/8/20 下午9:56, Heiko Stuebner wrote:
> Hi Kever,
>
> Am Dienstag, 20. August 2019, 12:03:52 CEST schrieb Kever Yang:
>> Since there is no one using this board, remove it.
> so just to elaborate a bit, I guess this board was internal to Rockchip,
> never went to the market and therefore is obsolete without any users,
> right?


Yes, even if there is someone using this board, they don't use upstream 
source code, you can see

there is only one commit relate to board itself, but never update. So I 
would like to remove it

from kernel and U-Boot upstream.

>
> Also we should remove the binding  from
> 	Documentation/devicetree/bindings/arm/rockchip.yaml as well

Will update.


Thanks,

- Kever

>
>
> Heiko
>
>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> ---
>>
>>   arch/arm/boot/dts/rk3288-fennec.dts | 347 ----------------------------
>>   1 file changed, 347 deletions(-)
>>   delete mode 100644 arch/arm/boot/dts/rk3288-fennec.dts
>>
>> diff --git a/arch/arm/boot/dts/rk3288-fennec.dts b/arch/arm/boot/dts/rk3288-fennec.dts
>> deleted file mode 100644
>> index 4847cf902a15..000000000000
>> --- a/arch/arm/boot/dts/rk3288-fennec.dts
>> +++ /dev/null
>> @@ -1,347 +0,0 @@
>> -// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> -
>> -/dts-v1/;
>> -
>> -#include "rk3288.dtsi"
>> -
>> -/ {
>> -	model = "Rockchip RK3288 Fennec Board";
>> -	compatible = "rockchip,rk3288-fennec", "rockchip,rk3288";
>> -
>> -	memory@0 {
>> -		reg = <0x0 0x0 0x0 0x80000000>;
>> -		device_type = "memory";
>> -	};
>> -
>> -	ext_gmac: external-gmac-clock {
>> -		compatible = "fixed-clock";
>> -		#clock-cells = <0>;
>> -		clock-frequency = <125000000>;
>> -		clock-output-names = "ext_gmac";
>> -	};
>> -
>> -	vcc_sys: vsys-regulator {
>> -		compatible = "regulator-fixed";
>> -		regulator-name = "vcc_sys";
>> -		regulator-min-microvolt = <5000000>;
>> -		regulator-max-microvolt = <5000000>;
>> -		regulator-always-on;
>> -		regulator-boot-on;
>> -	};
>> -};
>> -
>> -&cpu0 {
>> -	cpu0-supply = <&vdd_cpu>;
>> -};
>> -
>> -&emmc {
>> -	bus-width = <8>;
>> -	cap-mmc-highspeed;
>> -	non-removable;
>> -	pinctrl-names = "default";
>> -	pinctrl-0 = <&emmc_clk &emmc_cmd &emmc_pwr &emmc_bus8>;
>> -	status = "okay";
>> -};
>> -
>> -&gmac {
>> -	assigned-clocks = <&cru SCLK_MAC>;
>> -	assigned-clock-parents = <&ext_gmac>;
>> -	clock_in_out = "input";
>> -	pinctrl-names = "default";
>> -	pinctrl-0 = <&rgmii_pins>, <&phy_rst>, <&phy_pmeb>, <&phy_int>;
>> -	phy-supply = <&vcc_lan>;
>> -	phy-mode = "rgmii";
>> -	snps,reset-active-low;
>> -	snps,reset-delays-us = <0 10000 1000000>;
>> -	snps,reset-gpio = <&gpio4 RK_PB0 GPIO_ACTIVE_LOW>;
>> -	tx_delay = <0x30>;
>> -	rx_delay = <0x10>;
>> -	status = "okay";
>> -};
>> -
>> -&gpu {
>> -	mali-supply = <&vdd_gpu>;
>> -	status = "okay";
>> -};
>> -
>> -&hdmi {
>> -	status = "okay";
>> -};
>> -
>> -&i2c0 {
>> -	status = "okay";
>> -	clock-frequency = <400000>;
>> -
>> -	rk808: pmic@1b {
>> -		compatible = "rockchip,rk808";
>> -		reg = <0x1b>;
>> -		interrupt-parent = <&gpio0>;
>> -		interrupts = <RK_PA4 IRQ_TYPE_LEVEL_LOW>;
>> -		#clock-cells = <1>;
>> -		clock-output-names = "xin32k", "rk808-clkout2";
>> -		pinctrl-names = "default";
>> -		pinctrl-0 = <&pmic_int &global_pwroff>;
>> -		rockchip,system-power-controller;
>> -		wakeup-source;
>> -
>> -		vcc1-supply = <&vcc_sys>;
>> -		vcc2-supply = <&vcc_sys>;
>> -		vcc3-supply = <&vcc_sys>;
>> -		vcc4-supply = <&vcc_sys>;
>> -		vcc6-supply = <&vcc_sys>;
>> -		vcc7-supply = <&vcc_sys>;
>> -		vcc8-supply = <&vcc_io>;
>> -		vcc9-supply = <&vcc_io>;
>> -		vcc10-supply = <&vcc_io>;
>> -		vcc11-supply = <&vcc_io>;
>> -		vcc12-supply = <&vcc_io>;
>> -		vddio-supply = <&vcc_io>;
>> -
>> -		regulators {
>> -			vdd_cpu: DCDC_REG1 {
>> -				regulator-always-on;
>> -				regulator-boot-on;
>> -				regulator-min-microvolt = <750000>;
>> -				regulator-max-microvolt = <1350000>;
>> -				regulator-name = "vdd_arm";
>> -				regulator-state-mem {
>> -					regulator-off-in-suspend;
>> -				};
>> -			};
>> -
>> -			vdd_gpu: DCDC_REG2 {
>> -				regulator-always-on;
>> -				regulator-boot-on;
>> -				regulator-min-microvolt = <850000>;
>> -				regulator-max-microvolt = <1250000>;
>> -				regulator-name = "vdd_gpu";
>> -				regulator-state-mem {
>> -					regulator-on-in-suspend;
>> -					regulator-suspend-microvolt = <1000000>;
>> -				};
>> -			};
>> -
>> -			vcc_ddr: DCDC_REG3 {
>> -				regulator-always-on;
>> -				regulator-boot-on;
>> -				regulator-name = "vcc_ddr";
>> -				regulator-state-mem {
>> -					regulator-on-in-suspend;
>> -				};
>> -			};
>> -
>> -			vcc_io: DCDC_REG4 {
>> -				regulator-always-on;
>> -				regulator-boot-on;
>> -				regulator-min-microvolt = <3300000>;
>> -				regulator-max-microvolt = <3300000>;
>> -				regulator-name = "vcc_io";
>> -				regulator-state-mem {
>> -					regulator-on-in-suspend;
>> -					regulator-suspend-microvolt = <3300000>;
>> -				};
>> -			};
>> -
>> -			vccio_pmu: LDO_REG1 {
>> -				regulator-always-on;
>> -				regulator-boot-on;
>> -				regulator-min-microvolt = <3300000>;
>> -				regulator-max-microvolt = <3300000>;
>> -				regulator-name = "vccio_pmu";
>> -				regulator-state-mem {
>> -					regulator-on-in-suspend;
>> -					regulator-suspend-microvolt = <3300000>;
>> -				};
>> -			};
>> -
>> -			vcca_33: LDO_REG2 {
>> -				regulator-always-on;
>> -				regulator-boot-on;
>> -				regulator-min-microvolt = <3300000>;
>> -				regulator-max-microvolt = <3300000>;
>> -				regulator-name = "vcca_33";
>> -				regulator-state-mem {
>> -					regulator-off-in-suspend;
>> -				};
>> -			};
>> -
>> -			vdd_10: LDO_REG3 {
>> -				regulator-always-on;
>> -				regulator-boot-on;
>> -				regulator-min-microvolt = <1000000>;
>> -				regulator-max-microvolt = <1000000>;
>> -				regulator-name = "vdd_10";
>> -				regulator-state-mem {
>> -					regulator-on-in-suspend;
>> -					regulator-suspend-microvolt = <1000000>;
>> -				};
>> -			};
>> -
>> -			vcc_wl: LDO_REG4 {
>> -				regulator-always-on;
>> -				regulator-boot-on;
>> -				regulator-min-microvolt = <1800000>;
>> -				regulator-max-microvolt = <1800000>;
>> -				regulator-name = "vcc_wl";
>> -				regulator-state-mem {
>> -					regulator-on-in-suspend;
>> -					regulator-suspend-microvolt = <1800000>;
>> -				};
>> -			};
>> -
>> -			vccio_sd: LDO_REG5 {
>> -				regulator-always-on;
>> -				regulator-boot-on;
>> -				regulator-min-microvolt = <1800000>;
>> -				regulator-max-microvolt = <3300000>;
>> -				regulator-name = "vccio_sd";
>> -				regulator-state-mem {
>> -					regulator-on-in-suspend;
>> -					regulator-suspend-microvolt = <3300000>;
>> -				};
>> -			};
>> -
>> -			vdd10_lcd: LDO_REG6 {
>> -				regulator-always-on;
>> -				regulator-boot-on;
>> -				regulator-min-microvolt = <1000000>;
>> -				regulator-max-microvolt = <1000000>;
>> -				regulator-name = "vdd10_lcd";
>> -				regulator-state-mem {
>> -					regulator-on-in-suspend;
>> -					regulator-suspend-microvolt = <1000000>;
>> -				};
>> -			};
>> -
>> -			vcc_18: LDO_REG7 {
>> -				regulator-always-on;
>> -				regulator-boot-on;
>> -				regulator-min-microvolt = <1800000>;
>> -				regulator-max-microvolt = <1800000>;
>> -				regulator-name = "vcc_18";
>> -				regulator-state-mem {
>> -					regulator-on-in-suspend;
>> -					regulator-suspend-microvolt = <1800000>;
>> -				};
>> -			};
>> -
>> -			vcc18_lcd: LDO_REG8 {
>> -				regulator-always-on;
>> -				regulator-boot-on;
>> -				regulator-min-microvolt = <1800000>;
>> -				regulator-max-microvolt = <1800000>;
>> -				regulator-name = "vcc18_lcd";
>> -				regulator-state-mem {
>> -					regulator-on-in-suspend;
>> -					regulator-suspend-microvolt = <1800000>;
>> -				};
>> -			};
>> -
>> -			vcc_sd: SWITCH_REG1 {
>> -				regulator-always-on;
>> -				regulator-boot-on;
>> -				regulator-name = "vcc_sd";
>> -				regulator-state-mem {
>> -					regulator-on-in-suspend;
>> -				};
>> -			};
>> -
>> -			vcc_lan: SWITCH_REG2 {
>> -				regulator-always-on;
>> -				regulator-boot-on;
>> -				regulator-name = "vcc_lan";
>> -				regulator-state-mem {
>> -					regulator-on-in-suspend;
>> -				};
>> -			};
>> -		};
>> -	};
>> -};
>> -
>> -&pinctrl {
>> -	pcfg_output_high: pcfg-output-high {
>> -		output-high;
>> -	};
>> -
>> -	pcfg_output_low: pcfg-output-low {
>> -		output-low;
>> -	};
>> -
>> -	pcfg_pull_none_drv_8ma: pcfg-pull-none-drv-8ma {
>> -		drive-strength = <8>;
>> -	};
>> -
>> -	pcfg_pull_up_drv_8ma: pcfg-pull-up-drv-8ma {
>> -		bias-pull-up;
>> -		drive-strength = <8>;
>> -	};
>> -
>> -	gmac {
>> -		phy_int: phy-int {
>> -			rockchip,pins = <0 RK_PB1 RK_FUNC_GPIO &pcfg_pull_up>;
>> -		};
>> -
>> -		phy_pmeb: phy-pmeb {
>> -			rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>;
>> -		};
>> -
>> -		phy_rst: phy-rst {
>> -			rockchip,pins = <4 RK_PB0 RK_FUNC_GPIO &pcfg_output_high>;
>> -		};
>> -	};
>> -
>> -	pmic {
>> -		pmic_int: pmic-int {
>> -			rockchip,pins = <0 RK_PA4 RK_FUNC_GPIO &pcfg_pull_up>;
>> -		};
>> -	};
>> -
>> -	usbphy {
>> -		host_drv: host-drv {
>> -			rockchip,pins = <0 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
>> -		};
>> -	};
>> -};
>> -
>> -&uart2 {
>> -	status = "okay";
>> -};
>> -
>> -&usbphy {
>> -	pinctrl-names = "default";
>> -	pinctrl-0 = <&host_drv>;
>> -	vbus_drv-gpios = <&gpio0 RK_PB6 GPIO_ACTIVE_HIGH>;
>> -	status = "okay";
>> -};
>> -
>> -&usb_host0_ehci {
>> -	status = "okay";
>> -};
>> -
>> -&usb_host1 {
>> -	status = "okay";
>> -};
>> -
>> -&usb_otg {
>> -	status = "okay";
>> -};
>> -
>> -&usb_hsic {
>> -	status = "okay";
>> -};
>> -
>> -&vopb {
>> -	status = "okay";
>> -};
>> -
>> -&vopb_mmu {
>> -	status = "okay";
>> -};
>> -
>> -&vopl {
>> -	status = "okay";
>> -};
>> -
>> -&vopl_mmu {
>> -	status = "okay";
>> -};
>>
>
>
>
>



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-08-21  3:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-20 10:03 [PATCH] ARM: dts: rockchip: remove rk3288 fennec board support Kever Yang
2019-08-20 13:56 ` Heiko Stuebner
2019-08-21  3:01   ` Kever Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).