linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: zynqmp: Add compatible strings for si5328
@ 2021-03-08  7:08 quanyang.wang
  2021-03-08  8:35 ` Laurent Pinchart
  0 siblings, 1 reply; 5+ messages in thread
From: quanyang.wang @ 2021-03-08  7:08 UTC (permalink / raw)
  To: Rob Herring, Michal Simek
  Cc: Krzysztof Kozlowski, Laurent Pinchart, devicetree,
	linux-arm-kernel, linux-kernel

From: Quanyang Wang <quanyang.wang@windriver.com>

The function of_i2c_get_board_info will call of_modalias_node to check
if a device_node contains "compatible" string. So let's assign the
proper string "silabs,si5328" to clock-generator@69's compatible
property to eliminate the error info as below:

i2c i2c-10: of_i2c: modalias failure on /axi/i2c@ff030000/i2c-mux@74/i2c@4/clock-generator@69
i2c i2c-10: Failed to create I2C device for /axi/i2c@ff030000/i2c-mux@74/i2c@4/clock-generator@69

Fixes: 82a7ebf00224 ("arm64: dts: zynqmp: Add DT description for si5328 for zcu102/zcu106")
Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
---
 arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 1 +
 arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
index 12e8bd48dc8c..a73841ad24ce 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
@@ -590,6 +590,7 @@ si5328: clock-generator@69 {/* SI5328 - u20 */
 				#address-cells = <1>;
 				#size-cells = <0>;
 				#clock-cells = <1>;
+				compatible = "silabs,si5328";
 				clocks = <&refhdmi>;
 				clock-names = "xtal";
 				clock-output-names = "si5328";
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
index 18771e868399..24ce64364d63 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
@@ -591,6 +591,7 @@ si5328: clock-generator@69 {/* SI5328 - u20 */
 				#address-cells = <1>;
 				#size-cells = <0>;
 				#clock-cells = <1>;
+				compatible = "silabs,si5328";
 				clocks = <&refhdmi>;
 				clock-names = "xtal";
 				clock-output-names = "si5328";
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: zynqmp: Add compatible strings for si5328
  2021-03-08  7:08 [PATCH] arm64: dts: zynqmp: Add compatible strings for si5328 quanyang.wang
@ 2021-03-08  8:35 ` Laurent Pinchart
  2021-03-08  8:47   ` Michal Simek
  2021-03-08 10:12   ` quanyang.wang
  0 siblings, 2 replies; 5+ messages in thread
From: Laurent Pinchart @ 2021-03-08  8:35 UTC (permalink / raw)
  To: quanyang.wang
  Cc: Rob Herring, Michal Simek, Krzysztof Kozlowski, devicetree,
	linux-arm-kernel, linux-kernel

Hi Quanyang,

Thank you for the patch.

On Mon, Mar 08, 2021 at 03:08:43PM +0800, quanyang.wang@windriver.com wrote:
> From: Quanyang Wang <quanyang.wang@windriver.com>
> 
> The function of_i2c_get_board_info will call of_modalias_node to check
> if a device_node contains "compatible" string. So let's assign the
> proper string "silabs,si5328" to clock-generator@69's compatible
> property to eliminate the error info as below:

As far as I can tell, "silabs,si5328" isn't documented in
Documentation/devicetree/bindings/. We need DT bindings before making
use of the compatible string.

> i2c i2c-10: of_i2c: modalias failure on /axi/i2c@ff030000/i2c-mux@74/i2c@4/clock-generator@69
> i2c i2c-10: Failed to create I2C device for /axi/i2c@ff030000/i2c-mux@74/i2c@4/clock-generator@69
> 
> Fixes: 82a7ebf00224 ("arm64: dts: zynqmp: Add DT description for si5328 for zcu102/zcu106")
> Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
> ---
>  arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 1 +
>  arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> index 12e8bd48dc8c..a73841ad24ce 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> @@ -590,6 +590,7 @@ si5328: clock-generator@69 {/* SI5328 - u20 */
>  				#address-cells = <1>;
>  				#size-cells = <0>;
>  				#clock-cells = <1>;
> +				compatible = "silabs,si5328";
>  				clocks = <&refhdmi>;
>  				clock-names = "xtal";
>  				clock-output-names = "si5328";
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> index 18771e868399..24ce64364d63 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> @@ -591,6 +591,7 @@ si5328: clock-generator@69 {/* SI5328 - u20 */
>  				#address-cells = <1>;
>  				#size-cells = <0>;
>  				#clock-cells = <1>;
> +				compatible = "silabs,si5328";
>  				clocks = <&refhdmi>;
>  				clock-names = "xtal";
>  				clock-output-names = "si5328";

-- 
Regards,

Laurent Pinchart

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: zynqmp: Add compatible strings for si5328
  2021-03-08  8:35 ` Laurent Pinchart
@ 2021-03-08  8:47   ` Michal Simek
  2021-03-08 10:15     ` quanyang.wang
  2021-03-08 10:12   ` quanyang.wang
  1 sibling, 1 reply; 5+ messages in thread
From: Michal Simek @ 2021-03-08  8:47 UTC (permalink / raw)
  To: Laurent Pinchart, quanyang.wang
  Cc: Rob Herring, Michal Simek, Krzysztof Kozlowski, devicetree,
	linux-arm-kernel, linux-kernel

Hi,

On 3/8/21 9:35 AM, Laurent Pinchart wrote:
> Hi Quanyang,
> 
> Thank you for the patch.
> 
> On Mon, Mar 08, 2021 at 03:08:43PM +0800, quanyang.wang@windriver.com wrote:
>> From: Quanyang Wang <quanyang.wang@windriver.com>
>>
>> The function of_i2c_get_board_info will call of_modalias_node to check
>> if a device_node contains "compatible" string. So let's assign the
>> proper string "silabs,si5328" to clock-generator@69's compatible
>> property to eliminate the error info as below:
> 
> As far as I can tell, "silabs,si5328" isn't documented in
> Documentation/devicetree/bindings/. We need DT bindings before making
> use of the compatible string.
> 

the second option is to remove/comment this node.

Thanks,
Michal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: zynqmp: Add compatible strings for si5328
  2021-03-08  8:35 ` Laurent Pinchart
  2021-03-08  8:47   ` Michal Simek
@ 2021-03-08 10:12   ` quanyang.wang
  1 sibling, 0 replies; 5+ messages in thread
From: quanyang.wang @ 2021-03-08 10:12 UTC (permalink / raw)
  To: Laurent Pinchart
  Cc: Rob Herring, Michal Simek, Krzysztof Kozlowski, devicetree,
	linux-arm-kernel, linux-kernel

Hi Laurent,

On 3/8/21 4:35 PM, Laurent Pinchart wrote:
> Hi Quanyang,
>
> Thank you for the patch.
>
> On Mon, Mar 08, 2021 at 03:08:43PM +0800, quanyang.wang@windriver.com wrote:
>> From: Quanyang Wang <quanyang.wang@windriver.com>
>>
>> The function of_i2c_get_board_info will call of_modalias_node to check
>> if a device_node contains "compatible" string. So let's assign the
>> proper string "silabs,si5328" to clock-generator@69's compatible
>> property to eliminate the error info as below:
> As far as I can tell, "silabs,si5328" isn't documented in
> Documentation/devicetree/bindings/. We need DT bindings before making
> use of the compatible string.

Thank you for your review.

I will send a new patch to delete these device nodes.

Best Regards

Quanyang

>
>> i2c i2c-10: of_i2c: modalias failure on /axi/i2c@ff030000/i2c-mux@74/i2c@4/clock-generator@69
>> i2c i2c-10: Failed to create I2C device for /axi/i2c@ff030000/i2c-mux@74/i2c@4/clock-generator@69
>>
>> Fixes: 82a7ebf00224 ("arm64: dts: zynqmp: Add DT description for si5328 for zcu102/zcu106")
>> Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
>> ---
>>   arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 1 +
>>   arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
>> index 12e8bd48dc8c..a73841ad24ce 100644
>> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
>> @@ -590,6 +590,7 @@ si5328: clock-generator@69 {/* SI5328 - u20 */
>>   				#address-cells = <1>;
>>   				#size-cells = <0>;
>>   				#clock-cells = <1>;
>> +				compatible = "silabs,si5328";
>>   				clocks = <&refhdmi>;
>>   				clock-names = "xtal";
>>   				clock-output-names = "si5328";
>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
>> index 18771e868399..24ce64364d63 100644
>> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
>> @@ -591,6 +591,7 @@ si5328: clock-generator@69 {/* SI5328 - u20 */
>>   				#address-cells = <1>;
>>   				#size-cells = <0>;
>>   				#clock-cells = <1>;
>> +				compatible = "silabs,si5328";
>>   				clocks = <&refhdmi>;
>>   				clock-names = "xtal";
>>   				clock-output-names = "si5328";

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: zynqmp: Add compatible strings for si5328
  2021-03-08  8:47   ` Michal Simek
@ 2021-03-08 10:15     ` quanyang.wang
  0 siblings, 0 replies; 5+ messages in thread
From: quanyang.wang @ 2021-03-08 10:15 UTC (permalink / raw)
  To: Michal Simek, Laurent Pinchart
  Cc: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-kernel

Hi Michal,

On 3/8/21 4:47 PM, Michal Simek wrote:
> Hi,
>
> On 3/8/21 9:35 AM, Laurent Pinchart wrote:
>> Hi Quanyang,
>>
>> Thank you for the patch.
>>
>> On Mon, Mar 08, 2021 at 03:08:43PM +0800, quanyang.wang@windriver.com wrote:
>>> From: Quanyang Wang <quanyang.wang@windriver.com>
>>>
>>> The function of_i2c_get_board_info will call of_modalias_node to check
>>> if a device_node contains "compatible" string. So let's assign the
>>> proper string "silabs,si5328" to clock-generator@69's compatible
>>> property to eliminate the error info as below:
>> As far as I can tell, "silabs,si5328" isn't documented in
>> Documentation/devicetree/bindings/. We need DT bindings before making
>> use of the compatible string.
>>
> the second option is to remove/comment this node.

Thank you for your suggestion.

  I will send a new patch to delete these nodes and add some comments there.

Best Regards

Quanyang

>
> Thanks,
> Michal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-08 10:18 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-08  7:08 [PATCH] arm64: dts: zynqmp: Add compatible strings for si5328 quanyang.wang
2021-03-08  8:35 ` Laurent Pinchart
2021-03-08  8:47   ` Michal Simek
2021-03-08 10:15     ` quanyang.wang
2021-03-08 10:12   ` quanyang.wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).