* [PATCH] firmware: ti_sci: Correct the timeout type in ti_sci_do_xfer()
@ 2020-01-22 10:40 Peter Ujfalusi
2020-02-03 8:38 ` Tero Kristo
0 siblings, 1 reply; 4+ messages in thread
From: Peter Ujfalusi @ 2020-01-22 10:40 UTC (permalink / raw)
To: nm, t-kristo, ssantosh, santosh.shilimkar
Cc: lokeshvutla, linux-kernel, linux-arm-kernel
msecs_to_jiffies() returns 'unsigned long' and the timeout parameter for
wait_for_completion_timeout() is also 'unsigned long'
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/firmware/ti_sci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index 3d8241cb6921..361a82817c1f 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -422,7 +422,7 @@ static inline int ti_sci_do_xfer(struct ti_sci_info *info,
struct ti_sci_xfer *xfer)
{
int ret;
- int timeout;
+ unsigned long timeout;
struct device *dev = info->dev;
ret = mbox_send_message(info->chan_tx, &xfer->tx_message);
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] firmware: ti_sci: Correct the timeout type in ti_sci_do_xfer()
2020-01-22 10:40 [PATCH] firmware: ti_sci: Correct the timeout type in ti_sci_do_xfer() Peter Ujfalusi
@ 2020-02-03 8:38 ` Tero Kristo
2020-02-03 19:21 ` santosh.shilimkar
0 siblings, 1 reply; 4+ messages in thread
From: Tero Kristo @ 2020-02-03 8:38 UTC (permalink / raw)
To: Peter Ujfalusi, nm, ssantosh, santosh.shilimkar
Cc: lokeshvutla, linux-kernel, linux-arm-kernel
On 22/01/2020 12:40, Peter Ujfalusi wrote:
> msecs_to_jiffies() returns 'unsigned long' and the timeout parameter for
> wait_for_completion_timeout() is also 'unsigned long'
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Reviewed-by: Tero Kristo <t-kristo@ti.com>
> ---
> drivers/firmware/ti_sci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index 3d8241cb6921..361a82817c1f 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -422,7 +422,7 @@ static inline int ti_sci_do_xfer(struct ti_sci_info *info,
> struct ti_sci_xfer *xfer)
> {
> int ret;
> - int timeout;
> + unsigned long timeout;
> struct device *dev = info->dev;
>
> ret = mbox_send_message(info->chan_tx, &xfer->tx_message);
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] firmware: ti_sci: Correct the timeout type in ti_sci_do_xfer()
2020-02-03 8:38 ` Tero Kristo
@ 2020-02-03 19:21 ` santosh.shilimkar
0 siblings, 0 replies; 4+ messages in thread
From: santosh.shilimkar @ 2020-02-03 19:21 UTC (permalink / raw)
To: Peter Ujfalusi, ssantosh
Cc: Tero Kristo, nm, lokeshvutla, linux-kernel, linux-arm-kernel
Hi Peter,
On 2/3/20 12:38 AM, Tero Kristo wrote:
> On 22/01/2020 12:40, Peter Ujfalusi wrote:
>> msecs_to_jiffies() returns 'unsigned long' and the timeout parameter for
>> wait_for_completion_timeout() is also 'unsigned long'
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Reviewed-by: Tero Kristo <t-kristo@ti.com>
>
Can you collate all 3 patches in a series and repost
with Tero's ack ? I will add that to next merge window
queue.
Regards,
Santosh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] firmware: ti_sci: Correct the timeout type in ti_sci_do_xfer()
@ 2018-05-11 11:17 Peter Ujfalusi
0 siblings, 0 replies; 4+ messages in thread
From: Peter Ujfalusi @ 2018-05-11 11:17 UTC (permalink / raw)
To: linux-arm-kernel
It should be 'unsigned long', not int.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/firmware/ti_sci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index b74a533ef35b..398a6db4da88 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -419,7 +419,7 @@ static inline int ti_sci_do_xfer(struct ti_sci_info *info,
struct ti_sci_xfer *xfer)
{
int ret;
- int timeout;
+ unsigned long timeout;
struct device *dev = info->dev;
ret = mbox_send_message(info->chan_tx, &xfer->tx_message);
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-03 19:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-22 10:40 [PATCH] firmware: ti_sci: Correct the timeout type in ti_sci_do_xfer() Peter Ujfalusi
2020-02-03 8:38 ` Tero Kristo
2020-02-03 19:21 ` santosh.shilimkar
-- strict thread matches above, loose matches on Subject: below --
2018-05-11 11:17 Peter Ujfalusi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).