linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] ARM: dts: imx6ul: Add PXP node
@ 2019-06-06 16:46 Sébastien Szymanski
  2019-06-12 17:21 ` Marco Felsch
  0 siblings, 1 reply; 3+ messages in thread
From: Sébastien Szymanski @ 2019-06-06 16:46 UTC (permalink / raw)
  To: linux-kernel, linux-arm-kernel, devicetree, NXP Linux Team, Shawn Guo
  Cc: Mark Rutland, Sascha Hauer, Rob Herring, Pengutronix Kernel Team,
	Fabio Estevam

Add PXP node for i.MX6UL/L SoC.

Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
---
 arch/arm/boot/dts/imx6ul.dtsi  | 9 +++++++++
 arch/arm/boot/dts/imx6ull.dtsi | 6 ++++++
 2 files changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
index f10012de5eb6..a3c005373ae1 100644
--- a/arch/arm/boot/dts/imx6ul.dtsi
+++ b/arch/arm/boot/dts/imx6ul.dtsi
@@ -971,6 +971,15 @@
 				status = "disabled";
 			};
 
+			pxp: pxp@21cc000 {
+				compatible = "fsl,imx6ul-pxp";
+				reg = <0x021cc000 0x4000>;
+				interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clks IMX6UL_CLK_PXP>;
+				clock-names = "axi";
+				status = "disabled";
+			};
+
 			qspi: spi@21e0000 {
 				#address-cells = <1>;
 				#size-cells = <0>;
diff --git a/arch/arm/boot/dts/imx6ull.dtsi b/arch/arm/boot/dts/imx6ull.dtsi
index 22e4a307fa59..b017e925bd87 100644
--- a/arch/arm/boot/dts/imx6ull.dtsi
+++ b/arch/arm/boot/dts/imx6ull.dtsi
@@ -34,6 +34,12 @@
 	compatible = "fsl,imx6ull-ocotp", "syscon";
 };
 
+&pxp {
+	compatible = "fsl,imx6ull-pxp";
+	interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>,
+		     <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
+};
+
 &usdhc1 {
 	compatible = "fsl,imx6ull-usdhc", "fsl,imx6sx-usdhc";
 };
-- 
2.19.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] ARM: dts: imx6ul: Add PXP node
  2019-06-06 16:46 [PATCH 1/1] ARM: dts: imx6ul: Add PXP node Sébastien Szymanski
@ 2019-06-12 17:21 ` Marco Felsch
  2019-06-13 11:34   ` Sébastien Szymanski
  0 siblings, 1 reply; 3+ messages in thread
From: Marco Felsch @ 2019-06-12 17:21 UTC (permalink / raw)
  To: Sébastien Szymanski
  Cc: Mark Rutland, devicetree, Fabio Estevam, Sascha Hauer,
	linux-kernel, Rob Herring, NXP Linux Team,
	Pengutronix Kernel Team, Shawn Guo, linux-arm-kernel

Hi Sébastien,

On 19-06-06 18:46, Sébastien Szymanski wrote:
> Add PXP node for i.MX6UL/L SoC.
> 
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
>  arch/arm/boot/dts/imx6ul.dtsi  | 9 +++++++++
>  arch/arm/boot/dts/imx6ull.dtsi | 6 ++++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> index f10012de5eb6..a3c005373ae1 100644
> --- a/arch/arm/boot/dts/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul.dtsi
> @@ -971,6 +971,15 @@
>  				status = "disabled";
>  			};
>  
> +			pxp: pxp@21cc000 {
> +				compatible = "fsl,imx6ul-pxp";
> +				reg = <0x021cc000 0x4000>;
> +				interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks IMX6UL_CLK_PXP>;
> +				clock-names = "axi";
> +				status = "disabled";

Can you drop the status line because its a platform device and isn't
removeable.

> +			};
> +
>  			qspi: spi@21e0000 {
>  				#address-cells = <1>;
>  				#size-cells = <0>;
> diff --git a/arch/arm/boot/dts/imx6ull.dtsi b/arch/arm/boot/dts/imx6ull.dtsi
> index 22e4a307fa59..b017e925bd87 100644
> --- a/arch/arm/boot/dts/imx6ull.dtsi
> +++ b/arch/arm/boot/dts/imx6ull.dtsi
> @@ -34,6 +34,12 @@
>  	compatible = "fsl,imx6ull-ocotp", "syscon";
>  };
>  
> +&pxp {
> +	compatible = "fsl,imx6ull-pxp";
> +	interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>,
> +		     <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
> +};
> +
>  &usdhc1 {
>  	compatible = "fsl,imx6ull-usdhc", "fsl,imx6sx-usdhc";
>  };
> -- 
> 2.19.2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] ARM: dts: imx6ul: Add PXP node
  2019-06-12 17:21 ` Marco Felsch
@ 2019-06-13 11:34   ` Sébastien Szymanski
  0 siblings, 0 replies; 3+ messages in thread
From: Sébastien Szymanski @ 2019-06-13 11:34 UTC (permalink / raw)
  To: Marco Felsch
  Cc: Mark Rutland, devicetree, Fabio Estevam, Sascha Hauer,
	linux-kernel, Rob Herring, NXP Linux Team,
	Pengutronix Kernel Team, Shawn Guo, linux-arm-kernel

Hi Marco,

On 6/12/19 7:21 PM, Marco Felsch wrote:
> Hi Sébastien,
> 
> On 19-06-06 18:46, Sébastien Szymanski wrote:
>> Add PXP node for i.MX6UL/L SoC.
>>
>> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
>> ---
>>  arch/arm/boot/dts/imx6ul.dtsi  | 9 +++++++++
>>  arch/arm/boot/dts/imx6ull.dtsi | 6 ++++++
>>  2 files changed, 15 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
>> index f10012de5eb6..a3c005373ae1 100644
>> --- a/arch/arm/boot/dts/imx6ul.dtsi
>> +++ b/arch/arm/boot/dts/imx6ul.dtsi
>> @@ -971,6 +971,15 @@
>>  				status = "disabled";
>>  			};
>>  
>> +			pxp: pxp@21cc000 {
>> +				compatible = "fsl,imx6ul-pxp";
>> +				reg = <0x021cc000 0x4000>;
>> +				interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
>> +				clocks = <&clks IMX6UL_CLK_PXP>;
>> +				clock-names = "axi";
>> +				status = "disabled";
> 
> Can you drop the status line because its a platform device and isn't
> removeable.

Ok, done. thanks!

Regards,

> 
>> +			};
>> +
>>  			qspi: spi@21e0000 {
>>  				#address-cells = <1>;
>>  				#size-cells = <0>;
>> diff --git a/arch/arm/boot/dts/imx6ull.dtsi b/arch/arm/boot/dts/imx6ull.dtsi
>> index 22e4a307fa59..b017e925bd87 100644
>> --- a/arch/arm/boot/dts/imx6ull.dtsi
>> +++ b/arch/arm/boot/dts/imx6ull.dtsi
>> @@ -34,6 +34,12 @@
>>  	compatible = "fsl,imx6ull-ocotp", "syscon";
>>  };
>>  
>> +&pxp {
>> +	compatible = "fsl,imx6ull-pxp";
>> +	interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>,
>> +		     <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
>> +};
>> +
>>  &usdhc1 {
>>  	compatible = "fsl,imx6ull-usdhc", "fsl,imx6sx-usdhc";
>>  };
>> -- 
>> 2.19.2
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 


-- 
Sébastien Szymanski
Software engineer, Armadeus Systems
Tel: +33 (0)9 72 29 41 44
Fax: +33 (0)9 72 28 79 26

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-06-13 11:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-06 16:46 [PATCH 1/1] ARM: dts: imx6ul: Add PXP node Sébastien Szymanski
2019-06-12 17:21 ` Marco Felsch
2019-06-13 11:34   ` Sébastien Szymanski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).