[PATCH] soc: samsung: pmu: fix BUT->BIT macro typo

[PATCH] soc: samsung: pmu: fix BUT->BIT macro typo

[Krzysztof Kozlowski]

The macro EXYNOS5_USE_STANDBYWFI_ARM_CORE1 should use BIT, not BUT.  Fix
does not have real effect as the macro is not used in the code.

Fixes: af2e0a0754ac ("ARM: EXYNOS: Add PMU support for exynos5420")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 include/linux/soc/samsung/exynos-regs-pmu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/soc/samsung/exynos-regs-pmu.h b/include/linux/soc/samsung/exynos-regs-pmu.h
index fc9250fb3133..4bfd9a210da2 100644
--- a/include/linux/soc/samsung/exynos-regs-pmu.h
+++ b/include/linux/soc/samsung/exynos-regs-pmu.h
@@ -613,7 +613,7 @@
 
 /* For EXYNOS_CENTRAL_SEQ_OPTION */
 #define EXYNOS5_USE_STANDBYWFI_ARM_CORE0			BIT(16)
-#define EXYNOS5_USE_STANDBYWFI_ARM_CORE1			BUT(17)
+#define EXYNOS5_USE_STANDBYWFI_ARM_CORE1			BIT(17)
 #define EXYNOS5_USE_STANDBYWFE_ARM_CORE0			BIT(24)
 #define EXYNOS5_USE_STANDBYWFE_ARM_CORE1			BIT(25)
 
-- 
2.27.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] soc: samsung: pmu: fix BUT->BIT macro typo

[Alim Akhtar]

Hello Krzysztof

On Mon, May 17, 2021 at 7:59 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The macro EXYNOS5_USE_STANDBYWFI_ARM_CORE1 should use BIT, not BUT.  Fix
> does not have real effect as the macro is not used in the code.
>
Can we consider removing this? As this is not used in code.

> Fixes: af2e0a0754ac ("ARM: EXYNOS: Add PMU support for exynos5420")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---


>  include/linux/soc/samsung/exynos-regs-pmu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/soc/samsung/exynos-regs-pmu.h b/include/linux/soc/samsung/exynos-regs-pmu.h
> index fc9250fb3133..4bfd9a210da2 100644
> --- a/include/linux/soc/samsung/exynos-regs-pmu.h
> +++ b/include/linux/soc/samsung/exynos-regs-pmu.h
> @@ -613,7 +613,7 @@
>
>  /* For EXYNOS_CENTRAL_SEQ_OPTION */
>  #define EXYNOS5_USE_STANDBYWFI_ARM_CORE0                       BIT(16)
> -#define EXYNOS5_USE_STANDBYWFI_ARM_CORE1                       BUT(17)
> +#define EXYNOS5_USE_STANDBYWFI_ARM_CORE1                       BIT(17)
>  #define EXYNOS5_USE_STANDBYWFE_ARM_CORE0                       BIT(24)
>  #define EXYNOS5_USE_STANDBYWFE_ARM_CORE1                       BIT(25)
>
> --
> 2.27.0
>


-- 
Regards,
Alim

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] soc: samsung: pmu: fix BUT->BIT macro typo

[Krzysztof Kozlowski]

On 19/05/2021 10:36, Alim Akhtar wrote:
> Hello Krzysztof
> 
> On Mon, May 17, 2021 at 7:59 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>> The macro EXYNOS5_USE_STANDBYWFI_ARM_CORE1 should use BIT, not BUT.  Fix
>> does not have real effect as the macro is not used in the code.
>>
> Can we consider removing this? As this is not used in code.

Sure, I guess, if someone needs this bit, can always check in the
documentation :)

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel