From: Eddie James <eajames@linux.vnet.ibm.com>
To: Navid Emamdoost <navid.emamdoost@gmail.com>,
jae.hyun.yoo@linux.intel.com
Cc: linux-aspeed@lists.ozlabs.org, Andrew Jeffery <andrew@aj.id.au>,
kjlu@umn.edu, openbmc@lists.ozlabs.org,
Eddie James <eajames@linux.ibm.com>,
linux-kernel@vger.kernel.org, emamd001@umn.edu, smccaman@umn.edu,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v3] media: aspeed-video: Fix memory leaks in aspeed_video_probe
Date: Fri, 8 Nov 2019 14:37:41 -0600 [thread overview]
Message-ID: <6de50e1a-cb05-8d81-d043-00ed25eda845@linux.vnet.ibm.com> (raw)
In-Reply-To: <20191028171838.28533-1-navid.emamdoost@gmail.com>
On 10/28/19 12:18 PM, Navid Emamdoost wrote:
> In the implementation of aspeed_video_probe() the allocated memory for
> video should be released if either devm_ioremap_resource()
> or aspeed_video_init() or aspeed_video_setup_video() fails. Replace
> kzalloc() with devm_kzalloc to avoid explicit release for video.
Thanks,
Reviewed-by: Eddie James <eajames@linux.ibm.com>
>
> Fixes: d2b4387f3bdf ("media: platform: Add Aspeed Video Engine driver")
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> ---
> Changes in v3:
> -- fix call to devm_kzalloc()
> ---
> drivers/media/platform/aspeed-video.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c
> index eb12f3793062..70797b41447c 100644
> --- a/drivers/media/platform/aspeed-video.c
> +++ b/drivers/media/platform/aspeed-video.c
> @@ -1646,7 +1646,8 @@ static int aspeed_video_probe(struct platform_device *pdev)
> {
> int rc;
> struct resource *res;
> - struct aspeed_video *video = kzalloc(sizeof(*video), GFP_KERNEL);
> + struct aspeed_video *video =
> + devm_kzalloc(&pdev->dev, sizeof(*video), GFP_KERNEL);
>
> if (!video)
> return -ENOMEM;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-11-08 20:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 4:25 [PATCH] media: aspeed-video: Fix memory leaks in aspeed_video_probe Navid Emamdoost
2019-10-27 6:55 ` Markus Elfring
2019-10-28 16:27 ` Jae Hyun Yoo
2019-10-28 16:30 ` Navid Emamdoost
2019-10-28 16:58 ` [PATCH v2] " Navid Emamdoost
2019-10-28 17:01 ` Jae Hyun Yoo
2019-10-28 17:06 ` Navid Emamdoost
2019-10-28 17:08 ` Jae Hyun Yoo
2019-10-28 17:18 ` [PATCH v3] " Navid Emamdoost
2019-10-28 17:55 ` Jae Hyun Yoo
2019-11-08 20:37 ` Eddie James [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6de50e1a-cb05-8d81-d043-00ed25eda845@linux.vnet.ibm.com \
--to=eajames@linux.vnet.ibm.com \
--cc=andrew@aj.id.au \
--cc=eajames@linux.ibm.com \
--cc=emamd001@umn.edu \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=kjlu@umn.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=openbmc@lists.ozlabs.org \
--cc=smccaman@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).