linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-media@vger.kernel.org,
	openbmc@lists.ozlabs.org
Cc: kernel-janitors@vger.kernel.org, Andrew Jeffery <andrew@aj.id.au>,
	Kangjie Lu <kjlu@umn.edu>, Eddie James <eajames@linux.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Navid Emamdoost <emamd001@umn.edu>, Joel Stanley <joel@jms.id.au>,
	Stephen McCamant <smccaman@umn.edu>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH] media: aspeed-video: Fix memory leaks in aspeed_video_probe
Date: Sun, 27 Oct 2019 07:55:15 +0100	[thread overview]
Message-ID: <bec85427-66b8-e0fa-9ee2-07cc77cf4a7e@web.de> (raw)
In-Reply-To: <20191026042519.29446-1-navid.emamdoost@gmail.com>

…
> +++ b/drivers/media/platform/aspeed-video.c
> @@ -1663,18 +1663,24 @@ static int aspeed_video_probe(struct platform_device *pdev)
…
> +free_video:
> +	kfree(video);
…

I am curious if there is a need for such a memory release at another place.
How do you think about to add this function call also to the implementation
of the function “aspeed_video_remove”?

Regards,
Markus

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-10-27  6:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-26  4:25 [PATCH] media: aspeed-video: Fix memory leaks in aspeed_video_probe Navid Emamdoost
2019-10-27  6:55 ` Markus Elfring [this message]
2019-10-28 16:27 ` Jae Hyun Yoo
2019-10-28 16:30   ` Navid Emamdoost
2019-10-28 16:58   ` [PATCH v2] " Navid Emamdoost
2019-10-28 17:01     ` Jae Hyun Yoo
2019-10-28 17:06       ` Navid Emamdoost
2019-10-28 17:08         ` Jae Hyun Yoo
2019-10-28 17:18           ` [PATCH v3] " Navid Emamdoost
2019-10-28 17:55             ` Jae Hyun Yoo
2019-11-08 20:37             ` Eddie James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bec85427-66b8-e0fa-9ee2-07cc77cf4a7e@web.de \
    --to=markus.elfring@web.de \
    --cc=andrew@aj.id.au \
    --cc=eajames@linux.ibm.com \
    --cc=emamd001@umn.edu \
    --cc=joel@jms.id.au \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kjlu@umn.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=navid.emamdoost@gmail.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=smccaman@umn.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).